sample_data.sh uses underscores for keystoneclient commands

[Dolph Mathews]

Attempting to run sample_data.sh on master against keystoneclient master results in the following output:

    http://paste.openstack.org/raw/21276/

This appears to be caused by the fact that all parameters use underscores instead of hyphens (e.g. --role_id instead of --role-id).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/13999

[Alan Pevec (apevec)]

Actually, I don't think you had keystone master:

> usage: keystone user-role-add --user <user-id> --role <role-id>
> [--tenant_id <tenant-id>]

That indicates circa Essex keystoneclient , --user was renamed to --user_id for Folsom (bug 994744)
and then changed to use dash in commit 1fa29109c2194102b4c79fa7fd7328843af6998e "Change CLI options to use dashes"

[Alan Pevec (apevec)]

> Actually, I don't think you had keystone master:

I mean, keystoneclient master

[Dolph Mathews (dolph)]

Alan, you're absolutely correct. Leaving the review open, however, as I believe the changes are still valid... just not relevant here.