Transient test failure: test_token_expiry_maintained

Bug #1045962 reported by Dolph Mathews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Dolph Mathews

Bug Description

As discussed in today's #openstack-meeting for keystone, this test periodically fails, depending on when it's executed:

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-keystone-python26/tests/test_keystoneclient.py", line 397, in test_token_expiry_maintained reauthenticated_token.expires)
AssertionError: u'2012-09-05T16:12:00Z' != u'2012-09-05T16:12:01Z'
- 2012-09-05T16:12:00Z? ^
+ 2012-09-05T16:12:01Z? ^

Adam Young (ayoung)
Changed in keystone:
assignee: nobody → Adam Young (ayoung)
Revision history for this message
Adam Young (ayoung) wrote :

Seems to be a problem in parsing. Something seems to be dropping the milliseconds for one copy, and rounding up for other copies. Note that when this happens, although the reauthed token appears to have a later date, it is actually a problem on the parsing of the original token. Rounding up is ( I think) an indicator that miliseconds are maintained.

Revision history for this message
Adam Young (ayoung) wrote :

It takes a while, but this should break it eventually.

for I in `seq 1 1000` ; do ./run_tests.sh -x test_keystoneclient:KcMasterTestCase.test_token_expiry_maintained || break ; done

Joseph Heck (heckj)
Changed in keystone:
milestone: folsom-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14727

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/14727
Committed: http://github.com/openstack/keystone/commit/e94d2f9aa2a46082f35933505f3eb6a668493ff4
Submitter: Jenkins
Branch: master

commit e94d2f9aa2a46082f35933505f3eb6a668493ff4
Author: Adam Young <email address hidden>
Date: Tue Oct 23 22:39:04 2012 -0400

    Compare token expiry without seconds

    There is a rounding problem that occurs periodically. Token expiration
    Does not need to be confirmed to this level of granularity.

    Bug 1045962

    Change-Id: I361c5cf309c47b142c35c4359234fd0e44005e5a

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15742

Changed in keystone:
assignee: Adam Young (ayoung) → Dolph Mathews (dolph)
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/15742
Committed: http://github.com/openstack/keystone/commit/a10bd7a8eb418a4d9e84a9511ca3f0669e6e02e7
Submitter: Jenkins
Branch: master

commit a10bd7a8eb418a4d9e84a9511ca3f0669e6e02e7
Author: Dolph Mathews <email address hidden>
Date: Fri Nov 9 10:50:38 2012 -0600

    Fix transient test failures (bug 1077065, bug 1045962)

    Change-Id: I45a1167a473df02a4461286b8a09723315018fcb

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers