Valid keychain file names are not recognized
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Keychain.py |
New
|
Undecided
|
Unassigned | ||
Bug Description
The regular expression used by keychain.py to recognize valid keychain filenames is too strict. It will not permit keychain file names containing spaces, nor will it recognize those keychain files whose names do not end with the ".keychain" extension. Since neither of these restrictions is a problem for the system keychain API, I think it would be best if keychain.py were a bit more forgiving.
Unfortunately, this problem will require a little refactoring in addition to the regular expression change ... the assumption that all keychain files end in ".keychain" pervades most of the methods of class Keychain. Fixing the regular expression is easy, but all the places where it's assumed that the filename ends that way will also have to be patched.
| Stuart Colville (muffinresearch) wrote | #1 |
Hi,
You raise some valid points in your bug - I'm happy to apply any patches but I'm unable to actively maintain this project anymore as I no longer have a machine with OSX on it.