kayobe

Dell OS9 and OS6 switch config fails due to broken templating

  1. Series zed
  2. Bug #2061102
Bug #2061102 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Medium
Unassigned
Antelope
Fix Committed
Medium
Unassigned
Bobcat
Fix Committed
Medium
Unassigned
Caracal
Fix Released
Medium
Unassigned
Zed
Fix Committed
Medium
Unassigned

Bug Description

Previously the dellos6_config and dellos9_config modules accepted the name of a template file as their 'src' parameter, or a string containing the actual config. Now they only accept the config string. Kayobe passes the name of a template file, resulting in a strange error from the switch about an invalid command dellos6-config.j2 or dellos9-config.j2.

Mark Goddard (mgoddard)
Changed in kayobe:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/915554
Committed: https://opendev.org/openstack/kayobe/commit/67f09241e07b3119bb17ed59df2b40aa3c9dced9
Submitter: "Zuul (22348)"
Branch: master

commit 67f09241e07b3119bb17ed59df2b40aa3c9dced9
Author: Mark Goddard <email address hidden>
Date: Fri Apr 12 10:17:19 2024 +0100

    Fix Dell OS6 and Dell OS9 switch configuration

    Previously the dellos6_config and dellos9_config modules accepted the
    name of a template file as their 'src' parameter, or a string containing
    the actual config. Now they only accept the config string. Kayobe passes
    the name of a template file, resulting in a strange error from the
    switch about an invalid command dellos6-config.j2 or dellos9-config.j2.

    This change fixes the issue in the same way it was fixed for Dell OS10
    switches, by using the template lookup plugin to evaluate the config
    file template.

    Change-Id: Ic14e2b75c785b4db03b5e659e5a2be2ee83eace3
    Closes-Bug: #2061102

Changed in kayobe:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/917888

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/919514

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (unmaintained/zed)

Fix proposed to branch: unmaintained/zed
Review: https://review.opendev.org/c/openstack/kayobe/+/919515

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/917888
Committed: https://opendev.org/openstack/kayobe/commit/317f4cb3afec5dbdb7ce07f476afafe4926aff58
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 317f4cb3afec5dbdb7ce07f476afafe4926aff58
Author: Mark Goddard <email address hidden>
Date: Fri Apr 12 10:17:19 2024 +0100

    Fix Dell OS6 and Dell OS9 switch configuration

    Previously the dellos6_config and dellos9_config modules accepted the
    name of a template file as their 'src' parameter, or a string containing
    the actual config. Now they only accept the config string. Kayobe passes
    the name of a template file, resulting in a strange error from the
    switch about an invalid command dellos6-config.j2 or dellos9-config.j2.

    This change fixes the issue in the same way it was fixed for Dell OS10
    switches, by using the template lookup plugin to evaluate the config
    file template.

    Change-Id: Ic14e2b75c785b4db03b5e659e5a2be2ee83eace3
    Closes-Bug: #2061102
    (cherry picked from commit 67f09241e07b3119bb17ed59df2b40aa3c9dced9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/919514
Committed: https://opendev.org/openstack/kayobe/commit/a612a672e76bf1b332b3510698caaa7af3ada6b0
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit a612a672e76bf1b332b3510698caaa7af3ada6b0
Author: Mark Goddard <email address hidden>
Date: Fri Apr 12 10:17:19 2024 +0100

    Fix Dell OS6 and Dell OS9 switch configuration

    Previously the dellos6_config and dellos9_config modules accepted the
    name of a template file as their 'src' parameter, or a string containing
    the actual config. Now they only accept the config string. Kayobe passes
    the name of a template file, resulting in a strange error from the
    switch about an invalid command dellos6-config.j2 or dellos9-config.j2.

    This change fixes the issue in the same way it was fixed for Dell OS10
    switches, by using the template lookup plugin to evaluate the config
    file template.

    Change-Id: Ic14e2b75c785b4db03b5e659e5a2be2ee83eace3
    Closes-Bug: #2061102
    (cherry picked from commit 67f09241e07b3119bb17ed59df2b40aa3c9dced9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (unmaintained/zed)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/919515
Committed: https://opendev.org/openstack/kayobe/commit/bddb498aab2517c4d02e9ed16371000b6700afe3
Submitter: "Zuul (22348)"
Branch: unmaintained/zed

commit bddb498aab2517c4d02e9ed16371000b6700afe3
Author: Mark Goddard <email address hidden>
Date: Fri Apr 12 10:17:19 2024 +0100

    Fix Dell OS6 and Dell OS9 switch configuration

    Previously the dellos6_config and dellos9_config modules accepted the
    name of a template file as their 'src' parameter, or a string containing
    the actual config. Now they only accept the config string. Kayobe passes
    the name of a template file, resulting in a strange error from the
    switch about an invalid command dellos6-config.j2 or dellos9-config.j2.

    This change fixes the issue in the same way it was fixed for Dell OS10
    switches, by using the template lookup plugin to evaluate the config
    file template.

    Change-Id: Ic14e2b75c785b4db03b5e659e5a2be2ee83eace3
    Closes-Bug: #2061102
    (cherry picked from commit 67f09241e07b3119bb17ed59df2b40aa3c9dced9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 16.0.0.0rc1

This issue was fixed in the openstack/kayobe 16.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.