Kayobe does pass through check and diff to kolla-ansible

[Matt Anson]

**Bug Report**

What happened: Running kayobe overcloud service deploy --check --diff resulted in changes on the target hosts.

What you expected to happen: Running kayobe overcloud service deploy --check --diff should not result in changes on the target hosts, because the --check and --diff arguments are passed through to ansible-playbook when it is called from kolla-ansible.

**Environment**:
* OS (e.g. from /etc/os-release): Rocky 9
* Kolla version (e.g. `git head or tag or stable branch` or pip package version if using release): 2024.2+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2025.1
Review: https://review.opendev.org/c/openstack/kayobe/+/961799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/960884
Committed: https://opendev.org/openstack/kayobe/commit/f5a5ddb043248e09461996907dcc6312bd7f7dd0
Submitter: "Zuul (22348)"
Branch: master

commit f5a5ddb043248e09461996907dcc6312bd7f7dd0
Author: Matt Anson <email address hidden>
Date: Fri Sep 12 20:41:57 2025 +0100

    Explicity set --check and --diff in kolla-ansible

    Kolla Ansible no longer supports appending the content of the EXTRA_OPTS
    environment variable to the ansible-playbook command. Kolla Ansible now
    supports --check and --diff as explicit CLI arguments, so explicitly
    pass them into kolla-ansible.

    Closes-Bug: #2123834
    Change-Id: Ia91e5539f4338c8209fbe92739bce916c10b2b7a
    Signed-off-by: Matt Anson <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/kayobe/+/961920

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/961799
Committed: https://opendev.org/openstack/kayobe/commit/67c17933948449ae6e1ff82404279718bc5d9a07
Submitter: "Zuul (22348)"
Branch: stable/2025.1

commit 67c17933948449ae6e1ff82404279718bc5d9a07
Author: Matt Anson <email address hidden>
Date: Fri Sep 12 20:41:57 2025 +0100

    Explicity set --check and --diff in kolla-ansible

    Kolla Ansible no longer supports appending the content of the EXTRA_OPTS
    environment variable to the ansible-playbook command. Kolla Ansible now
    supports --check and --diff as explicit CLI arguments, so explicitly
    pass them into kolla-ansible.

    Closes-Bug: #2123834
    Change-Id: Ia91e5539f4338c8209fbe92739bce916c10b2b7a
    Signed-off-by: Matt Anson <email address hidden>
    (cherry picked from commit f5a5ddb043248e09461996907dcc6312bd7f7dd0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/961920
Committed: https://opendev.org/openstack/kayobe/commit/515ec7ee5e0fa8ecf8e90cf69bf5c766c9f9e793
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit 515ec7ee5e0fa8ecf8e90cf69bf5c766c9f9e793
Author: Matt Anson <email address hidden>
Date: Fri Sep 12 20:41:57 2025 +0100

    Explicity set --check and --diff in kolla-ansible

    Kolla Ansible no longer supports appending the content of the EXTRA_OPTS
    environment variable to the ansible-playbook command. Kolla Ansible now
    supports --check and --diff as explicit CLI arguments, so explicitly
    pass them into kolla-ansible.

    Closes-Bug: #2123834
    Change-Id: Ia91e5539f4338c8209fbe92739bce916c10b2b7a
    Signed-off-by: Matt Anson <email address hidden>
    (cherry picked from commit f5a5ddb043248e09461996907dcc6312bd7f7dd0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 17.7.0 Dalmatian release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 18.3.0 Epoxy release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 19.0.0.0rc1 Flamingo release candidate.