Wipe disks role doesn't support newer lsblk

Bug #2051859 reported by Dawud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Status tracked in Caracal
Antelope
Fix Released
Undecided
Unassigned
Bobcat
Fix Released
Undecided
Unassigned
Caracal
Fix Released
High
Dawud
Zed
Fix Released
Undecided
Unassigned

Bug Description

On Rocky Linux 9 and Ubuntu Jammy (probably due to a newer version of lsblk), the ``wipe_disks`` role is not properly configured due to the fact that ``lsblk -J`` returns a slightly different output than what was previously returned.

When running ``kayobe overcloud host configure --wipe-disks`` the role skips all the disks that are supposed to be wiped.

Dawud (dawudm)
Changed in kayobe:
assignee: nobody → Dawud (dawudm)
Changed in kayobe:
status: New → In Progress
Will Szumski (willjs)
Changed in kayobe:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/907105
Committed: https://opendev.org/openstack/kayobe/commit/3942d29448d16b4ef8e9682b4d08fd03d1dbe2cd
Submitter: "Zuul (22348)"
Branch: master

commit 3942d29448d16b4ef8e9682b4d08fd03d1dbe2cd
Author: Dawud <email address hidden>
Date: Mon Jan 29 17:32:31 2024 +0000

    Fix wipe-disks role to work on util-linux >= 2.37

    On newer versions of util-linux, the ``wipe_disks`` role was not
    properly configured due to the fact that ``lsblk -J`` returns a slightly
    different output than what was previously returned. Previously the
    output would contain a key called ``mountpoint``, however this has been
    changed to ``mountpoints``. This has now been fixed by looking at the
    new key as well as the old key.

    Closes-bug: #2051859
    Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/909089

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/909090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kayobe/+/909091

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/909089
Committed: https://opendev.org/openstack/kayobe/commit/b2f0ef64cef372d577f5d3159fe75e63ba1124e2
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit b2f0ef64cef372d577f5d3159fe75e63ba1124e2
Author: Dawud <email address hidden>
Date: Mon Jan 29 17:32:31 2024 +0000

    Fix wipe-disks role to work on util-linux >= 2.37

    On newer versions of util-linux, the ``wipe_disks`` role was not
    properly configured due to the fact that ``lsblk -J`` returns a slightly
    different output than what was previously returned. Previously the
    output would contain a key called ``mountpoint``, however this has been
    changed to ``mountpoints``. This has now been fixed by looking at the
    new key as well as the old key.

    Closes-bug: #2051859
    Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41
    (cherry picked from commit 3942d29448d16b4ef8e9682b4d08fd03d1dbe2cd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/909090
Committed: https://opendev.org/openstack/kayobe/commit/bcf1cdea9fa871e4dde85da86fb2d823060b1d4b
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit bcf1cdea9fa871e4dde85da86fb2d823060b1d4b
Author: Dawud <email address hidden>
Date: Mon Jan 29 17:32:31 2024 +0000

    Fix wipe-disks role to work on util-linux >= 2.37

    On newer versions of util-linux, the ``wipe_disks`` role was not
    properly configured due to the fact that ``lsblk -J`` returns a slightly
    different output than what was previously returned. Previously the
    output would contain a key called ``mountpoint``, however this has been
    changed to ``mountpoints``. This has now been fixed by looking at the
    new key as well as the old key.

    Closes-bug: #2051859
    Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41
    (cherry picked from commit 3942d29448d16b4ef8e9682b4d08fd03d1dbe2cd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/909091
Committed: https://opendev.org/openstack/kayobe/commit/a78029236a705c9d90c65f38d44dd51d10de503a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit a78029236a705c9d90c65f38d44dd51d10de503a
Author: Dawud <email address hidden>
Date: Mon Jan 29 17:32:31 2024 +0000

    Fix wipe-disks role to work on util-linux >= 2.37

    On newer versions of util-linux, the ``wipe_disks`` role was not
    properly configured due to the fact that ``lsblk -J`` returns a slightly
    different output than what was previously returned. Previously the
    output would contain a key called ``mountpoint``, however this has been
    changed to ``mountpoints``. This has now been fixed by looking at the
    new key as well as the old key.

    Closes-bug: #2051859
    Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41
    (cherry picked from commit 3942d29448d16b4ef8e9682b4d08fd03d1dbe2cd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 14.5.0

This issue was fixed in the openstack/kayobe 14.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 15.3.0

This issue was fixed in the openstack/kayobe 15.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 13.6.0

This issue was fixed in the openstack/kayobe 13.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.