Antelope+ overcloud host configured mishandle /etc/hosts when limiting a run to specific hosts

[Matt Crees]

Running an overcloud host configure limited to some hosts will remove the others from /etc/hosts.

kayobe overcloud host configure --check --diff --limit con1

TASK [etc-hosts : Generate /etc/hosts for all of the nodes] ********************
Tuesday 30 January 2024 15:30:45 +0000 (0:00:00.214) 0:01:18.792 *******
--- before: /etc/hosts (content)
+++ after: /etc/hosts (content)
@@ -2,16 +2,6 @@
 127.0.0.1 localhost
 # BEGIN ANSIBLE GENERATED HOSTS
 10.1.2.1 con1
-10.1.2.2 con2
-10.1.2.3 con3
-10.1.2.4 com1
-10.1.2.4 com2
-10.1.2.6 com3
 # END ANSIBLE GENERATED HOSTS

This is because the variable ``ansible_play_hosts_all`` is used to determine which hosts are templated: https://github.com/openstack/kayobe/blob/0e1532e66dea2f59693796598cc7548e60d44f25/ansible/roles/etc-hosts/defaults/main.yml#L6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe/+/907306

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/908262

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/908263

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Matt Crees <email address hidden>" on branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/908262
Reason: cherry-picked too early - wait for master to merge

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Matt Crees <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/908263
Reason: cherry-picked too early - wait for master to merge

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/907306
Committed: https://opendev.org/openstack/kayobe/commit/498de81efe88707e5fd91dba24cdee2a529dedbc
Submitter: "Zuul (22348)"
Branch: master

commit 498de81efe88707e5fd91dba24cdee2a529dedbc
Author: Matt Crees <email address hidden>
Date: Wed Jan 31 10:36:19 2024 +0000

    Fix: configure etc-hosts for overcloud group

    Change the etc-hosts role to run on the overcloud group, as using
    ``ansible_play_hosts_all`` would exclude hosts when running with a
    limit.

    Also change the gather-facts-delegated role to run on the overcloud
    group. The delegated task needs to be included separately as the hostvar
    ``ansible_host`` cannot be set dynamically based on a loop item in one
    task. We loop over the batch indices here so that the tasks are included
    in parallel, rather than in series.

    Closes-Bug: #2051714

    Change-Id: I0465eafa9e4ff37c96064ea8395f0bd461035b40

[Matt Crees (mattcrees)]

Doesn't affect Zed, etc-hosts role only present in 2023.1 onwards.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/908262
Committed: https://opendev.org/openstack/kayobe/commit/1bcf3e19e202e4409f94eff257e5e190bbb26d19
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 1bcf3e19e202e4409f94eff257e5e190bbb26d19
Author: Matt Crees <email address hidden>
Date: Wed Jan 31 10:36:19 2024 +0000

    Fix: configure etc-hosts for overcloud group

    Change the etc-hosts role to run on the overcloud group, as using
    ``ansible_play_hosts_all`` would exclude hosts when running with a
    limit.

    Also change the gather-facts-delegated role to run on the overcloud
    group. The delegated task needs to be included separately as the hostvar
    ``ansible_host`` cannot be set dynamically based on a loop item in one
    task. We loop over the batch indices here so that the tasks are included
    in parallel, rather than in series.

    Closes-Bug: #2051714

    Change-Id: I0465eafa9e4ff37c96064ea8395f0bd461035b40
    (cherry picked from commit 498de81efe88707e5fd91dba24cdee2a529dedbc)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/908263
Committed: https://opendev.org/openstack/kayobe/commit/d7d779533e62ebee40843976c2cd7d8f169bb039
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d7d779533e62ebee40843976c2cd7d8f169bb039
Author: Matt Crees <email address hidden>
Date: Wed Jan 31 10:36:19 2024 +0000

    Fix: configure etc-hosts for overcloud group

    Change the etc-hosts role to run on the overcloud group, as using
    ``ansible_play_hosts_all`` would exclude hosts when running with a
    limit.

    Also change the gather-facts-delegated role to run on the overcloud
    group. The delegated task needs to be included separately as the hostvar
    ``ansible_host`` cannot be set dynamically based on a loop item in one
    task. We loop over the batch indices here so that the tasks are included
    in parallel, rather than in series.

    Closes-Bug: #2051714

    Change-Id: I0465eafa9e4ff37c96064ea8395f0bd461035b40
    (cherry picked from commit 498de81efe88707e5fd91dba24cdee2a529dedbc)

[Maksim Malchuk (mmalchuk)]

IMHO Zed is affected in Kolla-Ansible and should be fixed in the baremetal role. Need check.