Invalid Bifrost ConfigDrive gateway assignment when seed SNAT is disabled

[Pierre Riteau]

When seed SNAT is disabled, the Bifrost host vars used to generate the ConfigDrive have the IPv4 gateway variable unset even if a gateway is defined on the admin network.

This is a regression in https://review.opendev.org/c/openstack/kayobe/+/898434

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/902113
Committed: https://opendev.org/openstack/kayobe/commit/49f91043c6c3b0549a8625baba1e6e218eb69160
Submitter: "Zuul (22348)"
Branch: master

commit 49f91043c6c3b0549a8625baba1e6e218eb69160
Author: Stig Telfer <email address hidden>
Date: Tue Nov 28 21:55:32 2023 +0000

    Fix gateway assignment when seed SNAT is disabled

    Fix a logic issue when seed SNAT is not enabled. In this circumstance
    Bifrost was generating ConfigDrive data with the default gateway unset
    even when one is available on the admin network. This regression was
    introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

    [1] https://review.opendev.org/c/openstack/kayobe/+/898434

    Closes-Bug: #2045926
    Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/903142

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/903143

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kayobe/+/903144

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kayobe/+/903145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/903142
Committed: https://opendev.org/openstack/kayobe/commit/56e592b6489dbfc21d2071b24c1ca3767bc52e91
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 56e592b6489dbfc21d2071b24c1ca3767bc52e91
Author: Stig Telfer <email address hidden>
Date: Tue Nov 28 21:55:32 2023 +0000

    Fix gateway assignment when seed SNAT is disabled

    Fix a logic issue when seed SNAT is not enabled. In this circumstance
    Bifrost was generating ConfigDrive data with the default gateway unset
    even when one is available on the admin network. This regression was
    introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

    [1] https://review.opendev.org/c/openstack/kayobe/+/898434

    Closes-Bug: #2045926
    Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55
    (cherry picked from commit 49f91043c6c3b0549a8625baba1e6e218eb69160)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/903145
Committed: https://opendev.org/openstack/kayobe/commit/2c625dd590e0b0a1cdcfe0ec6b34dfc147b6b7c6
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 2c625dd590e0b0a1cdcfe0ec6b34dfc147b6b7c6
Author: Stig Telfer <email address hidden>
Date: Tue Nov 28 21:55:32 2023 +0000

    Fix gateway assignment when seed SNAT is disabled

    Fix a logic issue when seed SNAT is not enabled. In this circumstance
    Bifrost was generating ConfigDrive data with the default gateway unset
    even when one is available on the admin network. This regression was
    introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

    [1] https://review.opendev.org/c/openstack/kayobe/+/898434

    Closes-Bug: #2045926
    Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55
    (cherry picked from commit 49f91043c6c3b0549a8625baba1e6e218eb69160)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/903144
Committed: https://opendev.org/openstack/kayobe/commit/aefef5dff8fe19517414a3d0fb26390e2e997a04
Submitter: "Zuul (22348)"
Branch: stable/zed

commit aefef5dff8fe19517414a3d0fb26390e2e997a04
Author: Stig Telfer <email address hidden>
Date: Tue Nov 28 21:55:32 2023 +0000

    Fix gateway assignment when seed SNAT is disabled

    Fix a logic issue when seed SNAT is not enabled. In this circumstance
    Bifrost was generating ConfigDrive data with the default gateway unset
    even when one is available on the admin network. This regression was
    introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

    [1] https://review.opendev.org/c/openstack/kayobe/+/898434

    Closes-Bug: #2045926
    Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55
    (cherry picked from commit 49f91043c6c3b0549a8625baba1e6e218eb69160)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/903143
Committed: https://opendev.org/openstack/kayobe/commit/1c4409735d3c2d21ca9dea29798d5e1f5747c59f
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 1c4409735d3c2d21ca9dea29798d5e1f5747c59f
Author: Stig Telfer <email address hidden>
Date: Tue Nov 28 21:55:32 2023 +0000

    Fix gateway assignment when seed SNAT is disabled

    Fix a logic issue when seed SNAT is not enabled. In this circumstance
    Bifrost was generating ConfigDrive data with the default gateway unset
    even when one is available on the admin network. This regression was
    introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

    [1] https://review.opendev.org/c/openstack/kayobe/+/898434

    Closes-Bug: #2045926
    Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55
    (cherry picked from commit 49f91043c6c3b0549a8625baba1e6e218eb69160)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 14.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 15.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 12.10.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kayobe 13.4.0 release.