kayobe

kayobe-env: KOLLA_SOURCE_PATH and KOLLA_VENV_PATH are sticky

Bug #2036711 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Medium
Unassigned
Antelope
Fix Released
Medium
Unassigned
Bobcat
Fix Released
Medium
Unassigned
Yoga
Fix Released
Medium
Unassigned
Zed
Fix Released
Medium
Unassigned

Bug Description

The kayobe-env script in kayobe-config does not update the KOLLA_SOURCE_PATH and KOLLA_VENV_PATH variables if they are already set. This can lead to dangerous and difficult to diagnose issues where Kayobe uses a different version of Kolla Ansible than expected.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe-config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe-config/+/895888

Changed in kayobe:
status: New → In Progress
Mark Goddard (mgoddard)
Changed in kayobe:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe-config (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe-config/+/895888
Committed: https://opendev.org/openstack/kayobe-config/commit/651b8be1a0a2dd38ab46253a0c4a9c7d617cf7bc
Submitter: "Zuul (22348)"
Branch: master

commit 651b8be1a0a2dd38ab46253a0c4a9c7d617cf7bc
Author: Mark Goddard <email address hidden>
Date: Wed Sep 20 09:14:17 2023 +0100

    kayobe-env: Unstick KOLLA_SOURCE_PATH and KOLLA_VENV_PATH

    The kayobe-env script does not update the KOLLA_SOURCE_PATH and
    KOLLA_VENV_PATH variables if they are already set. This can lead to
    dangerous and difficult to diagnose issues where Kayobe uses a different
    version of Kolla Ansible than expected.

    This change updates these variables each time the kayobe-env script is
    sourced.

    Change-Id: I3b4b0b611750b9c7846ff5f74554aee2f14939e4
    Closes-Bug: #2036711

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe-config (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe-config/+/896114

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe-config (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kayobe-config/+/896115

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe-config (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kayobe-config/+/896116

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe-config (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe-config/+/896114
Committed: https://opendev.org/openstack/kayobe-config/commit/bf09c41ddcec60d3ab4404ea8860d99e4380d948
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit bf09c41ddcec60d3ab4404ea8860d99e4380d948
Author: Mark Goddard <email address hidden>
Date: Wed Sep 20 09:14:17 2023 +0100

    kayobe-env: Unstick KOLLA_SOURCE_PATH and KOLLA_VENV_PATH

    The kayobe-env script does not update the KOLLA_SOURCE_PATH and
    KOLLA_VENV_PATH variables if they are already set. This can lead to
    dangerous and difficult to diagnose issues where Kayobe uses a different
    version of Kolla Ansible than expected.

    This change updates these variables each time the kayobe-env script is
    sourced.

    Change-Id: I3b4b0b611750b9c7846ff5f74554aee2f14939e4
    Closes-Bug: #2036711
    (cherry picked from commit 651b8be1a0a2dd38ab46253a0c4a9c7d617cf7bc)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe-config (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kayobe-config/+/896115
Committed: https://opendev.org/openstack/kayobe-config/commit/665a05cdaacae6673d265b6d26e7c763f46aa6f5
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 665a05cdaacae6673d265b6d26e7c763f46aa6f5
Author: Mark Goddard <email address hidden>
Date: Wed Sep 20 09:14:17 2023 +0100

    kayobe-env: Unstick KOLLA_SOURCE_PATH and KOLLA_VENV_PATH

    The kayobe-env script does not update the KOLLA_SOURCE_PATH and
    KOLLA_VENV_PATH variables if they are already set. This can lead to
    dangerous and difficult to diagnose issues where Kayobe uses a different
    version of Kolla Ansible than expected.

    This change updates these variables each time the kayobe-env script is
    sourced.

    Change-Id: I3b4b0b611750b9c7846ff5f74554aee2f14939e4
    Closes-Bug: #2036711
    (cherry picked from commit 651b8be1a0a2dd38ab46253a0c4a9c7d617cf7bc)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe-config (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/kayobe-config/+/896116
Committed: https://opendev.org/openstack/kayobe-config/commit/ded3c040fa97ad77cd74ccb92f9ddcf2b3c692db
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit ded3c040fa97ad77cd74ccb92f9ddcf2b3c692db
Author: Mark Goddard <email address hidden>
Date: Wed Sep 20 09:14:17 2023 +0100

    kayobe-env: Unstick KOLLA_SOURCE_PATH and KOLLA_VENV_PATH

    The kayobe-env script does not update the KOLLA_SOURCE_PATH and
    KOLLA_VENV_PATH variables if they are already set. This can lead to
    dangerous and difficult to diagnose issues where Kayobe uses a different
    version of Kolla Ansible than expected.

    This change updates these variables each time the kayobe-env script is
    sourced.

    Change-Id: I3b4b0b611750b9c7846ff5f74554aee2f14939e4
    Closes-Bug: #2036711
    (cherry picked from commit 651b8be1a0a2dd38ab46253a0c4a9c7d617cf7bc)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe-config 15.0.0.0rc1

This issue was fixed in the openstack/kayobe-config 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe-config 14.3.0

This issue was fixed in the openstack/kayobe-config 14.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe-config 12.10.0

This issue was fixed in the openstack/kayobe-config 12.10.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe-config 13.4.0

This issue was fixed in the openstack/kayobe-config 13.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.