*_bridge_port variable should have a check if it was added as a list

Bug #2020378 reported by Bartosz Bezak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Low
Maksim Malchuk
Antelope
Fix Released
Low
Maksim Malchuk
Wallaby
Fix Released
Low
Maksim Malchuk
Xena
Fix Released
Low
Maksim Malchuk
Yoga
Fix Released
Low
Maksim Malchuk
Zed
Fix Released
Low
Maksim Malchuk

Bug Description

*_bridge_port variable should have a check if it was added as a list.

If user set string on bridge_ports variable it won't fail - it just template multiple incorrect files.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe/+/883867

Changed in kayobe:
status: New → In Progress
Changed in kayobe:
importance: Undecided → Low
assignee: nobody → Maksim Malchuk (mmalchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/883867
Committed: https://opendev.org/openstack/kayobe/commit/9b58320f6b40de3c33bee179d97dd0bf5bf61986
Submitter: "Zuul (22348)"
Branch: master

commit 9b58320f6b40de3c33bee179d97dd0bf5bf61986
Author: Maksim Malchuk <email address hidden>
Date: Mon May 22 21:44:25 2023 +0300

    Show an error when *_bridge_ports is not a list

    Closes-Bug: #2020378
    Change-Id: I000ae473bb759e19b48ecefdbf5d5dc19c833088
    Signed-off-by: Maksim Malchuk <email address hidden>

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kayobe/+/884242

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kayobe/+/884243

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kayobe/+/884244

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kayobe/+/884245

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/884245
Committed: https://opendev.org/openstack/kayobe/commit/8fb45c0aa856a8f12023f4205651632e20c8e282
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8fb45c0aa856a8f12023f4205651632e20c8e282
Author: Maksim Malchuk <email address hidden>
Date: Mon May 22 21:44:25 2023 +0300

    Show an error when *_bridge_ports is not a list

    Closes-Bug: #2020378
    Change-Id: I000ae473bb759e19b48ecefdbf5d5dc19c833088
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 9b58320f6b40de3c33bee179d97dd0bf5bf61986)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/884244
Committed: https://opendev.org/openstack/kayobe/commit/0bf45b190c62785514991866a38ca70344b006c6
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0bf45b190c62785514991866a38ca70344b006c6
Author: Maksim Malchuk <email address hidden>
Date: Mon May 22 21:44:25 2023 +0300

    Show an error when *_bridge_ports is not a list

    Closes-Bug: #2020378
    Change-Id: I000ae473bb759e19b48ecefdbf5d5dc19c833088
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 9b58320f6b40de3c33bee179d97dd0bf5bf61986)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 14.0.0.0rc1

This issue was fixed in the openstack/kayobe 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/884243
Committed: https://opendev.org/openstack/kayobe/commit/74911c52daf74347cdc479c87bcd4a065a5bc535
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 74911c52daf74347cdc479c87bcd4a065a5bc535
Author: Maksim Malchuk <email address hidden>
Date: Mon May 22 21:44:25 2023 +0300

    Show an error when *_bridge_ports is not a list

    Closes-Bug: #2020378
    Change-Id: I000ae473bb759e19b48ecefdbf5d5dc19c833088
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 9b58320f6b40de3c33bee179d97dd0bf5bf61986)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/884242
Committed: https://opendev.org/openstack/kayobe/commit/586d23550224d1f74a97d6e204fb23c84421f826
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 586d23550224d1f74a97d6e204fb23c84421f826
Author: Maksim Malchuk <email address hidden>
Date: Mon May 22 21:44:25 2023 +0300

    Show an error when *_bridge_ports is not a list

    Closes-Bug: #2020378
    Change-Id: I000ae473bb759e19b48ecefdbf5d5dc19c833088
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 9b58320f6b40de3c33bee179d97dd0bf5bf61986)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 12.8.0

This issue was fixed in the openstack/kayobe 12.8.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 13.2.0

This issue was fixed in the openstack/kayobe 13.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe wallaby-eol

This issue was fixed in the openstack/kayobe wallaby-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe xena-eol

This issue was fixed in the openstack/kayobe xena-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.