Files tool in large communities loads too many objects

Bug #1347066 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL4
Fix Released
Medium
Balazs Ree
4.2
New
Undecided
Unassigned

Bug Description

As follow on work to lp:1314685 we should see why we still load a bunch of objects in Justice Initiative. Most likely the big pile of JSON that goes into the HTML. First though see if it still a problem.

Changed in karl3:
milestone: m139 → m140
Changed in karl3:
milestone: m140 → m141
affects: karl3 → karl4
Changed in karl4:
assignee: Paul Everitt (paul-agendaless) → Balazs Ree (ree)
milestone: m141 → none
Revision history for this message
Balazs Ree (ree) wrote :

Before starting to improve things on the client side, I wanted to look at the server.

Besides some ux2 cruft removals but I am not sure if those will speed up. But I temporarily removed fetching the title of the files for the MoveTo popup. Instead we use the path segment to display now, which will not wake the file objects.

If it's possible to test if the original problem still exists, please do so! Based on the results, we can decide if I should continue to improve the clients as well. This is on branch ree-files-tool-slowdown-lp1347066.

Changed in karl4:
milestone: none → 001
Balazs Ree (ree)
Changed in karl4:
status: New → In Progress
Revision history for this message
Balazs Ree (ree) wrote :

As we discussed in a previous email, I improved the display of the folders a bit. Testable on ree-files-tool-slowdown-lp1347066.

Previously a-longer-folder-name becomes A Longer Folder Name.

Changed in karl4:
status: In Progress → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 1347066] Files tool in large communities loads too many objects

Is it possible to keep the old behavior for communities without a tremendous number of results? For example:

  for docid in docids:

at:

  https://github.com/karlproject/karl/commit/50a63b043cba3bfa5096eed067e81bfc320b8631#diff-5c65109b68aed58bc0aa4b266cf6633eR1284

Could you wrap that block with a test....if len(docids) is > than perhaps 200, do it the new way?

--Paul

On Oct 25, 2014, at 9:10 AM, Balazs Ree <email address hidden> wrote:

> As we discussed in a previous email, I improved the display of the
> folders a bit. Testable on ree-files-tool-slowdown-lp1347066.
>
> Previously a-longer-folder-name becomes A Longer Folder Name.
>
> ** Changed in: karl4
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1347066
>
> Title:
> Files tool in large communities loads too many objects
>
> Status in OSF KARL4:
> Fix Committed
>
> Bug description:
> As follow on work to lp:1314685 we should see why we still load a
> bunch of objects in Justice Initiative. Most likely the big pile of
> JSON that goes into the HTML. First though see if it still a problem.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl4/+bug/1347066/+subscriptions

Revision history for this message
Balazs Ree (ree) wrote :

I had an additional improvement idea, which I implemented in the end. Always look up the first 200 records in every community, and use the de-slugify filter only for the rest.

Changed in karl4:
milestone: 001 → 002
Changed in karl4:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.