Stop the staff hack for deciding to display Calendar in global nav, et al.

[JimPGlenn]

We have a number of hacks in Classic KARL. For example, to determine if we should show the Calendar as a top-level tag, we do a test on whether the current requesting user is "staff". That's a specific policy. Instead, we should make a new permission and diddle it on the site, allowing people to adjust the ACL.

This pattern is in a number of places. Find places where we check to see if a user is staff and refactor to use permissions instead.

refer to https://github.com/pauleveritt/pyramid_bottlecap/issues/34 for history.

[Balazs Ree (ree)]

perhaps it's easiest if I take this one.

[Balazs Ree (ree)]

Reading the task and understanding in depth, I conclude that this is independent from the work I am already doing on the global calendar, and it is completely server specific. That said, I give this back to the pool so perhaps it fits someone else better.

[Paul Everitt (paul-agendaless)]

Yes, this is something Chris saw early in the ux2 process. This is really part of the "rip out ux1" task we might do later.

--Paul

On Jun 20, 2012, at 6:24 AM, Balazs Ree wrote:

> Reading the task and understanding in depth, I conclude that this is
> independent from the work I am already doing on the global calendar, and
> it is completely server specific. That said, I give this back to the
> pool so perhaps it fits someone else better.
>
> ** Changed in: karl3
> Assignee: Balazs Ree (ree) => (unassigned)
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/956020
>
> Title:
> Stop the staff hack for deciding to display Calendar in global nav, et
> al.
>
> Status in KARL3:
> New
>
> Bug description:
> We have a number of hacks in Classic KARL. For example, to determine
> if we should show the Calendar as a top-level tag, we do a test on
> whether the current requesting user is "staff". That's a specific
> policy. Instead, we should make a new permission and diddle it on the
> site, allowing people to adjust the ACL.
>
> This pattern is in a number of places. Find places where we check to
> see if a user is staff and refactor to use permissions instead.
>
> refer to https://github.com/pauleveritt/pyramid_bottlecap/issues/34
> for history.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/956020/+subscriptions

[Tres Seaver (tseaver)]

Other uses:

- kark/ux2/panels.py tests for 'user_is_staff' to determine whether to include
  the 'Tags' link on the overflow menu.

- kar/views/templates/contentfeeds.pt restricts the 'feedoptions' div to
  users who are staff. Likewise for karl/us2/templates/contentfeeds.pt

- karl/view/templates/snippets.pt tests it (in the 'communities-listing-head'
  macro) to determine whether to show the 'community-filters' div.

- karl/views/templates/footer.pt tests it to determine whether to show
  links to the offices. Likewise karl/ux2/templates/footer.pt.