Advanced Search Filter Interaction

[Nat Katin-Borland]

Specifically, it can be confusing on how to reset filters for author or tag. If I have a large pile of results, then I filter that pile by an author. Good. Now I decide to search on a new term, but realize that even when I search for that new term I'm still tied to my previous author filter. So I clear my author field and hit search again, but the author field is repopulated. In order to clear the author or tag field, you actually have to clear the text and then click the search button again. This isn't a deal-breaker for roll-out this week, but it's a bit confusing. Is there some way can can have the author and tag filters reset when you hit the main search button?

[Paul Everitt (paul-agendaless)]

Yes, it would be reasonable for Chris to clear those when doing a search. I'm re-assigning to Nat so he can talk with Robert and make sure that is the solution you want.

Get a final writeup in here, re-assign to Chris, and he can then work on this when he returns.

[Robert Marianski (rmarianski)]

I just wanted to weigh in on this to try and make sure we're on the same page.

Any time a user interacts with a knob, that should get reflected in the next search. For example, if I modify the author, tag, search term, and then click on a facet filter, that search should now use the new facet, new author, new tag, and new search term. Setting the tag/author fields to blank clears the filter for that field.

[JimPGlenn (jpglenn09)]

fixed

[Nat Katin-Borland (nborland)]

This still seems to be broken. Specifically, once you filter an advanced by tag or author you can't clear the author or tag field. What we had agreed upon is that once you initiate a new search on the advanced search page, it should also clear the author and tag fields (if they have been used).

[Paul Everitt (paul-agendaless)]

Carlos, if this is easy to fix, let's do it next week.

[Carlos de la Guardia (cguardia)]

Pushed and deployed to branch cguardia-advanced-search-filters.

[JimPGlenn (jpglenn09)]

looks good

[Nat Katin-Borland (nborland)]

I still think we're missing this one! Jim what did you test? If you are on the advanced search results page and then attempt to filter the pile of results further by searching for a specific author or tag, there is no way to clear your author or tag search, except by leaving the search screen altogether. My proposal was that if you enter a new search on the advanced search results screen, your author or tag search selection should also clear. Entering a new search "resets" everything on the page. Perhaps I'm missing something...

[Paul Everitt (paul-agendaless)]

Moving this back to "in progress" and slating for the future.

[Nat Katin-Borland (nborland)]

Still a not what we discussed, but a little better. Now you can clear your sub-search (author or tag), but a new search dies not reset all the sub-search fields.

[Carlos de la Guardia (cguardia)]

I might have gotten this wrong. The description says to clear author and tag fields on new searches, but one of the comments above does mention the other fields. Will add those then.

[Carlos de la Guardia (cguardia)]

Pushed fix to branch cguardia-advanced-filters.

[JimPGlenn (jpglenn09)]

works on dev. I don't believe this was merged earlier in the week, so I don't see the same result on staging yet.

[JimPGlenn (jpglenn09)]

I tested on production and on staging and I don't think it has made the merge yet?

[Paul Everitt (paul-agendaless)]

Right, I don't think this one was merged.

--Paul

On Sep 3, 2012, at 2:32 PM, JimPGlenn <email address hidden> wrote:

> I tested on production and on staging and I don't think it has made the
> merge yet?
>
>
> ** Tags removed: r3.91 tested
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/784257
>
> Title:
> Advanced Search Filter Interaction
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Specifically, it can be confusing on how to reset filters for author
> or tag. If I have a large pile of results, then I filter that pile by
> an author. Good. Now I decide to search on a new term, but realize
> that even when I search for that new term I'm still tied to my
> previous author filter. So I clear my author field and hit search
> again, but the author field is repopulated. In order to clear the
> author or tag field, you actually have to clear the text and then
> click the search button again. This isn't a deal-breaker for roll-out
> this week, but it's a bit confusing. Is there some way can can have
> the author and tag filters reset when you hit the main search button?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/784257/+subscriptions

[JimPGlenn (jpglenn09)]

carlos, put in a merge request

[Carlos de la Guardia (cguardia)]

It's already a pull request.

[Paul Everitt (paul-agendaless)]

Nat found a bug, I'll work on recreating and explaining.

[Paul Everitt (paul-agendaless)]

I explained to Nat about prefix matching on filenames. Thus, we're back in business, this can go in today's release.

[Nat Katin-Borland (nborland)]

Yeah, sorry about that. I'll think we've finally got this one.

[Chris Rossi (chris-archimedeanco)]

Note that I had to manually fix a merge conflict in the search results template in order to merge this fix. I'm not 100% sure I got it right, so it definitely warrants further testing on staging.

[JimPGlenn (jpglenn09)]

fixed