OSI Logo Bug on some People Directory Pages

[JimPGlenn]

I just had a user point this out. On some OSI People Directory pages,
the grey background extends down, making the OSI logo display strangely
with a white background. The bug is not consistent however - some pages
have it, some don't, so it looks like different reports have different
forms. We have to make sure the OSI logo displays correctly on all the
People Directory reports. I have attached a screenshot for an example
of what I'm talking about.

Thanks,
Nat

[JimPGlenn (jpglenn09)]

attachment is a screen capture from Nat.

[JimPGlenn (jpglenn09)]

reported via rt http://rt01.sixfeetup.com/Ticket/Display.html?id=80542

[Paul Everitt (paul-agendaless)]

Chrissy, think you have enough context on this to work on it?

[Chrissy Wainwright (chrissy)]

yeah, I can see the issue. #footer is inside of #main, when it should be at the same level.

Also noticed there are multiple footer ids: div#footer is wrapped in a div#footer - I will probably also fix that while I'm in there.

[Chrissy Wainwright (chrissy)]

the problem is coming from the HTML in gsa_to_karl.xsl. It seems there is a </div> missing. I am unable to test this on my local instance since changes I make in this file do not display.

the two suggestions I have are:
 * move the <div class='tel'> from line 129 down a couple lines so it is in <xsl:if test="$fax/text()">
 * change <div style='clear: both'/> (line 143) to <div style='clear: both'></div> (actually use the </div> tag)

[Paul Everitt (paul-agendaless)]

Chrissy, I'm generally the one that hacks on the XSL. Want me to take this issue back?

[Paul Everitt (paul-agendaless)]

I'm going to move this one a little bit into the future, to give us time to focus on the new stuff.

[Chrissy Wainwright (chrissy)]

go for it

[Paul Everitt (paul-agendaless)]

Hand this over to Chris to make an evolve script which resets the timestamp for the next production update, to force the XSLT to get run again.

[Chris Rossi (chris-archimedeanco)]

Checked the Brussels page locally after running evolve and then gsa_sync, and it looks ok to me.

[JimPGlenn (jpglenn09)]

fixed