Is Private on add/edit for other community content

Bug #362557 reported by Paul Everitt
2
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
High
Shane Hathaway

Bug Description

Tres and Paul got Is Private working for folders (#361117).

We need it working for add/edit on files, wiki, blog entries, blog comments, and calendar events. We'll do this as part of M11.

Some wrinkles:

1) We can't have the sharing field appear in the validators if we are in the intranet side, since there is no such thing as isprivate over there. Thus, you'll see in karl.content.views.files.add_folder_view that, just after we make the form instance, we do a line where we call a helper to add the field if needed.

2) There's a place it gets added inside the "succeeded validation" then another place to add outside.

3) Unit tests will need a little love.

Tags: security
Changed in karl3:
importance: Undecided → Medium
milestone: none → m11
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

*This* one is for Shane.

Changed in karl3:
assignee: nobody → shane-hathawaymix
importance: Medium → High
Changed in karl3:
status: New → In Progress
Revision history for this message
Shane Hathaway (shane-hathawaymix) wrote :

This is mostly finished, except:

- There is not yet an "is private" field for adding a comment.

- There are not enough tests for calendar events.

Revision history for this message
Shane Hathaway (shane-hathawaymix) wrote :

Committed in several revisions, the last of which is 2326.

Changed in karl3:
status: In Progress → Fix Committed
Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.