Implement basics of blogcomment-alert

Bug #337257 reported by Paul Everitt on 2009-03-03
2
Affects Status Importance Assigned to Milestone
KARL3
Medium
Chris Rossi
Changed in karl3:
assignee: nobody → chris-archimedeanco
importance: Undecided → Medium
milestone: none → m4

Am likely to refactor the blogentry-alert code to introduce some sort of shared "Alert" concept. Will probably go ahead and make them model objects in anticipation of having to store them for the digest version.

Changed in karl3:
status: New → In Progress

Just noticed the requirement that this should work with comments sent via email. Currently an alert email is generated by adapting IAlert and IRequest. The request is needed to compute the hrefs for links in the email. This will also be an issue when we implement alert digests, actually, assuming those are kicked off by a cron job and console script.

Issue being, we need a way to figure out the url of the site even outside of the context of an http request. Is there a way to do this currently that I'm not aware of or is there a need to invent something. Would a "system_root_url" setting be a reasonable choice for dealing with this?

It would eliminate the dependency on a request object when generating alerts which can only make that code cleaner.

Let me know what you think.

Paul Everitt (paul-agendaless) wrote :

Chris, is this one wrapped up? If you are purely doing refactoring, then mark this as done and we can evaluate it, and make a new task that covers refactoring.

I see your point. Perhaps use a utility (that you can call with
arguments from your code where you have all the data) rather than an
adapter?

--Paul

On Mar 6, 2009, at 10:28 AM, Chris Rossi wrote:

> Just noticed the requirement that this should work with comments sent
> via email. Currently an alert email is generated by adapting IAlert
> and
> IRequest. The request is needed to compute the hrefs for links in the
> email. This will also be an issue when we implement alert digests,
> actually, assuming those are kicked off by a cron job and console
> script.
>
> Issue being, we need a way to figure out the url of the site even
> outside of the context of an http request. Is there a way to do this
> currently that I'm not aware of or is there a need to invent
> something.
> Would a "system_root_url" setting be a reasonable choice for dealing
> with this?
>
> It would eliminate the dependency on a request object when generating
> alerts which can only make that code cleaner.
>
> Let me know what you think.
>
> --
> Implement basics of blogcomment-alert
> https://bugs.launchpad.net/bugs/337257
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Porting KARL to a new architecture: In Progress
>
> Bug description:
>
> Similar to https://bugs.launchpad.net/karl3/+bug/336863
>
> Follow writeup at: http://carlos.agendaless.com/dko/policies/blog.html#blog-comment-alert

I can wrap it up without the email comments right away. If we want the
incoming emails to generate alerts, too, we need to refactor.

Chris

On Fri, Mar 6, 2009 at 10:40 AM, Paul Everitt <email address hidden> wrote:

> Chris, is this one wrapped up? If you are purely doing refactoring,
> then mark this as done and we can evaluate it, and make a new task that
> covers refactoring.
>
> --
> Implement basics of blogcomment-alert
> https://bugs.launchpad.net/bugs/337257
> You received this bug notification because you are a bug assignee.
>
> Status in Porting KARL to a new architecture: In Progress
>
> Bug description:
>
> Similar to https://bugs.launchpad.net/karl3/+bug/336863
>
> Follow writeup at:
> http://carlos.agendaless.com/dko/policies/blog.html#blog-comment-alert
>

Paul Everitt (paul-agendaless) wrote :

Yeh, we'll need the latter, but we can hold off on that until after M4.

--Paul

On Mar 6, 2009, at 10:58 AM, Chris Rossi wrote:

> I can wrap it up without the email comments right away. If we want
> the
> incoming emails to generate alerts, too, we need to refactor.
>
> Chris
>
>
> On Fri, Mar 6, 2009 at 10:40 AM, Paul Everitt <email address hidden>
> wrote:
>
>> Chris, is this one wrapped up? If you are purely doing refactoring,
>> then mark this as done and we can evaluate it, and make a new task
>> that
>> covers refactoring.
>>
>> --
>> Implement basics of blogcomment-alert
>> https://bugs.launchpad.net/bugs/337257
>> You received this bug notification because you are a bug assignee.
>>
>> Status in Porting KARL to a new architecture: In Progress
>>
>> Bug description:
>>
>> Similar to https://bugs.launchpad.net/karl3/+bug/336863
>>
>> Follow writeup at:
>> http://carlos.agendaless.com/dko/policies/blog.html#blog-comment-
>> alert
>>
>
> --
> Implement basics of blogcomment-alert
> https://bugs.launchpad.net/bugs/337257
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Porting KARL to a new architecture: In Progress
>
> Bug description:
>
> Similar to https://bugs.launchpad.net/karl3/+bug/336863
>
> Follow writeup at: http://carlos.agendaless.com/dko/policies/blog.html#blog-comment-alert

Comments submitted via email are not currently handled.

Changed in karl3:
status: In Progress → Fix Committed
Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers