add trigger validation to api module

Bug #1736657 reported by jiaopengju
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Karbor
Fix Released
Undecided
jiaopengju

Bug Description

Currently, we use 'cast' instead of 'call' to send request from api to operationengine. With 'cast', it will not give a return value to api even the trigger format is not correct. In this situation, when the trigger format is invalid, users also can create triggers successfully, it is not right. So we should add trigger validation to api module.

jiaopengju (pj-jiao)
summary: - add trigger validation to api model
+ add trigger validation to api module
Changed in karbor:
assignee: nobody → jiaopengju (pj-jiao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to karbor (master)

Fix proposed to branch: master
Review: https://review.openstack.org/537794

Changed in karbor:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to karbor (master)

Reviewed: https://review.openstack.org/537794
Committed: https://git.openstack.org/cgit/openstack/karbor/commit/?id=bba93226e606ef92fee56a5a67b9046d7b692d08
Submitter: Zuul
Branch: master

commit bba93226e606ef92fee56a5a67b9046d7b692d08
Author: jiaopengju <email address hidden>
Date: Thu Jan 25 15:32:47 2018 +0800

    Add trigger verification in API

    Currently, we use 'cast' instead of 'call' to send request
    from api to operationengine when creating a new trigger.
    With 'cast', it will not give a return value to api even the
    trigger is invalid, so users can create triggers successfully
    with using invalid triggers.

    This patch add trigger verification in API side. Before send
    create request to operationengine, API send a verify request
    to operationengine first, which type is 'call', to make sure
    the trigger will be created is valid.

    Change-Id: Iea734e1b4a63f6e35afe32cbbb2b60f79d6db085
    Closes-Bug: #1736657

Changed in karbor:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor 1.0.0

This issue was fixed in the openstack/karbor 1.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor 1.1.0

This issue was fixed in the openstack/karbor 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.