Short-circuit notifications when not enabled
Bug #1719786 reported by
chenying
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Karbor |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In Mitaka oslo messaging introduced the transport_url specific for
notifications under the oslo_messaging_
projects still use the default transport_url defined in the DEFAULT
section. Use messaging notifications transport instead of default.
This patch proposes short-circuiting notification methods as much as
possible to optimize code execution when Karbor has no notification
transport mechanism configured.
The NOTIFIER only be inited only if notifications are actually enabled.
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/507757 /git.openstack. org/cgit/ openstack/ karbor/ commit/ ?id=2f529a62bf6 4555e004364d027 be0bd5a1781181
Committed: https:/
Submitter: Jenkins
Branch: master
commit 2f529a62bf64555 e004364d027be0b d5a1781181
Author: chenying <email address hidden>
Date: Wed Sep 27 14:54:28 2017 +0800
Short-circuit notifications when not enabled
In Mitaka oslo messaging introduced the transport_url specific for notifications section, but some
notifications under the oslo_messaging_
projects still use the default transport_url defined in the DEFAULT
section. Use messaging notifications transport instead of default.
This patch proposes short-circuiting notification methods as much as
possible to optimize code execution when Karbor has no notification
transport mechanism configured.
The NOTIFIER only be inited only if notifications are actually
enabled.
Change-Id: Id9419ddd801bf9 d8ac13c4a73a91e 39fd763cb2b
Closes-Bug: #1719786