Type of 'operation_id' field of 'CheckpointRecord' should be UUID

Bug #1716224 reported by Eric Xie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Karbor
Fix Released
Undecided
Eric Xie

Bug Description

https://github.com/openstack/karbor/blob/master/karbor/objects/checkpoint_record.py#L38
'operation_id': fields.StringField(nullable=True),

I think the type of this field should be fields.UUIDField().

Eric Xie (eric-xie)
Changed in karbor:
assignee: nobody → Eric Xie (eric-xie)
status: New → In Progress
Revision history for this message
Eric Xie (eric-xie) wrote :

Also type of 'project_id' in different objects of karbor is not consistent.

In ScheduledOperation, it is fields.StringField().
But in Plan, it is fields.UUIDField().

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to karbor (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502870

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to karbor (master)

Reviewed: https://review.openstack.org/502870
Committed: https://git.openstack.org/cgit/openstack/karbor/commit/?id=ae495b757e9814363b83bde4722750703e1ecb9b
Submitter: Jenkins
Branch: master

commit ae495b757e9814363b83bde4722750703e1ecb9b
Author: ericxiett <eric_xiett@163.com>
Date: Tue Sep 12 08:17:29 2017 +0800

    Fix improper type for some like UUID fileds in objects.

    Like 'operation_id' of 'CheckpointRecord', it should be UUID.

    Change-Id: Ic2448837bea45c94741eadbeeac33620cb73e125
    Closes-Bug: #1716224

Changed in karbor:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor 0.6.0

This issue was fixed in the openstack/karbor 0.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor 1.0.0

This issue was fixed in the openstack/karbor 1.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor 1.1.0

This issue was fixed in the openstack/karbor 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.