Basic Protection Service

Bug #1524691 reported by yinwei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Karbor
Fix Released
Undecided
wangliuan

Bug Description

Implement the basic protection service framework.
Basically, this service will execute a protection operation and persist results with transactions in bank.
It will also collect operation execution result and update operation status asynchronously as well.
As a basic framework, we don't consider error case in this patch, eg. protection service crash and redo operation handling. We will handle error cases in following patches.

yinwei (yinweiishere-n)
Changed in smaug:
assignee: nobody → yinwei (yinweiishere-n)
Revision history for this message
yinwei (yinweiishere-n) wrote :

upload protection service protect sequence (normal case only)

Revision history for this message
Yingzhe Zeng (zengyingzhe) wrote :

Hi yinwei,
I got some questions for the sequence diagram.
1. Would it be better the create transaction call be invoked by work-flow engine?
2. Why need show plan, can't the plan info be passed by RPC call?
3. Periodic check event is running as a coroutine?

Revision history for this message
yinwei (yinweiishere-n) wrote :

Hi Yingzhe,

reply in line:
1. Would it be better the create transaction call be invoked by work-flow engine?
[wei] Yes, sure. We could put all execution logic inot work-flow engine while only leave rpc handling (serialize/deserialize/error handling) in rpc worker.

2. Why need show plan, can't the plan info be passed by RPC call?
[wei] I do prefer to embed the whole plan into the operation message during RPC call. This sequence is based on current API we have.

3. Periodic check event is running as a coroutine?
[wei] Yes. There should be a eventlet threadpool.

yinwei (yinweiishere-n)
Changed in smaug:
assignee: yinwei (yinweiishere-n) → nobody
Changed in smaug:
assignee: nobody → wangliuan (wangliuan2016)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to smaug (master)

Fix proposed to branch: master
Review: https://review.openstack.org/265760

Changed in smaug:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to smaug (master)

Reviewed: https://review.openstack.org/265760
Committed: https://git.openstack.org/cgit/openstack/smaug/commit/?id=28edb063ec5cb5fdaadde296a37c81f829861f3e
Submitter: Jenkins
Branch: master

commit 28edb063ec5cb5fdaadde296a37c81f829861f3e
Author: wangliuan <wangliuan2016@163.com>
Date: Mon Jan 11 17:05:03 2016 +0800

    Implement the basic protection service framework

    Basically, this service will execute a protection operation and persist
    results with transactions in bank
    It will also collect operation execution result and update operation
    status
    As a basic framework,we just implement the interface and a simple
    protection example in this patch

    Change-Id: I1f3970e699b6f2ce2e6a9f2fa13f71789e7c288a
    Closes-Bug: #1524691

Changed in smaug:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.