Activity log for bug #316540

Date Who What changed Old value New value Message
2009-01-12 21:35:48 Jeremy Thurgood bug added bug
2009-01-12 21:36:23 Jeremy Thurgood kali: importance Undecided High
2009-01-12 21:36:23 Jeremy Thurgood kali: statusexplanation
2009-01-12 21:49:00 Jeremy Thurgood description It looks like we assume we'll get a Nick object back from getUser(), but in the case of an unregistered nick we don't. We need to either have an appropriate object for unregistered nicks or deal with the Nones appropriately. 2009-01-12 23:32:38+0200 [InspircdServices,client] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/Axiom-0.5.30-py2.4.egg/axiom/store.py", line 1640, in transact result = f(*a, **k) File "/home/jerith/python/kali/branches/nickserv-register/kali/protocol.py", line 159, in handle method(prefix, *params) File "/home/jerith/python/kali/branches/nickserv-register/kali/protocol.py", line 248, in irc_NICK self.services.event('nickchange', oldnick, newnick) File "/home/jerith/python/kali/branches/nickserv-register/kali/controller.py", line 336, in event self.sendEvent(p, event, *params) --- <exception caught here> --- File "/home/jerith/python/kali/branches/nickserv-register/kali/controller.py", line 347, in sendEvent method(*params) File "/home/jerith/python/kali/branches/nickserv-register/kali/nickserv.py", line 191, in event_nickchange self.logout(old) File "/home/jerith/python/kali/branches/nickserv-register/kali/nickserv.py", line 159, in logout self.ctrl.getUser(nick).registered = False exceptions.AttributeError: 'NoneType' object has no attribute 'registered' It looks like we assume we'll get a valid User object back from getUser(), but sometimes we don't: 2009-01-12 23:32:38+0200 [InspircdServices,client] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/Axiom-0.5.30-py2.4.egg/axiom/store.py", line 1640, in transact result = f(*a, **k) File "/home/jerith/python/kali/branches/nickserv-register/kali/protocol.py", line 159, in handle method(prefix, *params) File "/home/jerith/python/kali/branches/nickserv-register/kali/protocol.py", line 248, in irc_NICK self.services.event('nickchange', oldnick, newnick) File "/home/jerith/python/kali/branches/nickserv-register/kali/controller.py", line 336, in event self.sendEvent(p, event, *params) --- <exception caught here> --- File "/home/jerith/python/kali/branches/nickserv-register/kali/controller.py", line 347, in sendEvent method(*params) File "/home/jerith/python/kali/branches/nickserv-register/kali/nickserv.py", line 191, in event_nickchange self.logout(old) File "/home/jerith/python/kali/branches/nickserv-register/kali/nickserv.py", line 159, in logout self.ctrl.getUser(nick).registered = False exceptions.AttributeError: 'NoneType' object has no attribute 'registered'
2009-01-12 21:49:00 Jeremy Thurgood title Bad handling of unregistered nicks in NickServ Bad handling of None Users in NickServ
2009-01-12 21:56:53 Tristan Seligmann title Bad handling of None Users in NickServ Problem handling nickname changes in NickServ
2009-01-12 22:26:03 Jeremy Thurgood kali: status New Confirmed
2009-01-12 22:26:03 Jeremy Thurgood kali: assignee jerith
2009-01-13 20:50:28 Jeremy Thurgood kali: status Confirmed In Progress
2009-01-13 22:31:20 Jeremy Thurgood kali: status In Progress Fix Committed
2009-01-17 14:21:06 Jeremy Thurgood kali: status Fix Committed Fix Released
2009-01-17 14:49:05 Tristan Seligmann kali: milestone 1.0.0