keyboard settings not showing

[zleap]

Just downloaded the latest iso file, and fired up in a virtual machine.

Trying to load up the Keyboard settings from JWM and the Menu, nothing happens, I thought this had actually been resolved, but it seems broken again.

Can someone confirm the issue perhaps.

Paul

[sudodus (nio-wiklund)]

Please describe with more details. Otherwise it is hard to confirm.

Live or installed?

Which 'path' to the menu?

[sudodus (nio-wiklund)]

I tried in an installed system (installed using the current daily iso file)

Apps -- Settings -- JWM settings manager -- Keyboard

and the 'Settings manager' window disappears, but nothing else seems to happen.

If this is your problem, I can confirm it.

[zleap (zleap)]

I am booting the ISO as a live session inside virtual machine manager on Linux mint 17.2

Not sure what is meant by which path to the menu, if you go to jwm settings manager and click on keyboard nothing appears to happen.

Paul

[zleap (zleap)]

Thanks sudodus (nio-wiklund)

Yeah that confirms my bug.

Paul

[Israel Dahl (israeldahl)]

Hey I found the problem.
Apparently it was due to 2 things.
1. the /etc/skel/.jwmrc had a blank key line
<Key key="XF86MonBrightnessDown"></Key>

2. A lot of the code from the keyboard portion is older and had some checks that don't work as well as my newer code checks:
OLD:
//get the text
std::string key=node->GetText();
//check if the string is empty or NULL

NEW:
//if the node has text THEN get it.
if(node->GetText()){ /*awesome code to get the text*/}

This should be fixed in the next release.
Thanks for finding this one! I have updated most of the code as I understand the tinyxml2 libs much better, but I suppose this one slipped through the cracks