vs.c: 2 * bad if test ?

Bug #1348559 reported by dcb on 2014-07-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
jupp
Wishlist
Unassigned

Bug Description

vs.c:18:15: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
vs.c:20:15: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

    if (a >= 'A' || a <= 'Z')
        a += 'a' - 'A';
    if (b >= 'A' || b <= 'Z')
        b += 'a' - 'A';

Suggest swap || for &&

Thorsten Glaser (mirabilos) wrote :

Thanks for spotting. I removed the entire function, it was unused anyway. Please ignore the warning in this case.

Feel free to submit any other low-hanging fruits or severe mistakes, though ;-)

Changed in jupp:
importance: Undecided → Wishlist
status: New → Fix Committed
Thorsten Glaser (mirabilos) wrote :

Fixed in jupp28

Changed in jupp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers