Unexpected keyword argument 'capture_output' while building opt=production

Bug #1805850 reported by Michał Cłapiński
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Michał Cłapiński
OpenContrail
Fix Committed
Undecided
Michał Cłapiński

Bug Description

One change (https://review.opencontrail.org/#/c/47786/) introduced code written for newer Python then the one we have in CI causing errors while building optimized code.

Logs:
05:12:44 [Build] TypeError: __init__() got an unexpected keyword argument 'capture_output':
05:12:44 [Build] File "J:\Jenkins\workspace\WinContrail\test-build-containers-pm\SConstruct", line 14:
05:12:44 [Build] env = rules.SetupBuildEnvironment(conf)
05:12:44 [Build] File "tools/build\rules.py", line 1242:
05:12:44 [Build] env = CheckBuildConfiguration(conf)
05:12:44 [Build] File "tools/build\rules.py", line 1024:
05:12:44 [Build] if not VerifyClVersion():
05:12:44 [Build] File "tools/build\rules.py", line 1040:
05:12:44 [Build] process = subprocess.run(['cl.exe'], capture_output=True, encoding='ASCII')
05:12:44 [Build] File "C:\Python36\lib\subprocess.py", line 403:
05:12:44 [Build] with Popen(*popenargs, **kwargs) as process:

Tags: windows
Changed in opencontrail:
assignee: nobody → Michał Cłapiński (michal.clapinski)
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47930
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47930
Committed: http://github.com/Juniper/contrail-build/commit/0dc826ac9e01ad71d7568ad878bec3b87b99d175
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0dc826ac9e01ad71d7568ad878bec3b87b99d175
Author: Michal Clapinski <email address hidden>
Date: Thu Nov 29 15:22:59 2018 +0100

Downgrade Python code for checking compiler version

That code wasn't working in Python version we have in CI.
This change downgrades the code for older Python versions.

Change-Id: I74328b61aec8fba2fd632a715ddde49ae254f24e
Closes-Bug: #1805850

Changed in opencontrail:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.