vrouter_interface_route playbook bails out when onprem gw and controller are in diff subnet

[Senthilnathan Murugappan]

vrouter_interface_route playbook bails out when onprem gw and controller are in different subnets.

local_lan of the onprem gateway is different from the controller subnet so the below task gets skipped

- name: Find controller lan
  set_fact:
    controller_lan: "{{ hostvars[item].local_lan }}"
  with_items: "{{ groups['gateways'] }}"
  when: "controller | ipaddr(hostvars[item].local_lan)"
  delegate_to: localhost
  run_once: True

TASK [software/facts : Find controller lan] **************************************************************************************************************************************************************
skipping: [192.168.2.1] => (item=172.16.23.5)
skipping: [192.168.2.1] => (item=192.168.2.1)

TASK [software/facts : Show host controller lan] *********************************************************************************************************************************************************
fatal: [192.168.2.1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'controller_lan' is undefined\n\nThe error appears to have been in '/root/multicloud/ansible/contrail/playbooks/roles/software/facts/tasks/main.yml': line 56, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Show host controller lan\n ^ here\n\nexception type: <class 'ansible.errors.AnsibleUndefinedVariable'>\nexception: 'controller_lan' is undefined"}
        to retry, use: --limit @/root/multicloud/ansible/contrail/playbooks/vrouter_interface_route.retry

OnPrem gateway is on 192.168.2.0/24 and controller is on 192.168.1.0/24
and this is what i had set for private_subnet under the onprem gw in topology.yml
      private_subnet:
       - 192.168.2.0/24
       - 192.168.1.0/24

[Paweł Kopka (pkopka)]

We are finding which gw are connected to controlle using subnet(primary) and private ip. We are checking if controller are in gatewey subnet(primary). I will check if we can check every subnet.

[Paweł Kopka (pkopka)]

Fix is ready https://github.com/Juniper/contrail-multi-cloud/pull/191

[Senthilnathan Murugappan (msenthil)]

Fix is not yet merged so moving to the appropriate state for tracking purpose. Will move it to Fix committed once merged.