Coverity issues in vrouter dpdk

[Andrei Bunghez]

opencontrail master

Hi,

Coverity reports several issues in vrouter/dpdk. I would like to use this issue to track them as I address them. To begin with:

vr_dpdk_netlink.c: 289 - descriptor will be leaked in (the unlikely) case it is 0. (63834)

vr_dpdk_table_mem.c: 115 - sys_fp is leaked if a new iteration takes the same path. (63770)

vr_dpdk_interface.c: 562 - strncpy with buffer size as argument might lead to non-"null terminated" string (63951).

vr_uvhost.c: In vr_uvhost_start, s is a socket descriptor which can be >= 0 if socket returns success. The "if (s)" on error case (where this comparison is true as s might be -1) leads to unlinking an uninitialized sun.sun_path. (64029, 63838)

vr_dpdk_virtio.c: vring_idx check in vr_dpdk_set_ring_num_desc (63924)

[Andrei Bunghez (abunghez)]

Also:
vr_dpdk_virtio.c: vring_idx check in vr_dpdk_set_ring_num_desc (63924)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40953
Submitter: Andrei Bunghez (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/42687
Submitter: Andrei Bunghez (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40953
Submitter: Andrei Bunghez (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/42755
Submitter: Andrei Bunghez (<email address hidden>)

[Sivakumar Ganapathy (hotlava51)]

Not critical for 5.0.2 as it is just coverity warnings.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47311
Submitter: Kiran (<email address hidden>)