[R4.1-36]:SLO- Session getting logged locally on compute without any SLO created
- Series trunk
- Bug #1729812
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Juniper Openstack | Status tracked in Trunk | |||||
R4.0 |
Won't Fix
|
High
|
Arvind | |||
R4.1 |
Fix Committed
|
High
|
Arvind | |||
R5.0 |
Fix Committed
|
High
|
Arvind | |||
Trunk |
Fix Committed
|
High
|
Arvind |
Bug Description
When sampling is enabled and there are not any SLO created then also session is getting logged locally on compute.
As per https:/
But all the sampled sessions are getting logged locally.
Anish Mehta (amehta00) wrote : | #1 |
alok kumar (kalok) wrote : | #2 |
The bug is still valid as per the requirement mentioned in https:/
section 3:
The destination for SessionSample messages is just analytics. The destinations supported for SessionLog are Analytics, syslog and local file. The destinations are mutually exclusive. Flags will be created to specify the different destinations. When same session is SLO configured and also selected by sampling algorithm, the corresponding session record can go to both analytics and syslog/local file.
shouldn't we update the documentation accordingly if you are changing the expected behaviour now?
alok kumar (kalok) wrote : | #3 |
As per discussion with Anish, documentation need to be update as per current behavior.
Ashok as discussed earlier, please update that.
Ashok Singh (ashoksr) wrote : | #4 |
Arvind, as discussed over email, please update the spec and implementation with the expected behavior
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #5 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #6 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #8 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #10 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #11 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #14 |
Reviewed: https:/
Committed: http://
Submitter: Rudra Rugge (<email address hidden>)
Branch: master
commit a55c19bfef02187
Author: arvindvis <email address hidden>
Date: Thu Feb 1 17:26:05 2018 -0800
A new flag is introduced by the agent to permit syslogging
of sessions that only obey SLO. Syslog is enabled if
either of use_syslog or use_session_syslog is enabled.
use_syslog to send sampled sessions to syslog;
use_session_syslog to send SLO sessions to syslog.
If use_syslog is enabled we dont send the session to
collector.
If only use_session_syslog is enabled, we send SLO
sessions to syslog but sampled sessions will continue
to go to collector.
Partial-Bug: 1729812
Change-Id: I02d6f3c3f369eb
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #15 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #20 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #22 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #23 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #24 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #25 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #26 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #28 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #29 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #32 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #33 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #34 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #35 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #37 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #38 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #39 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #40 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #41 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #43 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
tags: | added: operational |
tags: | added: provisioning |
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #44 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #45 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #47 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #48 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #49 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #50 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #51 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0 | #52 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #53 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #54 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #55 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #56 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #57 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #59 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #60 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit fe034f12bb34c78
Author: arvindvis <email address hidden>
Date: Wed May 2 16:22:45 2018 -0700
Logging of sessions
This fix lets the session logs go to any or all of collector/
file/syslog. To accommodate this, 2 new logger object is
created for handling only SLO/Sample session destinations. The
destinations to this logger are provided by the agent. A snippet
of the generated_file is added to the bug. Here is a snippet of
the generated sandesh file:
static void LogUnrolled(
static void adjust_
static void Send(std::string category, SandeshLevel::type level, const std::vector<
if (HandleTest(level, category)) {
return;
}
if (IsSendingAllMe
UpdateTxMsgFail
if (IsLoggingDropp
Log(category, level, session_data);
}
return;
}
if (is_send_
LogUnrolled(
}
if (level >= SendingLevel()) {
UpdateTxMsgFail
if (IsLoggingDropp
std::string drop_reason = "SANDESH: Queue Drop: ";
DropLog(
}
return;
}
SessionEndpoint
if (!is_send_
return;
}
if (is_send_
adjust_
snh->set_
snh->set_
snh->Dispatch();
}
Partial-Bug: 1729812
Change-Id: Ie6024b95aa5bec
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #61 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #62 |
Reviewed: https:/
Committed: http://
Submitter: Mithun Mistry (<email address hidden>)
Branch: master
commit 2e5cbfe2dc53b8b
Author: arvindvis <email address hidden>
Date: Wed May 2 17:16:10 2018 -0700
Session logging
This fix adds the ability to provide any/all of session destinations
for SLO and sampled sessions. New flags SESSION.
and SESSION.
DEFAULT.usesyslog and DEFAULT.log_flow flags.By default, the destination
list is collector. We have config variables to control SLO and sampling
rate if we are inundated.
Depends-On: Ie6024b95aa5bec
Partial-Bug: 1729812
Change-Id: I6aca6507aeb196
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0 | #63 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #64 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #65 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #66 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #67 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0 | #68 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #69 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #70 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #71 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #72 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 1ab92841bceeb91
Author: arvindvis <email address hidden>
Date: Thu May 10 14:49:48 2018 -0700
Handle the new variable to specify sample msg destination
Change-Id: I7e958bc8de045e
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : | #73 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 73189da16f413c3
Author: arvindvis <email address hidden>
Date: Thu May 10 14:52:46 2018 -0700
Agent role has additional options to specify session msg destination
Two new options added to agent viz., SLO_DESTINATION and
SAMPLE_DESTINATION. Their default value will be collector.
To change it specify a space separated list of values.The destination
supported are syslog, file and collector.
Change-Id: I8953271f84ec25
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : | #74 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0
commit 349bef72c89942d
Author: arvindvis <email address hidden>
Date: Thu May 10 14:49:48 2018 -0700
Handle the new variable to specify sample msg destination
Change-Id: I7e958bc8de045e
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : | #75 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit e185008ce2533cc
Author: arvindvis <email address hidden>
Date: Wed Jun 13 12:37:11 2018 -0700
Uncomment the adjust_
This was commented out from sandesh repo to make
it compile and prevent circular dependency.
Partial-Bug: 1729812
Change-Id: I96bde4092a7509
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #76 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #77 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #78 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit f019bd9636ef5d7
Author: arvindvis <email address hidden>
Date: Fri Jun 22 10:39:57 2018 -0700
Reordering linking of libraries in agent
Sandesh makes use of boost headers in a new change and agent links
to sandesh library.
In redhat, the boost library must be linked to first before linking
to sandesh library.
Partial-Bug: 1729812
Change-Id: I763658b0775acc
OpenContrail Admin (ci-admin-f) wrote : | #79 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit f4e90360209ff9b
Author: arvindvis <email address hidden>
Date: Wed Jun 13 12:08:21 2018 -0700
Logging of sessions
This fix lets the session logs go to any or all of collector/
file/syslog. To accommodate this, 2 new logger object is
created for handling only SLO/Sample session destinations. The
destinations to this logger are provided by the agent. A snippet
of the generated_file is added to the bug. Here is a snippet of
the generated sandesh file:
static void LogUnrolled(
static void adjust_
static void Send(std::string category, SandeshLevel::type level, const std::vector<
if (HandleTest(level, category)) {
return;
}
if (IsSendingAllMe
UpdateTxMsgFail
if (IsLoggingDropp
Log(category, level, session_data);
}
return;
}
if (is_send_
LogUnrolled(
}
if (level >= SendingLevel()) {
UpdateTxMsgFail
if (IsLoggingDropp
std::string drop_reason = "SANDESH: Queue Drop: ";
DropLog(
}
return;
}
SessionEndpoint
if (!is_send_
return;
}
if (is_send_
adjust_
snh->set_
snh->set_
snh->Dispatch();
}
Depends-On: I763658b0775acc
Change-Id: I486656dc9d0866
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : | #80 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit d16197b268c99cb
Author: arvindvis <email address hidden>
Date: Wed Jun 13 12:29:57 2018 -0700
Session logging
This fix adds the ability to provide any/all of session destinations
for SLO and sampled sessions. New flags SESSION.
and SESSION.
DEFAULT.usesyslog and DEFAULT.log_flow flags.By default, the destination
list is collector. We have config variables to control SLO and sampling
rate if we are inundated.
Depends-On: I486656dc9d0866
Partial-Bug: 1729812
Change-Id: I79f7c8879d3c16
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #81 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #82 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0
commit faf1e297cf5b114
Author: arvindvis <email address hidden>
Date: Wed May 2 16:22:45 2018 -0700
Logging of sessions
This fix lets the session logs go to any or all of collector/
file/syslog. To accommodate this, 2 new logger object is
created for handling only SLO/Sample session destinations. The
destinations to this logger are provided by the agent. A snippet
of the generated_file is added to the bug. Here is a snippet of
the generated sandesh file:
static void LogUnrolled(
static void adjust_
static void Send(std::string category, SandeshLevel::type level, const std::vector<
if (HandleTest(level, category)) {
return;
}
if (IsSendingAllMe
UpdateTxMsgFail
if (IsLoggingDropp
Log(category, level, session_data);
}
return;
}
if (is_send_
LogUnrolled(
}
if (level >= SendingLevel()) {
UpdateTxMsgFail
if (IsLoggingDropp
std::string drop_reason = "SANDESH: Queue Drop: ";
DropLog(
}
return;
}
SessionEndpoint
if (!is_send_
return;
}
if (is_send_
adjust_
snh->set_
snh->set_
snh->Dispatch();
}
Partial-Bug: 1729812
Change-Id: Ie6024b95aa5bec
(cherry picked from commit fe034f12bb34c78
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #83 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #85 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0
commit 562faa77a6e800b
Author: arvindvis <email address hidden>
Date: Wed May 2 17:16:10 2018 -0700
Session logging
This fix adds the ability to provide any/all of session destinations
for SLO and sampled sessions. New flags SESSION.
and SESSION.
DEFAULT.usesyslog and DEFAULT.log_flow flags.By default, the destination
list is collector. We have config variables to control SLO and sampling
rate if we are inundated.
Depends-On: Ie6024b95aa5bec
Partial-Bug: 1729812
Change-Id: I6aca6507aeb196
(cherry picked from commit 2e5cbfe2dc53b8b
OpenContrail Admin (ci-admin-f) wrote : | #86 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0
commit b3b44c609a81d0b
Author: arvindvis <email address hidden>
Date: Thu May 10 14:52:46 2018 -0700
Agent role has additional options to specify session msg destination
Two new options added to agent viz., SLO_DESTINATION and
SAMPLE_DESTINATION. Their default value will be collector.
To change it specify a space separated list of values.The destination
supported are syslog, file and collector.
Change-Id: I8953271f84ec25
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #87 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0 | #88 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #89 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0
commit 4a69cf368a8773f
Author: arvindvis <email address hidden>
Date: Wed Jun 13 12:37:11 2018 -0700
Uncomment the adjust_
This was commented out from sandesh repo to make
it compile and prevent circular dependency.
Partial-Bug: 1729812
Change-Id: I96bde4092a7509
(cherry picked from commit e185008ce2533cc
OpenContrail Admin (ci-admin-f) wrote : | #90 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit 73a6430131884eb
Author: arvindvis <email address hidden>
Date: Thu May 24 15:11:08 2018 -0700
Added two new params slo_destination and sample_destination to agent
Session destinations params are added to agent.conf under the
section SESSION. The default valuei will be collector.
Partial-Bug: 1729812
Change-Id: I7838eeadd1ccae
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #91 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #92 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit 3309059fc63463e
Author: arvindvis <email address hidden>
Date: Tue Jul 3 22:04:46 2018 -0700
Uncomment the adjust_
This was commented out from sandesh repo to make
it compile and prevent circular dependency.
Partial-Bug: 1729812
Change-Id: I59bae0a7c48306
OpenContrail Admin (ci-admin-f) wrote : | #93 |
Reviewed: https:/
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 69e172ab30794b1
Author: arvindvis <email address hidden>
Date: Thu May 24 15:15:30 2018 -0700
SLO logging params added
Destination for SLO and sampled sessions can be created
using slo_destination
with space separated values. The values can be one of
collector, syslog file or empty.
Change-Id: Ib68ab5e1674217
Partial-Bug: 1729812
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1 | #94 |
Review in progress for https:/
Submitter: Arvind (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #95 |
Reviewed: https:/
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R4.1
commit 166fdc2ccc0efbb
Author: arvindvis <email address hidden>
Date: Thu May 24 15:15:30 2018 -0700
SLO logging params added
Destination for SLO and sampled sessions can be created
using slo_destination
with space separated values. The values can be one of
collector, syslog file or empty.
Change-Id: Ib68ab5e1674217
Partial-Bug: 1729812
The SLO feature is intended to report sessions that would otherwise not have been reported based on the sampling mechanism alone.
There is a way to tell which sessions were reported as part of only sampling, only SLO or both, as described below. Beyond that, we do not intend to suppress the reporting of sessions based on SLO or sampling.
>>1) For sessions that are only sampled, logged bytes and packets are not even set in >>sandesh
>>2) For sessions that only logged, sampled bytes and packages are not even set in >>sandesh
>>3) For sessions that are both sampled and logged , sampled bytes and packets are >>both set in sandesh.