sanitize nodemgr logs

Bug #1696577 reported by Sundaresan Rajangam
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R4.0
Fix Committed
Medium
mkheni
Trunk
Fix Committed
Medium
mkheni

Bug Description

- Messages logged through sys.stderr.write has no timestamp and should be replaced with sandesh logger with appropriate log level
- Some log messages like "wokeup and found a line" should be converted to stats/counters and can be made available through introspect

Tags: analytics
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/32986
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/32986
Committed: http://github.com/Juniper/contrail-controller/commit/ca70c307aeb29a17d991c7af003d28c4a61b6e1b
Submitter: Zuul (<email address hidden>)
Branch: master

commit ca70c307aeb29a17d991c7af003d28c4a61b6e1b
Author: mkheni <email address hidden>
Date: Mon Jun 19 16:39:18 2017 -0700

Sanitize nodemgr logs

1) Messages logged through sys.stderr.write has no timestamp, replaced with sandesh_logger
2) converted wokeup_and_found_a_line and wokeup_just_like_that to counters and made available through introspect
supervisor_events and supervisor_events_error respectively.

Change-Id: Idb73dc7b2e67126dce6c71ac69ab58efed0d9ac0
closes-bug: #1696577

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/33488
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/33488
Committed: http://github.com/Juniper/contrail-controller/commit/5d407afa037a633f32ad08889238f75d99e0f47a
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 5d407afa037a633f32ad08889238f75d99e0f47a
Author: mkheni <email address hidden>
Date: Mon Jun 19 16:39:18 2017 -0700

Sanitize nodemgr logs

1) Messages logged through sys.stderr.write has no timestamp, replaced with sandesh_logger
2) converted wokeup_and_found_a_line and wokeup_just_like_that to counters and made available through introspect
supervisor_events and supervisor_events_error respectively.

Change-Id: Idb73dc7b2e67126dce6c71ac69ab58efed0d9ac0
closes-bug: #1696577

Revision history for this message
Sriram Bhamidipati (bsriram) wrote :

Can this be backported to 3.x as well?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.