Clean up xmpp logs

[Ananth Suryanarayana]

XMPP logs must also use ObjectVRouter as key to logs. There should also be traces associated with most of the logs..

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30812
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30812
Committed: http://github.com/Juniper/contrail-controller/commit/8bd7319a53a755044a9265dd1fa4f93c5c5495ce
Submitter: Zuul (<email address hidden>)
Branch: master

commit 8bd7319a53a755044a9265dd1fa4f93c5c5495ce
Author: Ananth Suryanarayana <email address hidden>
Date: Wed Apr 26 11:51:06 2017 -0700

Cleanup XMPP Logs

o Add ObjectVRouter as key to the logs and fill it in accordingly
o Add Direction (SEND/RECV) similar to how BGP Peer messages are logged
o Add traces along with xmpp logs
o Correct Direction comments in bgp_log.sandesh file
o This work is not complete and more cleanup is still required

Change-Id: I0a9dcacc0cc8c93a2191aeb5dbcf56cbc4991973
Partial-Bug: 1686817

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31245
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31245
Committed: http://github.com/Juniper/contrail-controller/commit/ee8ee4729db38a908d007c45f1e76acad477b575
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit ee8ee4729db38a908d007c45f1e76acad477b575
Author: Ananth Suryanarayana <email address hidden>
Date: Wed Apr 26 11:51:06 2017 -0700

Cleanup XMPP Logs

o Add ObjectVRouter as key to the logs and fill it in accordingly
o Add Direction (SEND/RECV) similar to how BGP Peer messages are logged
o Add traces along with xmpp logs
o Correct Direction comments in bgp_log.sandesh file
o This work is not complete and more cleanup is still required

Change-Id: I0a9dcacc0cc8c93a2191aeb5dbcf56cbc4991973
Partial-Bug: 1686817
(cherry picked from commit 8bd7319a53a755044a9265dd1fa4f93c5c5495ce)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/38755
Submitter: Narendranath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/38755
Committed: http://github.com/Juniper/contrail-controller/commit/33403e84bf06925451504ef49c813e5ed9c6f6c2
Submitter: Zuul (<email address hidden>)
Branch: master

commit 33403e84bf06925451504ef49c813e5ed9c6f6c2
Author: Naren Karjala <email address hidden>
Date: Mon Jan 8 18:37:00 2018 -0800

Creating Trace buffer per Routing Instance.

Tested on baremetal and ran unit tests under bgp/test

Partial-Bug: #1686817
Change-Id: I0ab7714ec3b19b8a8d94d644a2f6fa41a42d6768

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/39176
Submitter: Narendranath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/39176
Committed: http://github.com/Juniper/contrail-controller/commit/2a8f57c59408e7e80cd8dd510dd1a72157a685cd
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2a8f57c59408e7e80cd8dd510dd1a72157a685cd
Author: Naren Karjala <email address hidden>
Date: Tue Jan 23 14:02:22 2018 -0800

Retain Routing Instances Tracebuf upon deletion

- Retain the Routing Instance Trace buff even when the instance is deleted.
- Maintain two map list for proper bookeeping of the Active Routing instance
Tracebuf and one for the deleted Routing instance.
- When new routing instance is created, the trace buf is looked up in Active
map and if not found will look into Dormant map. If not found in these
two lists, a new trace buf is created and added to Active map list.
- Upon deletion of RI, the tracebuf in Active list is moved to Dormant list.
- Ran s/w unit test to verify the tracebuf chnages.

- taken care of the review comments (2/13).
- Added support upto 64K (by default) routinginstance trace buffers retention
Test results are available at:
Server: [nkarjala@ubuntu-build04]$
/build/nkarjala/SB/mainline/build_test_dormant.log
/build/nkarjala/SB/mainline/build_xmpp_dormant_test.log

Note:
The target was built and tested with LOG_DISABLE to false (made hardcoded changes to the src)

export TASK_UTIL_WAIT_TIME=10000 TASK_UTIL_RETRY_COUNT=250000 BGP_STRESS_TEST_SUITE=1 NO_HEAPCHECK=TRUE; scons controller/src/bgp:test |& tee > build_test_dormant.log
unset BUILD_ONLY; export TASK_UTIL_WAIT_TIME=10000 TASK_UTIL_RETRY_COUNT=250000 BGP_STRESS_TEST_SUITE=1 NO_HEAPCHECK=TRUE; scons controller/src/xmpp:test control-node |& tee > build_xmpp_dormant_test.log

Change-Id: I10b80975247d289a66836edacd13a73b2a8e42ea
Partial-Bug: #1686817

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40110
Submitter: Narendranath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40110
Committed: http://github.com/Juniper/contrail-controller/commit/fc0f90f94693cc441f291e7776f3a5e966a40f94
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit fc0f90f94693cc441f291e7776f3a5e966a40f94
Author: Naren Karjala <email address hidden>
Date: Mon Feb 26 12:41:29 2018 -0800

Control the Retention of the deleted RI's Trace buffer using environment variable

If the env variable CONTRAIL_ROUTING_INSTANCE_DORMANT_TRACE_BUFFER_SIZE is not set,
the trace buffers for the deleted routing instance will not be retained and
Trace buffers are available only for active Routing Instances.

Added new unit test for validating the Routing Instance Tracebuffer capacity and
Trace Buffer threshold.

Made cosmetic changes for column size 80.

Change-Id: Ia2a6a62bc37928446ee099f016171765091092e4
Closes-Bug: #1686817