SM:R3.2build24:Provision gets stuck with database_completed with error in openstack_controller.pp

[sundarkh]

SM:R3.2build24:Provision gets stuck with database_completed with error in openstack_controller.pp

1) Install SM R3.2 build 24

2) reimage the target with ubuntu-14-04-05; Reimage is successful

3) Issue provision ; observe that the provision gets stuck with database_stuck with following erro

Feb 19 20:16:40 nodec35 puppet-agent[15791]: Failed to apply catalog: Parameter before failed on Package[contrail-openstack]: No title provided and "Package[]" is not a valid resource reference at /etc/puppet/environments/ubuntu14mitaka24/modules/contrail/manifests/profile/openstack_controller.pp:91

Feb 19 20:16:40 nodec35 puppet-agent[15791]: Wrapped exception:

Feb 19 20:16:40 nodec35 puppet-agent[15791]: No title provided and "Package[]" is not a valid resource reference

Issue seen in kilo/liberty/mitaka in Ubuntu

Seen in Single/multi interface setups

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/28948
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/28948
Committed: http://github.org/Juniper/contrail-puppet/commit/892544aacbb2e09688c0b80647ec492863c689ec
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 892544aacbb2e09688c0b80647ec492863c689ec
Author: Dheeraj Gautam <email address hidden>
Date: Sun Feb 19 21:51:51 2017 -0800

SM-Ceilometer: packages must be [] instead of ""

Closes-Bug: #1666110

missed to add this change to file.

PATCH2:
address review comment. moving both parts of condition to []

Change-Id: Ia2c865a393bee452bda9ef98973455ac45ac6914

[Dheeraj Gautam (dgautam)]

With R4.0, removed the packages dependencies by packages name. Instead moved to tag based.