Fab detach_vrouter uses control instead of management IP and fails with connection error

[wenqing liang]

On a fab node which is not part the cluster, fab detach_vrouter fails with connection error to the control_data IPs of the cluster nodes (redhat). Management IPs should have been used.

2016-12-30 09:03:31:485950: [root@172.16.80.1] sudo: python /opt/contrail/utils/provision_vrouter.py --host_name b7s35 --host_ip 10.84.29.35 --api_server_ip 172.16.80.1 --oper del --admin_user admin --admin_password c0ntrail123 --admin_tenant_name admin
2016-12-30 09:03:31:486246: Disconnecting from 10.84.29.35... done.
2016-12-30 09:03:41:613465: Traceback (most recent call last):
2016-12-30 09:03:41:496815: File "/usr/local/lib/python2.7/dist-packages/fabric/main.py", line 743, in main
2016-12-30 09:03:41:496867: *args, **kwargs
2016-12-30 09:03:41:497085: File "/usr/local/lib/python2.7/dist-packages/fabric/tasks.py", line 415, in execute
2016-12-30 09:03:41:497122: results['<local-only>'] = task.run(*args, **new_kwargs)
2016-12-30 09:03:41:497274: File "/usr/local/lib/python2.7/dist-packages/fabric/tasks.py", line 171, in run
2016-12-30 09:03:41:497309: return self.wrapped(*args, **kwargs)
2016-12-30 09:03:41:497406: File "/root/store/fabric-utils/fabfile/tasks/misc.py", line 67, in detach_vrouter_node
2016-12-30 09:03:41:497439: (compute_hostname, host_string.split('@')[1], cfgm_ip, get_mt_opts()))
2016-12-30 09:03:41:497533: File "/usr/local/lib/python2.7/dist-packages/fabric/network.py", line 633, in host_prompting_wrapper
2016-12-30 09:03:41:497569: return func(*args, **kwargs)
2016-12-30 09:03:41:497770: File "/usr/local/lib/python2.7/dist-packages/fabric/operations.py", line 1095, in sudo
2016-12-30 09:03:41:497805: stderr=stderr, timeout=timeout, shell_escape=shell_escape,
2016-12-30 09:03:41:498107: File "/usr/local/lib/python2.7/dist-packages/fabric/operations.py", line 909, in _run_command
2016-12-30 09:03:41:498142: channel=default_channel(), command=wrapped_command, pty=pty,
2016-12-30 09:03:41:498398: File "/usr/local/lib/python2.7/dist-packages/fabric/state.py", line 387, in default_channel
2016-12-30 09:03:41:498431: chan = _open_session()
2016-12-30 09:03:41:498563: File "/usr/local/lib/python2.7/dist-packages/fabric/state.py", line 379, in _open_session
2016-12-30 09:03:41:498597: return connections[env.host_string].get_transport().open_session()
2016-12-30 09:03:41:498723: File "/usr/local/lib/python2.7/dist-packages/fabric/network.py", line 154, in __getitem__
2016-12-30 09:03:41:498756: self.connect(key)
2016-12-30 09:03:41:498849: File "/usr/local/lib/python2.7/dist-packages/fabric/network.py", line 146, in connect
2016-12-30 09:03:41:498882: user, host, port, cache=self, seek_gateway=seek_gateway)
2016-12-30 09:03:41:498973: File "/usr/local/lib/python2.7/dist-packages/fabric/network.py", line 559, in connect
2016-12-30 09:03:41:499006: raise NetworkError(msg, e)
2016-12-30 09:03:41:499181: fabric.exceptions.NetworkError: Timed out trying to connect to 172.16.80.1 (tried 1 time)
2016-12-30 09:03:41:499313:

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/27715
Submitter: Ranjeet R (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/27715
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/c4de70392511ef708d5f4532249839b7507a0c1d
Submitter: Zuul (<email address hidden>)
Branch: master

commit c4de70392511ef708d5f4532249839b7507a0c1d
Author: Ranjeet R <email address hidden>
Date: Fri Jan 6 03:16:19 2017 -0800

Fixes: Fab detach_vrouter uses control instead of management IP and fails with connection error

detach_vrouter uses the cfgm's control IP address to run the fab
command to the detach the vrouter from its db. If the fab node
is different from the cfgm, then control IP would be unreachable.
Using the mgmt IP instead of the ctrl IP.

Change-Id: I5458519656f5ccbb3e6af4ff5bdef174cfcfeac9
Closes-Bug: 1654040