Juniper Openstack

SG rule that reference remote_group_id must be deleted when this remote_group_id is deleted

  1. Series trunk
  2. Bug #1591976
Bug #1591976 reported by Ala Rezmerita
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.1
Fix Committed
Medium
Édouard Thuleau
Juniper Openstack r3.1.0.0-fcs
Trunk
Fix Committed
Medium
Édouard Thuleau
Juniper Openstack r3.2.0.0-fcs "r3.2.0.0"

Bug Description

When a security group (say test1) is referenced (as remote_group_id) in a rule of another security group and the first group (test1) is deleted, all the rules that reference this SG (test1) must be deleted.

Test tempest associated with this bug:
tempest.api.compute.security_groups.test_security_group_rules.SecurityGroupRulesTestJSON.test_security_group_rules_delete_when_peer_group_deleted

Nagabhushana R (bhushana)
tags: added: neutron
Nagabhushana R (bhushana)
Changed in juniperopenstack:
importance: Undecided → Medium
Changed in opencontrail:
importance: Undecided → Medium
Changed in juniperopenstack:
assignee: nobody → Sachin Bansal (sbansal)
Changed in opencontrail:
assignee: nobody → Sachin Bansal (sbansal)
Sachin Bansal (sbansal)
Changed in juniperopenstack:
status: New → Won't Fix
Changed in opencontrail:
status: New → Won't Fix
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22721
Submitter: ?douard Thuleau (<email address hidden>)

Édouard Thuleau (ethuleau)
Changed in opencontrail:
assignee: Sachin Bansal (sbansal) → Édouard Thuleau (ethuleau)
status: Won't Fix → In Progress
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/22758
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/22721
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/22758
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/22721
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22852
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22721
Committed: http://github.org/Juniper/contrail-controller/commit/3408092005099c0ba2e9f1d3398f2c5d98467152
Submitter: Zuul
Branch: master

commit 3408092005099c0ba2e9f1d3398f2c5d98467152
Author: Édouard Thuleau <email address hidden>
Date: Mon Aug 1 18:00:21 2016 +0200

[VNC OpenStack] Remove stale security group rules

When a security group is deleted all security group rules which
reference it as 'remote_group_id' should be deleted.
As the contrail data model does not permit to easy found that rules,
that fix propose to clean that stale rules only when they are listed or
read.

[1] https://github.com/openstack/tempest/search?utf8=%E2%9C%93&q=test_security_group_rules_delete_when_peer_group_deleted&type=Code

Change-Id: Ifcd39f7f7b04c07cb6d4b62aa8aa90007f8bc81d
Closes-Bug: #1591976
(cherry picked from commit ad6a675556ec8bcbd53e9705e1a748ff0f866b00)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22852
Committed: http://github.org/Juniper/contrail-controller/commit/3008c4333e73605142c22c11d9ca853499d70cf0
Submitter: Zuul
Branch: R3.1

commit 3008c4333e73605142c22c11d9ca853499d70cf0
Author: Édouard Thuleau <email address hidden>
Date: Mon Aug 1 18:00:21 2016 +0200

[VNC OpenStack] Remove stale security group rules

When a security group is deleted all security group rules which
reference it as 'remote_group_id' should be deleted.
As the contrail data model does not permit to easy found that rules,
that fix propose to clean that stale rules only when they are listed or
read.

[1] https://github.com/openstack/tempest/search?utf8=%E2%9C%93&q=test_security_group_rules_delete_when_peer_group_deleted&type=Code

Change-Id: Ifcd39f7f7b04c07cb6d4b62aa8aa90007f8bc81d
Closes-Bug: #1591976
(cherry picked from commit ad6a675556ec8bcbd53e9705e1a748ff0f866b00)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22758
Committed: http://github.org/Juniper/contrail-neutron-plugin/commit/c4b16ec5a35ec8724311f1b44907f10d1a3265b5
Submitter: Zuul
Branch: master

commit c4b16ec5a35ec8724311f1b44907f10d1a3265b5
Author: Édouard Thuleau <email address hidden>
Date: Tue Aug 2 10:57:30 2016 +0200

Remove stale security group rules

When a security group is deleted all security group rules which
reference it as 'remote_group_id' should be deleted.
As the contrail data model does not permit to easy found that rules,
that fix propose to hide that stale rules only when they are listed or
read.

[1] https://github.com/openstack/tempest/search?utf8=%E2%9C%93&q=test_security_group_rules_delete_when_peer_group_deleted&type=Code

Change-Id: I219f4127785ab300302f2b7454321de83770a4a9
Closes-Bug: #1591976

Jeba Paulaiyan (jebap)
tags: added: tempest
Sachin Bansal (sbansal)
Changed in opencontrail:
status: In Progress → Fix Committed
no longer affects: opencontrail
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.