Compute Reboot fails for SM Upgrade of Contrail 3.0->3.0

[Nitish Krishna Kaveri]

When Contrail is upgraded from 3.0 to 3.0 higher build, reboot doesn't occur during compute provision.
Because of this, contrail-vrouter old processes continue to run.

The underlying cause is that in 3.0 fresh install the contrail_upgrade.pp script runs (because the check for contrail upgrade_needed is wrong).
Because contrail_upgrade.pp runs in fresh, it doesn't get triggered in upgrade. (unless clause)

Changes needed:
1. custom fact to find installed contrail_version needs to be changed
2. check for clean_out_files needs to be changed
3. Compute reboot notify needs to be changed

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18508
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18509
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18508
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18509
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18508
Committed: http://github.org/Juniper/contrail-puppet/commit/f127fcd324212938dfb144c7bdac2533d4f7f8ce
Submitter: Zuul
Branch: master

commit f127fcd324212938dfb144c7bdac2533d4f7f8ce
Author: nitishkrishna <email address hidden>
Date: Thu Mar 17 11:59:14 2016 -0700

Closes-Bug: #1558719 - Compute Reboot was not being triggered for 3.0->3.0 upgrade

Fix:
Changed contrail-version fact to check for contrail-lib package instead of contrail-install-packages
Beacuse 3.0 release code will run contrail_upgrade in fresh install, need to have different check for 3.0 onwards (check and unless for exec changed)
Check for upgrade_needed was wrong (this is why contrail_upgrade was triggered for fresh install in 3.0 2723)

Patch 2:
Added back $needed_version check in if clause

Change-Id: Iab774b345a87b9d0f191acbabbc8c12430a750b4

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18509
Committed: http://github.org/Juniper/contrail-puppet/commit/a2c1b9c7928f12adfee8ea373ed2719b8661b702
Submitter: Zuul
Branch: R3.0

commit a2c1b9c7928f12adfee8ea373ed2719b8661b702
Author: nitishkrishna <email address hidden>
Date: Thu Mar 17 11:59:14 2016 -0700

Closes-Bug: #1558719 - Compute Reboot was not being triggered for 3.0->3.0 upgrade

Fix:
Changed contrail-version fact to check for contrail-lib package instead of contrail-install-packages
Beacuse 3.0 release code will run contrail_upgrade in fresh install, need to have different check for 3.0 onwards (check and unless for exec changed)
Check for upgrade_needed was wrong (this is why contrail_upgrade was triggered for fresh install in 3.0 2723)

Patch 2:
Added back $needed_version check in if clause

Change-Id: Iab774b345a87b9d0f191acbabbc8c12430a750b4