Error in Schema transformer and instances are failed to resolve dhcp IP in a specific scenario

[Vijay Anand]

Build: 2.21(102)

Test: 20 Parallel instances

Scenario-A (Problem condition):
1. All the instances shares Left, Mgmt and Right Network.
2. Network policy is same (port, protocol - any, left_nw-> right_nw )

Observation:
  Error in Schema transformer, no instances gets IP.

Workaround:
   Restart contrail-schema

Scenario-B(Working case):
1. All the instances shares Mgmt and Right Network. Left Network is unique per instance
2. Network policy is different (port, protocol-any, left_nwx->right_nw), x- unique subnet

[Sachin Bansal (sbansal)]

This is not a valid test case. Creating multiple service chains with same match condition and sequence number causes schema transformer to non-deterministically select one of them as active and this creates a churn where it is continuously deleting and creating service chains. Because of this cassandra takes longer and longer to respond and eventually times out, resulting in error.

[Vijay Anand (vijanand)]

This scenario results in schema transformer error and we had to restart contrail-schema to recover.. i.e. no workaround. If any restrictions we should reject the config so that we don't hit such issues.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18237
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18237
Committed: http://github.org/Juniper/contrail-controller/commit/d091e66cfe4d7595fc1866c1289a5c5fa0f01719
Submitter: Zuul
Branch: master

commit d091e66cfe4d7595fc1866c1289a5c5fa0f01719
Author: Sachin Bansal <email address hidden>
Date: Mon Mar 7 17:22:44 2016 -0800

Use service list also as key for service chains

Currently, ServiceChain class does not use service list as a key.
As a result, if there are two policy rules with the same match condition,
but different service lists, we will keep on deleting one service chain
and creating another one. With this change, the two rules will result in
two separate service chains and they should be indpendently created and
deleted and should not interfere with each other.

Change-Id: If4009330d32ab885fb64cfe98adf551e00662c53
Closes-Bug: 1508044

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18306
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18237
Committed: http://github.org/Juniper/contrail-controller/commit/d091e66cfe4d7595fc1866c1289a5c5fa0f01719
Submitter: Zuul
Branch: master

commit d091e66cfe4d7595fc1866c1289a5c5fa0f01719
Author: Sachin Bansal <email address hidden>
Date: Mon Mar 7 17:22:44 2016 -0800

Use service list also as key for service chains

Currently, ServiceChain class does not use service list as a key.
As a result, if there are two policy rules with the same match condition,
but different service lists, we will keep on deleting one service chain
and creating another one. With this change, the two rules will result in
two separate service chains and they should be indpendently created and
deleted and should not interfere with each other.

Change-Id: If4009330d32ab885fb64cfe98adf551e00662c53
Closes-Bug: 1508044

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18306
Committed: http://github.org/Juniper/contrail-controller/commit/5f5ae464d8b57a9f29618ab1047245cbcd170e5b
Submitter: Zuul
Branch: R3.0

commit 5f5ae464d8b57a9f29618ab1047245cbcd170e5b
Author: Sachin Bansal <email address hidden>
Date: Mon Mar 7 17:22:44 2016 -0800

Use service list also as key for service chains

Currently, ServiceChain class does not use service list as a key.
As a result, if there are two policy rules with the same match condition,
but different service lists, we will keep on deleting one service chain
and creating another one. With this change, the two rules will result in
two separate service chains and they should be indpendently created and
deleted and should not interfere with each other.

Change-Id: If4009330d32ab885fb64cfe98adf551e00662c53
Closes-Bug: 1508044
(cherry picked from commit d091e66cfe4d7595fc1866c1289a5c5fa0f01719)