contrail-schema transformer not deleting VM instances once service instance is deleted

[Ranjini Rajendran]

Steps to reproduce:

1. Create a service instance.
2. Create a service policy using this SI
3. Attach the service policy to appropriate VNs.
4. Delete the SI from Contrail WebUI.

Schema transformer introspect will still show the SI as not deleted.
Restarting the schema transformer also doesnt fix this.

Then when same SI is created again, service chain becomes broken
This caused basic service chain to not work in R2.21 build 99

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14026
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14026
Committed: http://github.org/Juniper/contrail-controller/commit/b5fe2fa3a6a2648e3e7a8d0759cd53dfce9ada93
Submitter: Zuul
Branch: R2.20

commit b5fe2fa3a6a2648e3e7a8d0759cd53dfce9ada93
Author: Sachin Bansal <email address hidden>
Date: Wed Sep 23 19:58:10 2015 -0700

Use vm_name to delete the VM object

Schema transformer was incorrecty using si_name to delete VM object. It should
use vm_name. Because of this, stale VM objects remain in schema transformer
local memory and so, if SI is created again, it thinks the VM exists but no VMIs
exist and hence service chain is not created.

This is partial fix because we still do not break service chain when SI is deleted.

Change-Id: I4458352e3af0feeb1f68c57920b6875991cfac81
Partial-Bug: 1499125

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14095
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14095
Committed: http://github.org/Juniper/contrail-controller/commit/b8d047ecab31f8f6a7da498aad71f4bc6730bad3
Submitter: Zuul
Branch: master

commit b8d047ecab31f8f6a7da498aad71f4bc6730bad3
Author: Sachin Bansal <email address hidden>
Date: Mon Sep 28 14:29:19 2015 -0700

Destroy service chain if service instance is deleted

Currently, once a service chain is created, we do not check again until the service instance is removed from policy or policy is detached from VN. But it is possible that either the VM, VMI or service instance has been deleted or has some problem. In those cases, we should check the validity of the service chain again and destroy it if everything is no longer valid.

Change-Id: Ic16d4af50057f6e842d1d4e2356d72728681a182
Closes-Bug: 1499125

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14213
Submitter: Hampapur Ajay (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14213
Committed: http://github.org/Juniper/contrail-controller/commit/5558248eff5c014d6949365ffe4091331b25760b
Submitter: Zuul
Branch: R2.20.x

commit 5558248eff5c014d6949365ffe4091331b25760b
Author: Sachin Bansal <email address hidden>
Date: Wed Sep 23 19:58:10 2015 -0700

Use vm_name to delete the VM object

Schema transformer was incorrecty using si_name to delete VM object. It should
use vm_name. Because of this, stale VM objects remain in schema transformer
local memory and so, if SI is created again, it thinks the VM exists but no VMIs
exist and hence service chain is not created.

This is partial fix because we still do not break service chain when SI is deleted.

Change-Id: I4458352e3af0feeb1f68c57920b6875991cfac81
Partial-Bug: 1499125
(cherry picked from commit b5fe2fa3a6a2648e3e7a8d0759cd53dfce9ada93)