discovery server doesn't show actual IP address of publishers and subscribers

Bug #1475784 reported by Deepinder Setia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
Medium
Deepinder Setia
Trunk
Fix Committed
Medium
Deepinder Setia

Bug Description

In most deployments, users of discovery services come via ha-proxy. Discovery reports IP address of clients based on socket information so it always shows IP address of ha-proxy instead of real IP address of client. Discovery server should allow clients to send in their real IP addresses in HTTP headers.

Tags: discovery
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12476
Submitter: Deepinder Setia (<email address hidden>)

Revision history for this message
Foucault de Bonneval (foucaultdebonneval) wrote :

Hi Deepinder,

Could you make _myip configurable ? As the "exposed" IP.

In case the client is behind a NAT before the haproxy, source IP will still be wrong.

Thanks,
Foucault

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12619
Submitter: Deepinder Setia (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12619
Committed: http://github.org/Juniper/contrail-controller/commit/495f7643c41adf62125528b8dc94e2bd40925909
Submitter: Zuul
Branch: R2.20

commit 495f7643c41adf62125528b8dc94e2bd40925909
Author: Deepinder Setia <email address hidden>
Date: Fri Jul 24 02:35:04 2015 -0700

bug 1475784 -- Allow clients to pass real IP address in message body

Change-Id: I4d80cf899aba2405450a0b8dcb3ac017c4686201

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13154
Submitter: Nipa Kumar (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13154
Committed: http://github.org/Juniper/contrail-controller/commit/550dd1e10968a8de0d307672c1624a882a536c2b
Submitter: Zuul
Branch: R2.20

commit 550dd1e10968a8de0d307672c1624a882a536c2b
Author: Nipa Kumar <email address hidden>
Date: Tue Aug 18 15:02:50 2015 -0700

Send publisher <remote-addr> in the publish message body

Add code for backward compatibilty i.e newer client and older
discovery server, so publish can fallback to older api
on expected cookie mis-match(update tests accordingly)

Partial-Bug:#1475784
Change-Id: Ic0db5ab565007fc7296b089242188e6473a601d0

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13259
Submitter: Nipa Kumar (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13259
Committed: http://github.org/Juniper/contrail-controller/commit/5d8a1f51f598507669342cccafc81c57709685b3
Submitter: Zuul
Branch: master

commit 5d8a1f51f598507669342cccafc81c57709685b3
Author: Nipa Kumar <email address hidden>
Date: Tue Aug 18 15:02:50 2015 -0700

Send publisher <remote-addr> in the publish message body

Add code for backward compatibilty i.e newer client and older
discovery server, so publish can fallback to older api
on expected cookie mis-match(update tests accordingly)

Partial-Bug:#1475784
Change-Id: Ic0db5ab565007fc7296b089242188e6473a601d0

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13681
Submitter: Deepinder Setia (<email address hidden>)

Nipa (nipak)
no longer affects: opencontrail
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13681
Committed: http://github.org/Juniper/contrail-controller/commit/d7f9f5ac0f6db002e3ea8ce868588560712ccd6d
Submitter: Zuul
Branch: master

commit d7f9f5ac0f6db002e3ea8ce868588560712ccd6d
Author: Deepinder Setia <email address hidden>
Date: Fri Jul 24 02:35:04 2015 -0700

Allow clients to pass real IP address in message body

Closes-Bug:#1475784

Change-Id: I4d80cf899aba2405450a0b8dcb3ac017c4686201
(cherry picked from commit 495f7643c41adf62125528b8dc94e2bd40925909)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.