Subnet UUID got a 33-char ID instead of a 32-char id

Bug #1473857 reported by Vedamurthy Joshi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
High
Biswajit Mandal
Trunk
Fix Committed
High
Biswajit Mandal

Bug Description

R2.20 64

The subnet for vn3 was created in the UI.
It ended up getting a 33-character UUID instead of 32-chars

root@nodec2:~# neutron subnet-list
+---------------------------------------+------+---------------+------------------------------------------------+
| id | name | cidr | allocation_pools |
+---------------------------------------+------+---------------+------------------------------------------------+
| a0345a65-9155-45e7-a512-63782844b225 | | 10.250.1.0/24 | {"start": "10.250.1.1", "end": "10.250.1.254"} |
| 61bcf2df-80f4-4076-a340-9ef69393aaca | | 100.64.0.0/29 | {"start": "100.64.0.1", "end": "100.64.0.6"} |
| 1df4c33a-2e0c-4f98-9baf-03310048b190 | | 201.1.1.0/24 | {"start": "201.1.1.2", "end": "201.1.1.254"} |
| 913cf869-d150-4e74-9cba-cf8cfa36b4a6 | | 100.1.1.0/24 | {"start": "100.1.1.2", "end": "100.1.1.254"} |
| 75428e88-5193-49e5-ae06-45883aae0fe9 | | 200.1.1.0/24 | {"start": "200.1.1.2", "end": "200.1.1.254"} |
| 14c5fb05-dd3f-40a6-9334-191c26ab9d66 | | 50.1.1.0/24 | {"start": "50.1.1.2", "end": "50.1.1.254"} |
| dbb1b76f-0fd7-4ed5-ae65-b3f9068c6e88 | | 40.1.1.0/24 | {"start": "40.1.1.2", "end": "40.1.1.254"} |
| 34658b7b-58f6-445b-8b100-3827bf881f5e | | 30.1.1.0/24 | {"start": "30.1.1.2", "end": "30.1.1.254"} |
+---------------------------------------+------+---------------+------------------------------------------------+
root@nodec2:~# neutron subnet-show 34658b7b-58f6-445b-8b100-3827bf881f5e
Unable to find subnet with name '34658b7b-58f6-445b-8b100-3827bf881f5e'
root@nodec2:~#

Tags: ui
Revision history for this message
Prakash Bailkeri (prakashmb) wrote :

VN is created from UI and subnet-uuid is created/set by UI.

Additional check will be added in api server to reject such requests.

Changed in juniperopenstack:
assignee: nobody → Biswajit Mandal (bmandal)
Revision history for this message
asbalaji (asbalaji) wrote :
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12359
Submitter: Prakash Bailkeri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12362
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12359
Submitter: Prakash Bailkeri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12362
Committed: http://github.org/Juniper/contrail-third-party-cache/commit/35a23a7430cb6903438e16a1880d6df902f29418
Submitter: Zuul
Branch: master

commit 35a23a7430cb6903438e16a1880d6df902f29418
Author: Biswajit Mandal <email address hidden>
Date: Mon Jul 13 15:17:31 2015 +0530

Closes-Bug: #1473857
Upgrading uuid-js module from 0.7.4 to 0.7.5 which does have the below fix:
https://github.com/dominykas/uuid-js/commit/a5ce4c8416c93635be75f760329451a6dffde569
which is required to have the fix that sometimes uuid is getting generated in
wrong format.
Adding both server-side and client-side uuid.js file of version 0.7.5
Change-Id: I49bf4a4067d370208619e00f802daaa0de1ff1e7

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12359
Submitter: Prakash Bailkeri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12371
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12371
Committed: http://github.org/Juniper/contrail-webui-third-party/commit/45294734233d2d25f275803dce58728776376309
Submitter: Zuul
Branch: master

commit 45294734233d2d25f275803dce58728776376309
Author: Biswajit Mandal <email address hidden>
Date: Tue Jul 14 00:10:22 2015 +0530

Related-Bug: #1473857
Upgrading uuid-js from 0.7.4 to 0.7.5

Change-Id: Ibdb167ccb7d5ab1467148044bf8e23b81b0100ef

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12382
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12359
Submitter: Prakash Bailkeri (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12382
Committed: http://github.org/Juniper/contrail-web-core/commit/6fa182707096357d7767d3c6e41f81d9a4179c64
Submitter: Zuul
Branch: master

commit 6fa182707096357d7767d3c6e41f81d9a4179c64
Author: Biswajit Mandal <email address hidden>
Date: Tue Jul 14 00:12:40 2015 +0530

Related-Bug: #1473857
Changing he uuid-js filr to 0.7.5 for frontend.

Change-Id: I28415a3d75d13e829626122e4bc587f189598e9f

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12432
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12432
Committed: http://github.org/Juniper/contrail-web-core/commit/d19cf368450fe7203bd5c85fb29a908a9cfd638e
Submitter: Zuul
Branch: master

commit d19cf368450fe7203bd5c85fb29a908a9cfd638e
Author: Biswajit Mandal <email address hidden>
Date: Thu Jul 16 08:42:31 2015 +0530

Closes-Bug: #1473857
Reverted the changes I28415a3d75d13e829626122e4bc587f189598e9f
As in webui-third-party, the file name we are changing to uuid.js, so no need to
change it in core.

Change-Id: I0dc8fcaf2db4dd9bb191ed9a6f4b3697c0eb9fef

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12359
Committed: http://github.org/Juniper/contrail-controller/commit/803e4fd42b1bb72c94cb1942a4eefccc58bcfd09
Submitter: Zuul
Branch: master

commit 803e4fd42b1bb72c94cb1942a4eefccc58bcfd09
Author: Prakash Bailkeri <email address hidden>
Date: Mon Jul 13 01:13:21 2015 -0700

Subnet uuid passed in network-ipam-refs by WebUI/any vnc api Client can be invalid.

Reject subnet create(network-update) operation in such cases.

Also, added subnet validation code for POST operation

Change-Id: Iee97cd82c3a94fa183d713af19a0a36cbcc66dd9
Closes-bug: #1473857

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13806
Submitter: Atul Moghe (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13806
Committed: http://github.org/Juniper/contrail-controller/commit/ab47969df91e533735c5a763c33a8bd60be65f6b
Submitter: Zuul
Branch: R2.22-dev

commit ab47969df91e533735c5a763c33a8bd60be65f6b
Author: Prakash Bailkeri <email address hidden>
Date: Mon Jul 13 01:13:21 2015 -0700

Subnet uuid passed in network-ipam-refs by WebUI/any vnc api Client can be invalid.

Reject subnet create(network-update) operation in such cases.

Also, added subnet validation code for POST operation

Change-Id: Iee97cd82c3a94fa183d713af19a0a36cbcc66dd9
Closes-bug: #1473857
(cherry picked from commit 803e4fd42b1bb72c94cb1942a4eefccc58bcfd09)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.