Agent creates NH with 0.0.0.0

Bug #1466113 reported by Praveen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
High
Praveen
Trunk
Fix Committed
High
Praveen

Bug Description

On executing "service supervisor-restart", agent is creating tunnel-nh with destination-ip 0.0.0.0

Tags: vrouter
Revision history for this message
Praveen (praveen-karadakal) wrote :

When OVS Peer adds routes, it does not set the server_ip_ field in the
AgentPath. Further when route is rebaked, the AgentPath module uses the
server_ip_ field to create the NH. This can result in NH being created
with dest-ip=0.0.0.0

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/11750
Submitter: Praveen K V (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11750
Committed: http://github.org/Juniper/contrail-controller/commit/56541328c761eaf037bc234a0ddff5723c3f4faf
Submitter: Zuul
Branch: R2.20

commit 56541328c761eaf037bc234a0ddff5723c3f4faf
Author: Praveen K V <email address hidden>
Date: Wed Jun 17 19:57:04 2015 +0530

Fix tunnel-dest IP being set to 0.0.0.0

When OVS Peer adds routes, it does not set the server_ip_ field in the
AgentPath. Further when route is rebaked, the AgentPath module uses the
server_ip_ field to create the NH. This can result in NH being created
with dest-ip=0.0.0.0

Fix:
1. Modified ChangeNH() to pick the dest-ip and store in server_ip_ field of
AgentPath.

Additional changes:
1. server_ip_ was a misnomer. Its renamed to tunnel_dest_
2. UT to verify the scenario

Change-Id: I2e2cf4c90a0c56765ab5b3313fda421c329a4b2d
Closes-Bug: #1466113

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/11869
Submitter: Praveen K V (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11869
Committed: http://github.org/Juniper/contrail-controller/commit/218a8f51c737ce561cf0008c87b3d114365f24f7
Submitter: Zuul
Branch: master

commit 218a8f51c737ce561cf0008c87b3d114365f24f7
Author: Praveen K V <email address hidden>
Date: Wed Jun 17 19:57:04 2015 +0530

Fix tunnel-dest IP being set to 0.0.0.0

When OVS Peer adds routes, it does not set the server_ip_ field in the
AgentPath. Further when route is rebaked, the AgentPath module uses the
server_ip_ field to create the NH. This can result in NH being created
with dest-ip=0.0.0.0

Fix:
1. Modified ChangeNH() to pick the dest-ip and store in server_ip_ field of
AgentPath.

Additional changes:
1. server_ip_ was a misnomer. Its renamed to tunnel_dest_
2. UT to verify the scenario

Change-Id: I2e2cf4c90a0c56765ab5b3313fda421c329a4b2d
Closes-Bug: #1466113

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.