Router's RT not removed from VN when subnet is disassociated from the router

[Vedamurthy Joshi]

R2.20 Build 39 Ubuntu 14.04 multi-node setup

This test test_basic_router_behavior failed in sanity on multiple testbeds

http://10.204.216.50/Docs/logs/2.20-39_2015_06_03_15_22_27/logs/testrouters.log
http://10.204.216.50/Docs/logs/2.20-39_2015_06_03_15_22_27/junit-noframes.html

Initially two vns were connected to a router. A ping was run from vms across the vns.
After disassociating one of the vns from the router, the ping was tried again and it passed

It is seen that in control-node, the router's RT continues to be present in import/export rt list of the VN which has been disassociated.

Below 8000004 shouldn't have been part of rt list of VN vn1-65598457
----------------

root@nodei21:~/contrail-test/logs# curl http://nodei22:8083/Snh_ShowRoutingInstanceReq?x=default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457
<?xml-stylesheet type="text/xsl" href="/universal_parse.xsl"?><ShowRoutingInstanceResp type="sandesh"><instances type="list" identifier="1"><list type="struct" size="1"><ShowRoutingInstance><name type="string" identifier="1" link="ShowRoutingInstanceReq">default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457</name><virtual_network type="string" identifier="3">default-domain:TestRouters-11434480:vn1-65598457</virtual_network><vn_index type="i32" identifier="6">162</vn_index><vxlan_id type="i32" identifier="8">0</vxlan_id><deleted type="bool" identifier="7">false</deleted><import_target type="list" identifier="4"><list type="string" size="2"><element>target:64512:8000002</element><element>target:64512:8000004</element></list></import_target><export_target type="list" identifier="5"><list type="string" size="2"><element>target:64512:8000002</element><element>target:64512:8000004</element></list></export_target><tables type="list" identifier="2"><list type="struct" size="4"><ShowRoutingInstanceTable><name type="string" identifier="1" link="ShowRouteReq">default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457.ermvpn.0</name><deleted type="bool" identifier="13">false</deleted><peers type="list" identifier="2"><list type="string" size="1"><element>nodei24</element></list></peers><prefixes type="u64" identifier="3">2</prefixes><paths type="u64" identifier="4">2</paths><primary_paths type="u64" identifier="5">2</primary_paths><secondary_paths type="u64" identifier="6">0</secondary_paths><infeasible_paths type="u64" identifier="7">0</infeasible_paths><walk_requests type="u64" identifier="8">696</walk_requests><walk_completes type="u64" identifier="9">696</walk_completes><walk_cancels type="u64" identifier="10">0</walk_cancels><pending_updates type="u64" identifier="11">0</pending_updates><markers type="u64" identifier="12">0</markers></ShowRoutingInstanceTable><ShowRoutingInstanceTable><name type="string" identifier="1" link="ShowRouteReq">default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457.evpn.0</name><deleted type="bool" identifier="13">false</deleted><peers type="list" identifier="2"><list type="string" size="1"><element>nodei24</element></list></peers><prefixes type="u64" identifier="3">5</prefixes><paths type="u64" identifier="4">8</paths><primary_paths type="u64" identifier="5">5</primary_paths><secondary_paths type="u64" identifier="6">3</secondary_paths><infeasible_paths type="u64" identifier="7">0</infeasible_paths><walk_requests type="u64" identifier="8">696</walk_requests><walk_completes type="u64" identifier="9">696</walk_completes><walk_cancels type="u64" identifier="10">0</walk_cancels><pending_updates type="u64" identifier="11">0</pending_updates><markers type="u64" identifier="12">0</markers></ShowRoutingInstanceTable><ShowRoutingInstanceTable><name type="string" identifier="1" link="ShowRouteReq">default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457.inet.0</name><deleted type="bool" identifier="13">false</deleted><peers type="list" identifier="2"><list type="string" size="1"><element>nodei24</element></list></peers><prefixes type="u64" identifier="3">2</prefixes><paths type="u64" identifier="4">4</paths><primary_paths type="u64" identifier="5">1</primary_paths><secondary_paths type="u64" identifier="6">3</secondary_paths><infeasible_paths type="u64" identifier="7">0</infeasible_paths><walk_requests type="u64" identifier="8">696</walk_requests><walk_completes type="u64" identifier="9">696</walk_completes><walk_cancels type="u64" identifier="10">0</walk_cancels><pending_updates type="u64" identifier="11">0</pending_updates><markers type="u64" identifier="12">0</markers></ShowRoutingInstanceTable><ShowRoutingInstanceTable><name type="string" identifier="1" link="ShowRouteReq">default-domain:TestRouters-11434480:vn1-65598457:vn1-65598457.inet6.0</name><deleted type="bool" identifier="13">false</deleted><peers type="list" identifier="2"><list type="string" size="1"><element>nodei24</element></list></peers><prefixes type="u64" identifier="3">0</prefixes><paths type="u64" identifier="4">0</paths><primary_paths type="u64" identifier="5">0</primary_paths><secondary_paths type="u64" identifier="6">0</secondary_paths><infeasible_paths type="u64" identifier="7">0</infeasible_paths><walk_requests type="u64" identifier="8">696</walk_requests><walk_completes type="u64" identifier="9">696</walk_completes><walk_cancels type="u64" identifier="10">0</walk_cancels><pending_updates type="u64" identifier="11">0</pending_updates><markers type="u64" identifier="12">0</markers></ShowRoutingInstanceTable></list></tables></ShowRoutingInstance></list></instances><more type="bool" identifier="0">false</more></ShowRoutingInstancroot@nodei21:~/contrail-test/logs# neutron router-port-list router1-61519645
+--------------------------------------+--------------------------------------+-------------------+-------------------------------------------------------------------------------------+
| id | name | mac_address | fixed_ips |
+--------------------------------------+--------------------------------------+-------------------+-------------------------------------------------------------------------------------+
| 30b53362-e202-4fa9-8c2b-c86f6b2215dd | 30b53362-e202-4fa9-8c2b-c86f6b2215dd | 02:30:b5:33:62:e2 | {"subnet_id": "b2800a69-d057-42e9-a9a4-3155a3cc7ca6", "ip_address": "17.175.167.1"} |
+--------------------------------------+--------------------------------------+-------------------+-------------------------------------------------------------------------------------+
root@nodei21:~/contrail-test/logs# neutron net-list
+--------------------------------------+-------------------------+--------------------------------------------------------+
| id | name | subnets |
+--------------------------------------+-------------------------+--------------------------------------------------------+
| 53d5b3d9-161e-4963-a466-5e0a59f98db1 | __link_local__ | |
| fbb4b58d-a0dc-41c5-9cc7-2d1b96db8f2b | vn2-05628589 | b2800a69-d057-42e9-a9a4-3155a3cc7ca6 17.175.167.0/24 |
| 6bad201c-c572-445f-ac05-2dfe9e91eddc | in_network_vn2-11083564 | 326338f3-384d-476c-a9c3-a25235e5b07a 200.1.1.0/24 |
| 391f04de-3e8e-4cf1-b42a-957f32772f57 | ip-fabric | |
| 18a1773e-3cdc-41bf-bba8-843eee9dddee | default-virtual-network | |
| ce602f46-7104-41aa-a2ce-29ced2fefc06 | vn1-65598457 | e1d526b8-8835-4202-97c2-015926297239 183.197.221.0/24 |
| b7be1233-410b-4359-8c34-fd28566f5f57 | public | 2ec79d14-2812-4daa-b52a-c00c47da6bc5 10.204.221.192/28 |
+--------------------------------------+-------------------------+--------------------------------------------------------+
root@nodei21:~/contrail-test/logs# curl -u admin:contrail123 http://127.0.0.1:8095/logical-router/14f64061-440f-44fc-8240-906c3f22fcc6 | python -m json.tool
  % Total % Received % Xferd Average Speed Time Time Time Current
                                 Dload Upload Total Spent Left Speed
100 1331 100 1331 0 0 248k 0 --:--:-- --:--:-- --:--:-- 324k
{
    "logical-router": {
        "display_name": "router1-61519645",
        "fq_name": [
            "default-domain",
            "TestRouters-11434480",
            "router1-61519645"
        ],
        "href": "http://127.0.0.1:8095/logical-router/14f64061-440f-44fc-8240-906c3f22fcc6",
        "id_perms": {
            "created": "2015-06-03T17:00:59.639054",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2015-06-03T17:01:06.001440",
            "permissions": {
                "group": "KeystoneServiceAdmin",
                "group_access": 7,
                "other_access": 7,
                "owner": "admin",
                "owner_access": 7
            },
            "user_visible": true,
            "uuid": {
                "uuid_lslong": 9385660418030238918,
                "uuid_mslong": 1510465511527236860
            }
        },
        "name": "router1-61519645",
        "parent_href": "http://127.0.0.1:8095/project/144097d4-89b0-4820-ac16-e5d1d985bba2",
        "parent_type": "project",
        "parent_uuid": "144097d4-89b0-4820-ac16-e5d1d985bba2",
        "route_target_refs": [
            {
                "attr": null,
                "href": "http://127.0.0.1:8095/route-target/dd77ee1f-6882-4b05-a369-e6c7404b48cb",
                "to": [
                    "target:64512:8000004"
                ],
                "uuid": "dd77ee1f-6882-4b05-a369-e6c7404b48cb"
            }
        ],
        "uuid": "14f64061-440f-44fc-8240-906c3f22fcc6",
        "virtual_machine_interface_refs": [
            {
                "attr": null,
                "href": "http://127.0.0.1:8095/virtual-machine-interface/30b53362-e202-4fa9-8c2b-c86f6b2215dd",
                "to": [
                    "default-domain",
                    "TestRouters-11434480",
                    "30b53362-e202-4fa9-8c2b-c86f6b2215dd"
                ],
                "uuid": "30b53362-e202-4fa9-8c2b-c86f6b2215dd"
            }
        ]
    }
}
root@nodei21:~/contrail-test/logs#

[Prakash Bailkeri (prakashmb)]

Debugged the issue in sanity setup and observed that the RT is removed from the config and also from if map.

Ifmap did not publish this update to control-node.

Similar issue was debugged for https://bugs.launchpad.net/juniperopenstack/+bug/1461058.

The issue is not seen when experimented by setting the "—ifmap_max_message_size” to “0”, to avoid bunching of messages.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11284
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11285
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11284
Committed: http://github.org/Juniper/contrail-controller/commit/3086f689cfe7135897ce951c95732c353012b0fd
Submitter: Zuul
Branch: R2.20

commit 3086f689cfe7135897ce951c95732c353012b0fd
Author: Sachin Bansal <email address hidden>
Date: Thu Jun 4 10:33:09 2015 -0700

Do not club updates and deletes in a single message to ifmap

Because of a bug in irond, if update and delete of the same object received by it, it quashes it and the object is not deleted. Till that is fixed, we will split updates and deletes in separate messages.

Change-Id: I5504477351b705837679242554ad2d7ffd529f98
Closes-Bug: 1461058
Closes-Bug: 1461626

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11285
Committed: http://github.org/Juniper/contrail-controller/commit/5f29ea8337bfab03ae845013de98a77977f18e8a
Submitter: Zuul
Branch: master

commit 5f29ea8337bfab03ae845013de98a77977f18e8a
Author: Sachin Bansal <email address hidden>
Date: Thu Jun 4 10:33:09 2015 -0700

Do not club updates and deletes in a single message to ifmap

Because of a bug in irond, if update and delete of the same object received by it, it quashes it and the object is not deleted. Till that is fixed, we will split updates and deletes in separate messages.

Change-Id: I5504477351b705837679242554ad2d7ffd529f98
Closes-Bug: 1461058
Closes-Bug: 1461626
(cherry picked from commit 3086f689cfe7135897ce951c95732c353012b0fd)