TSN did not respond to DHCP discover reqs from BMS when MAC address contains dashes

[Vedamurthy Joshi]

R2.1 Build 54 Ubuntu 14.04 Multi-node setup

#Role definition of the hosts.
env.roledefs = {
    'all': [host1, host2, host3, host4, host5, host6],
    'cfgm': [host1,host2,host3],
    'openstack': [host2],
    'control': [host1,host2,host3],
    'compute': [host4,host5, host6],
    'collector': [host1,host2,host3],
    'webui': [host1],
    'database': [host1,host2,host3],
    'toragent': [host6],
    'tsn': [host6],
    'build': [host_build],
}

env.hostnames = {
    'all': ['nodec1', 'nodec2', 'nodec3', 'nodek1', 'nodek2', 'nodek3']
}

I had two TORs (qfx1, br0) and one BMS on each of the TORs, and part of the same VN

It was seen that for both these BMSs, the DHCP discover packets were reaching TSN, but the vrouter-agent was not responding to it
gcore of vrouter-agent will be in http://10.204.216.50/Docs/bugs/#

root@nodek3:~# tcpdump -ni any port 4789 -xx -vv saw this :

12:00:04.368854 IP (tos 0x0, ttl 63, id 60847, offset 0, flags [DF], proto UDP (17), length 378)
    10.204.216.195.35491 > 10.204.216.223.4789: [no cksum] VXLAN, flags [I] (0x08), vni 4
IP (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 328)
    0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 00:00:00:00:00:02, length 300, xid 0x32c18c7e, secs 9, Flags [none] (0x0000)
          Client-Ethernet-Address 00:00:00:00:00:02
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message Option 53, length 1: Discover
            Hostname Option 12, length 15: "nodeb13-ovs-vm1"
            Parameter-Request Option 55, length 13:
              Subnet-Mask, BR, Time-Zone, Default-Gateway
              Domain-Name, Domain-Name-Server, Option 119, Hostname
              Netbios-Name-Server, Netbios-Scope, MTU, Classless-Static-Route
              NTP
        0x0000: 0004 0001 0006 0000 5e00 0100 0000 0800
        0x0010: 4500 017a edaf 4000 3f11 8588 0acc d8c3
        0x0020: 0acc d8df 8aa3 12b5 0166 0000 0800 0000
        0x0030: 0000 0400 ffff ffff ffff 0000 0000 0002
        0x0040: 0800 4510 0148 0000 0000 8011 3996 0000
        0x0050: 0000 ffff ffff 0044 0043 0134 c3e8 0101
        0x0060: 0600 32c1 8c7e 0009 0000 0000 0000 0000
        0x0070: 0000 0000 0000 0000 0000 0000 0000 0002
        0x0080: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0090: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00a0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00b0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00c0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00d0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00e0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x00f0: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0100: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0110: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0120: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0130: 0000 0000 0000 0000 0000 0000 0000 0000
        0x0140: 0000 0000 0000 0000 0000 6382 5363 3501
        0x0150: 010c 0f6e 6f64 6562 3133 2d6f 7673 2d76
        0x0160: 6d31 370d 011c 0203 0f06 770c 2c2f 1a79
        0x0170: 2aff 0000 0000 0000 0000 0000 0000 0000
        0x0180: 0000 0000 0000 0000 0000
^[[B^[[B^C
12 packets captured
15 packets received by filter
0 packets dropped by kernel

[Vedamurthy Joshi (vedujoshi)]

root@nodek3:~# rt -b -v 1 -f 1
Kernel L2 Bridge table 0/1

Flags: L=Label Valid, Df=DHCP flood

Index DestMac Flags Label/VNID Nexthop
66372 0:0:0:0:0:1 L 4 27
97192 ff:ff:ff:ff:ff:ff L 4 49
236200 c:c4:7a:32:a:8a - 2
252916 0:0:5e:0:1:0 - 2
root@nodek3:~#

[Vedamurthy Joshi (vedujoshi)]

The problem seems to be related to the way the user configures MAC Address for the VMI

If we use the std EUI mac address representation while adding the VMI, i.e. of the format 00-00-00-00-00-01, then DHCP fails
If we use 00:00:00:00:00:01, it passes

We need to be able to understand these varieties of mac-address representations

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10049
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10057
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10049
Committed: http://github.org/Juniper/contrail-controller/commit/64b2ff4f4f52023e79f3c23620189e8b8a01a6db
Submitter: Zuul
Branch: master

commit 64b2ff4f4f52023e79f3c23620189e8b8a01a6db
Author: Hari <email address hidden>
Date: Thu May 7 12:17:12 2015 +0530

If mac address is specified in EUI representation, convert it.

Replace '-' with ':'

Change-Id: Iea5b250ba9a6114a837ef67d28e03711c07026ab
closes-bug: 1448949

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10057
Committed: http://github.org/Juniper/contrail-controller/commit/f4566fe031f907e91e295b9cb62eb111361b05b3
Submitter: Zuul
Branch: R2.20

commit f4566fe031f907e91e295b9cb62eb111361b05b3
Author: Hari <email address hidden>
Date: Thu May 7 12:17:12 2015 +0530

If mac address is specified in EUI representation, convert it.

Replace '-' with ':'

Change-Id: Iea5b250ba9a6114a837ef67d28e03711c07026ab
closes-bug: 1448949
(cherry picked from commit 64b2ff4f4f52023e79f3c23620189e8b8a01a6db)