fabric: onboard fails due to"TypeError: argument of type 'float' is not iterable"

[Senthilnathan Murugappan]

The above is a description of an error in a Python program. Here is
the original traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vnc_cfg_api_server/vnc_cfg_api_server.py", line 2294, in handler_trap_exception
    response = handler(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vnc_cfg_api_server/vnc_cfg_api_server.py", line 631, in execute_job_http_post
    existing_job = self.is_existing_job_for_fabric(fabric_job_uve_name)
  File "/usr/lib/python2.7/site-packages/vnc_cfg_api_server/vnc_cfg_api_server.py", line 558, in is_existing_job_for_fabric
    if fabric_job_uve_name in fabric_info:
TypeError: argument of type 'float' is not iterable

This seems to be a regression of https://github.com/Juniper/contrail-controller/commit/9ba232e082102bfa0cf4b7104d400aef018c052b

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46759
Submitter: Senthilnathan Murugappan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46806
Submitter: Senthilnathan Murugappan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/46806
Committed: http://github.com/Juniper/contrail-controller/commit/dff30f6cbd38a12fee6b5729269a3f95ac15a9a1
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit dff30f6cbd38a12fee6b5729269a3f95ac15a9a1
Author: Senthilnathan Murugappan <email address hidden>
Date: Fri Oct 5 12:06:21 2018 -0700

Fix the logic of identifying the existing fabric job

1) Fix the logic of identifying the existing fabric job
2) Move the execution id generation outside of the is_delete
which causes jobs with is_delete set to True to fail
3) Remove the wholesome try catch which masks these kind of errors

Change-Id: I8999b37d99b26f3a8372dd10c41b6a74b69b63dd
Closes-Bug: 1796389

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/46759
Committed: http://github.com/Juniper/contrail-controller/commit/ea138aeadae92e9e0a524228883f961a04285f45
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ea138aeadae92e9e0a524228883f961a04285f45
Author: Senthilnathan Murugappan <email address hidden>
Date: Fri Oct 5 12:06:21 2018 -0700

Fix the logic of identifying the existing fabric job

1) Fix the logic of identifying the existing fabric job
2) Move the execution id generation outside of the is_delete
which causes jobs with is_delete set to True to fail
3) Remove the wholesome try catch which masks these kind of errors

Change-Id: I8999b37d99b26f3a8372dd10c41b6a74b69b63dd
Closes-Bug: 1796389