BGPaaS: Agent using wrong source-port for BGPaaS connection

[amit surana]

Possible regression due to partial commit of:

https://bugs.launchpad.net/juniperopenstack/+bug/1649707

A BGPaaS object is attached to a VMI. Schema assigns nat-src-port of 50000 for this BGPaaS object; control-node on its part then expects the BGPaaS session to have source port as 50000 also. However, for some reason, the source-port allocated on Agent is 50513.

ShowIFMapAgentResp (shows the correct port):

type:bgp-router name:default-domain:symantec.Tenant25:tenant25.test_id1.Private_BGP_Addnl_VN0:tenant25.test_id1.Private_BGP_Addnl_VN0:07fa3742-ad38-4592-aeaf-e1c3c73a8c07 bgp-router-parameters admin-down:false autonomous-system:652 identifier:1.3.0.3 address:1.3.0.3 port:0 source-port:50000 hold-time:0 auth-data local-autonomous-system:0 router-type:bgpaas-client gateway-address:1.3.0.1 Adjacencies: bgp-as-a-service default-domain:symantec.Tenant25:bgpaas.router routing-instance default-domain:symantec.Tenant25:tenant25.test_id1.Private_BGP_Addnl_VN0:tenant25.test_id1.Private_BGP_Addnl_VN0

BgpAsAServiceSandeshResp (shows the wrong port):

bgp_as_a_service_list
vm_bgp_peer_ip vm_nat_source_port
vmi_uuid
1.3.0.3
50513
07fa3742-ad38-4592-aeaf-e1c3c73a8c07
more
false

[Hari Prasad Killi (haripk)]

This is also addressed as part of changes being committed for https://bugs.launchpad.net/juniperopenstack/+bug/1649707.