Optimize bgp and xmpp update generation - part 2

Bug #1687537 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R4.0
Fix Committed
Wishlist
Nischal Sheth
Trunk
Fix Committed
Wishlist
Nischal Sheth

Bug Description

Further optimizations to bgp and xmpp update generation.

Nischal Sheth (nsheth)
description: updated
no longer affects: juniperopenstack/r3.2
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/30926
Submitter: Nischal Sheth (<email address hidden>)

Nischal Sheth (nsheth)
summary: - Optimize BGP and XMPP update generation - part 2
+ Optimize bgp and xmpp update generation - part 2
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/30926
Committed: http://github.com/Juniper/contrail-controller/commit/d6184307931ead800425a5654f4ccb26bcde4e3a
Submitter: Zuul (<email address hidden>)
Branch: master

commit d6184307931ead800425a5654f4ccb26bcde4e3a
Author: Nischal Sheth <email address hidden>
Date: Mon May 1 11:37:26 2017 -0700

Optimize RibOutAttr constructor for BGP RibOuts

There's no need to allocate a NextHop and add it to the NextHopList for
RibOutAttrs in BGP RibOuts. We can simply store the label and l3_label
in the RibOutAttr itself. All the other attributes are already in the
BgpAttrPtr as there's no need to store ECMP NextHops for BGP RibOuts.

Change-Id: I07ad07165e34d4942f219b7acb28487682830065
Partial-Bug: 1687537

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/31244
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/31244
Committed: http://github.com/Juniper/contrail-controller/commit/7d4b71b0f517a574b51847f78489d17fdf4b1cc3
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 7d4b71b0f517a574b51847f78489d17fdf4b1cc3
Author: Nischal Sheth <email address hidden>
Date: Mon May 1 11:37:26 2017 -0700

Optimize RibOutAttr constructor for BGP RibOuts

There's no need to allocate a NextHop and add it to the NextHopList for
RibOutAttrs in BGP RibOuts. We can simply store the label and l3_label
in the RibOutAttr itself. All the other attributes are already in the
BgpAttrPtr as there's no need to store ECMP NextHops for BGP RibOuts.

Change-Id: I07ad07165e34d4942f219b7acb28487682830065
Partial-Bug: 1687537
(cherry picked from commit d6184307931ead800425a5654f4ccb26bcde4e3a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.