some introspect links missing for contrail-collector, contrail-qe

Bug #1691949 reported by Vedamurthy Joshi on 2017-05-19
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.2
In Progress
High
Megh Bhatt
R4.0
Fix Committed
High
Megh Bhatt
Trunk
Fix Committed
High
Megh Bhatt

Bug Description

R4.0 Build 7 Ubuntu 16.04.2

Similar to bug 1691016 and bug 1691349, some links are missing for contrail-collector and contail-query-engine :

QE:
====
Seen :
cpuinfo.xml
qe.xml
task.xml
version.xml

Expected:
cpuinfo.xml
qe.xml
sandesh_trace.xml
sandesh_uve.xml
task.xml
version.xml

Collector:
============
Seen:
analytics.xml
collector_uve.xml
cpuinfo.xml
kafka.xml
nodeinfo.xml
process_info.xml
redis.xml
sflow.xml
task.xml
uflow.xml
uve_aggregator.xml
version.xml

Expected:
analytics.xml
collector_uve.xml
cpuinfo.xml
kafka.xml
nodeinfo.xml
process_info.xml
redis.xml
sandesh_trace.xml
sandesh_uve.xml
sflow.xml
task.xml
uflow.xml
uve_aggregator.xml
version.xml

Raj Reddy (rajreddy) on 2017-05-19
Changed in juniperopenstack:
assignee: Raj Reddy (rajreddy) → Nikhil Bansal (nikhilb-u)
tags: added: blocker
Raj Reddy (rajreddy) on 2017-05-19
Changed in juniperopenstack:
assignee: Nikhil Bansal (nikhilb-u) → Megh Bhatt (meghb)

Review in progress for https://review.opencontrail.org/31940
Submitter: Megh Bhatt (<email address hidden>)

Reviewed: https://review.opencontrail.org/31940
Committed: http://github.com/Juniper/contrail-sandesh/commit/4074d8af7592a564ba1c55c23021cc95f105c6c1
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 4074d8af7592a564ba1c55c23021cc95f105c6c1
Author: Megh Bhatt <email address hidden>
Date: Sun May 21 00:52:14 2017 -0700

Introspect of daemons missing links to some request files

Global static initialization is used to populate a SandeshHttp
static map with the names of the sandesh IDL files that contain
requests for introspect for a daemon. The static declaration and
definition is done in _html.cpp. In order for the linker to include
the symbols in that translation unit a standalone int is also defined
in the file and used in _types.cpp. However the current usage was just
assigning another static variable this int and as a result the symbols
in the _html.cpp were not included and the map was not populated.
Changed the generated code to assign a value to the standalone int
as part of RequestFromHttp function so that symbols from the
_html.cpp translation units are pulled in.

Change-Id: Id5515bb75fab093fbc62bcebf8fecb5dbed2be9c
Closes-Bug: #1691605
Closes-Bug: #1691949

Review in progress for https://review.opencontrail.org/31959
Submitter: Megh Bhatt (<email address hidden>)

Reviewed: https://review.opencontrail.org/31959
Committed: http://github.com/Juniper/contrail-sandesh/commit/f04e697dac1014684e57aa388d40c0a76170e261
Submitter: Zuul (<email address hidden>)
Branch: master

commit f04e697dac1014684e57aa388d40c0a76170e261
Author: Megh Bhatt <email address hidden>
Date: Sun May 21 00:52:14 2017 -0700

Introspect of daemons missing links to some request files

Global static initialization is used to populate a SandeshHttp
static map with the names of the sandesh IDL files that contain
requests for introspect for a daemon. The static declaration and
definition is done in _html.cpp. In order for the linker to include
the symbols in that translation unit a standalone int is also defined
in the file and used in _types.cpp. However the current usage was just
assigning another static variable this int and as a result the symbols
in the _html.cpp were not included and the map was not populated.
Changed the generated code to assign a value to the standalone int
as part of RequestFromHttp function so that symbols from the
_html.cpp translation units are pulled in.

Change-Id: Id5515bb75fab093fbc62bcebf8fecb5dbed2be9c
Closes-Bug: #1691605
Closes-Bug: #1691949
(cherry picked from commit 4074d8af7592a564ba1c55c23021cc95f105c6c1)

Review in progress for https://review.opencontrail.org/36456
Submitter: Antoine Eiche (<email address hidden>)

Reviewed: https://review.opencontrail.org/36456
Committed: http://github.com/Juniper/contrail-sandesh/commit/60c4f43433d73bfdad5d6dd00fe4642d66d9a4d8
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 60c4f43433d73bfdad5d6dd00fe4642d66d9a4d8
Author: Megh Bhatt <email address hidden>
Date: Sun May 21 00:52:14 2017 -0700

Introspect of daemons missing links to some request files

Global static initialization is used to populate a SandeshHttp
static map with the names of the sandesh IDL files that contain
requests for introspect for a daemon. The static declaration and
definition is done in _html.cpp. In order for the linker to include
the symbols in that translation unit a standalone int is also defined
in the file and used in _types.cpp. However the current usage was just
assigning another static variable this int and as a result the symbols
in the _html.cpp were not included and the map was not populated.
Changed the generated code to assign a value to the standalone int
as part of RequestFromHttp function so that symbols from the
_html.cpp translation units are pulled in.

Change-Id: Id5515bb75fab093fbc62bcebf8fecb5dbed2be9c
Closes-Bug: #1691605
Closes-Bug: #1691949
(cherry picked from commit 4074d8af7592a564ba1c55c23021cc95f105c6c1)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers