Must support a monitor for tbb tasks

[Praveen]

It is observed that TBB randomly goes into a state where no tasks are scheduled. As a recovery the task library needs a monitor which keeps a tab on tasks enqueued and completed execution.

If he monitor identifies that tasks are not being spawned for a configured time, it must restart the process.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30642
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30655
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30642
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30655
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30642
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30655
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30642
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30642
Committed: http://github.com/Juniper/contrail-controller/commit/0138d84cc87f8a4c555bf9256b860ad106e9d70e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 0138d84cc87f8a4c555bf9256b860ad106e9d70e
Author: Praveen K V <email address hidden>
Date: Thu Apr 20 19:53:48 2017 +0530

Replace tbb::task::spawn() by tbb::task::enqueue() and also support for task monitoring

Replace tbb::task::spawn() by tbb::task::enqueue(). enqueue() is more
appropriate call since task library just fires the task without calling
spawn_root_and_wait()

Also, introduced a TaskMonitor class which monitors number of tasks
enqueued to scheduler and number of tasks spawned by TBB. If the monitor
finds tasks are enqueued but not scheduled for a configured time, it
will exit the program.

Change-Id: Ia68d52f4aba0e79a3fe75f8c4fc248d49ab94faf
Fixes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30655
Committed: http://github.com/Juniper/contrail-controller/commit/52f203ea478e4f6721b3b0016211d48b531e4c57
Submitter: Zuul (<email address hidden>)
Branch: R2.21.x

commit 52f203ea478e4f6721b3b0016211d48b531e4c57
Author: Praveen K V <email address hidden>
Date: Fri Apr 21 15:21:31 2017 +0530

Replace tbb::task::spawn() by tbb::task::enqueue() and also support for task monitoring

Replace tbb::task::spawn() by tbb::task::enqueue(). enqueue() is more
appropriate call since task library just fires the task without calling
spawn_root_and_wait()

Also, introduced a TaskMonitor class which monitors number of tasks
enqueued to scheduler and number of tasks spawned by TBB. If the monitor
finds tasks are enqueued but not scheduled for a configured time, it
will exit the program.

Change-Id: I0db61f60c8fef5c66c6deff6b58516b293628585
Fixes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30935
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30935
Committed: http://github.com/Juniper/contrail-controller/commit/a2eb06443bcfaef5279f65a6e402fe9bc9f055b7
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit a2eb06443bcfaef5279f65a6e402fe9bc9f055b7
Author: Praveen K V <email address hidden>
Date: Thu Apr 20 19:53:48 2017 +0530

Replace tbb::task::spawn() by tbb::task::enqueue() and also support for task monitoring

Replace tbb::task::spawn() by tbb::task::enqueue(). enqueue() is more
appropriate call since task library just fires the task without calling
spawn_root_and_wait()

Also, introduced a TaskMonitor class which monitors number of tasks
enqueued to scheduler and number of tasks spawned by TBB. If the monitor
finds tasks are enqueued but not scheduled for a configured time, it
will exit the program.

Conflicts:
 src/base/task.cc
 src/base/task.h
 src/vnsw/agent/cmn/agent.cc
 src/vnsw/agent/contrail-vrouter-agent.conf
 src/vnsw/agent/init/agent_param.cc

Change-Id: Ia68d52f4aba0e79a3fe75f8c4fc248d49ab94faf
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/32311
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/32311
Committed: http://github.com/Juniper/contrail-controller/commit/6bbc77c3f84accfc3487018c696bc51d09360850
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 6bbc77c3f84accfc3487018c696bc51d09360850
Author: Praveen K V <email address hidden>
Date: Thu Apr 20 19:53:48 2017 +0530

Replace tbb::task::spawn() by tbb::task::enqueue() and also support for task monitoring

Replace tbb::task::spawn() by tbb::task::enqueue(). enqueue() is more
appropriate call since task library just fires the task without calling
spawn_root_and_wait()

Also, introduced a TaskMonitor class which monitors number of tasks
enqueued to scheduler and number of tasks spawned by TBB. If the monitor
finds tasks are enqueued but not scheduled for a configured time, it
will exit the program.

Conflicts:
 src/base/task.cc
 src/base/task.h
 src/vnsw/agent/cmn/agent.cc
 src/vnsw/agent/contrail-vrouter-agent.conf
 src/vnsw/agent/init/agent_param.cc

Conflicts:
 src/vnsw/agent/init/agent_param.cc
 src/vnsw/agent/init/agent_param.h

Change-Id: Ia68d52f4aba0e79a3fe75f8c4fc248d49ab94faf
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/32470
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/44689
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/44689
Committed: http://github.com/Juniper/contrail-controller/commit/ac4e3970603f491ef400ab0fd408cef9a080e053
Submitter: Zuul (<email address hidden>)
Branch: R3.2.3.x

commit ac4e3970603f491ef400ab0fd408cef9a080e053
Author: Praveen K V <email address hidden>
Date: Thu Apr 20 19:53:48 2017 +0530

Replace tbb::task::spawn() by tbb::task::enqueue() and also support for task monitoring

Replace tbb::task::spawn() by tbb::task::enqueue(). enqueue() is more
appropriate call since task library just fires the task without calling
spawn_root_and_wait()

Also, introduced a TaskMonitor class which monitors number of tasks
enqueued to scheduler and number of tasks spawned by TBB. If the monitor
finds tasks are enqueued but not scheduled for a configured time, it
will exit the program.

Conflicts:
 src/base/task.cc
 src/base/task.h
 src/vnsw/agent/cmn/agent.cc
 src/vnsw/agent/contrail-vrouter-agent.conf
 src/vnsw/agent/init/agent_param.cc

Change-Id: Ia68d52f4aba0e79a3fe75f8c4fc248d49ab94faf
Closes-Bug: #1684993
(cherry picked from commit a2eb06443bcfaef5279f65a6e402fe9bc9f055b7)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46324
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46325
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46326
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46327
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46328
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46339
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/46340
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47019
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47020
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47019
Submitter: Nagendra Prasath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47019
Committed: http://github.com/Juniper/contrail-packages/commit/8f588c91458040361999defe59fed426f20e815b
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 8f588c91458040361999defe59fed426f20e815b
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Oct 15 12:21:28 2018 -0700

Do not insert already sleeping tbb task back into sleeping list

During testing, it was found that tbb sleeping threads singly linked
list was corrupted and had become circular. This seemingly caused
my_slack count to get permanently stuck at -1, as the sleeping list
traversal would potentially never end.

During testing, using a specific assert, it was confirmed that duplicate
insertion did happen.

Fixed it by modifying the sleeing threads singly linked list into a
doubly linked list and then making sure that a thread if already in
the list is never prepended back as the head of the list.

https://github.com/01org/tbb/issues/86

With this change, libtbb.so.2 is provided directly from contrail-lib
package.

Change-Id: I07416601cd9be658d75309caa0917d3c61d9e427
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47020
Committed: http://github.com/Juniper/contrail-packaging/commit/fdbf604ef7d1d1a4941fb9053e1bd2a396b0d6ba
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit fdbf604ef7d1d1a4941fb9053e1bd2a396b0d6ba
Author: Vinay Mahuli <email address hidden>
Date: Tue Sep 25 05:15:35 2018 -0700

Packaging changes for updating new version of libtbb.so

libtbb.so is provided directly from contrail-lib package.

Change-Id: If8b80083f4c2ba9fd3e3bfdb247198282c482a57
Depends-On: I07416601cd9be658d75309caa0917d3c61d9e427
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/46480
Committed: http://github.com/Juniper/contrail-packages/commit/719cf4612ef8ed446b06725887012deadddd9bb4
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 719cf4612ef8ed446b06725887012deadddd9bb4
Author: Vinay Mahuli <email address hidden>
Date: Tue Sep 25 05:20:13 2018 -0700

Packaging changes for updating new version of libtbb.so

Change-Id: Id609046c5465d87deed253e4fc74e5cbeeb06256
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47313
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47314
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47315
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47316
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47317
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47318
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47319
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47317
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47316
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47319
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47318
Committed: http://github.com/Juniper/contrail-third-party/commit/43fba6a6f4e3e62705593669dd96fa3803336517
Submitter: Abhay Joshi (<email address hidden>)
Branch: R3.2

commit 43fba6a6f4e3e62705593669dd96fa3803336517
Author: Ananth Suryanarayana <email address hidden>
Date: Wed Sep 19 14:19:17 2018 -0700

Do not insert already sleeping tbb task back into sleeping list

During testing, it was found that tbb sleeping threads singly linked
list was corrupted and had become circular. This seemingly caused
my_slack count to get permanently stuck at -1, as the sleeping list
traversal would potentially never end.

During testing, using a specific assert, it was confirmed that duplicate
insertion did happen.

Fixed it by modifying the sleeing threads singly linked list into a
doubly linked list and then making sure that a thread if already in
the list is never prepended back as the head of the list.

https://github.com/01org/tbb/issues/86

Change-Id: I79bcd7192ea7c7db732b191503d0747e4b0ff229
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47319
Committed: http://github.com/Juniper/contrail-controller/commit/d3512f407a90f9df038d36e5ce8f9f4ba80f70e5
Submitter: Abhay Joshi (<email address hidden>)
Branch: R3.2

commit d3512f407a90f9df038d36e5ce8f9f4ba80f70e5
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Nov 26 11:21:41 2018 -0800

Do not insert already sleeping tbb task back into sleeping list

During testing, it was found that tbb sleeping threads singly linked
list was corrupted and had become circular. This seemingly caused
my_slack count to get permanently stuck at -1, as the sleeping list
traversal would potentially never end.

During testing, using a specific assert, it was confirmed that duplicate
insertion did happen.

Fixed it by modifying the sleeing threads singly linked list into a
doubly linked list and then making sure that a thread if already in
the list is never prepended back as the head of the list.

Also take commit db50e81685290df3da491b31e51d0c5a20c63c0f to fix build with
newer TBB.

https://github.com/01org/tbb/issues/86

Change-Id: I83a7d267d4558c02715c675db5fc08f58f1208e2
Depends-On: I79bcd7192ea7c7db732b191503d0747e4b0ff229
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47317
Committed: http://github.com/Juniper/contrail-packages/commit/285925d9dd9373a7c0af1ce82499c2b7d3ca96f3
Submitter: Abhay Joshi (<email address hidden>)
Branch: R3.2

commit 285925d9dd9373a7c0af1ce82499c2b7d3ca96f3
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Oct 15 12:21:28 2018 -0700

Do not insert already sleeping tbb task back into sleeping list

During testing, it was found that tbb sleeping threads singly linked
list was corrupted and had become circular. This seemingly caused
my_slack count to get permanently stuck at -1, as the sleeping list
traversal would potentially never end.

During testing, using a specific assert, it was confirmed that duplicate
insertion did happen.

Fixed it by modifying the sleeing threads singly linked list into a
doubly linked list and then making sure that a thread if already in
the list is never prepended back as the head of the list.

https://github.com/01org/tbb/issues/86

With this change, libtbb.so.2 is provided directly from contrail-lib
package.

Change-Id: I4b911de240544143ad1833641ffe640155a34648
Depends-On: I83a7d267d4558c02715c675db5fc08f58f1208e2
Closes-Bug: #1684993

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47316
Committed: http://github.com/Juniper/contrail-packaging/commit/81bae27085005547a342abe5cd56c349c10251a9
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 81bae27085005547a342abe5cd56c349c10251a9
Author: Ananth Suryanarayana <email address hidden>
Date: Sat Oct 27 14:03:51 2018 -0700

Packaging changes for updating new version of libtbb.so

libtbb.so is provided directly from contrail-lib package.

Change-Id: Icabca843a86708db6beb39943eb09bda9c684f1a
Depends-On: I4b911de240544143ad1833641ffe640155a34648
Closes-Bug: #1684993