DM config not being pushed, Exception "global name '_cast' is not defined" seen

[Vedamurthy Joshi]

3.2 Build 3

A bgp-router and physical-router was added for an MX(name: umesh, IP 7.7.7.78)
The junos config was not pushed by DM.
Contrail-device-manager.log had these exceptions. There is very little info in introspect as well

11/17/2016 12:16:43 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 12:07:28 PM [DeviceManager]: RabbitMQ connection down
11/22/2016 12:07:29 PM [DeviceManager]: RabbitMQ connection ESTABLISHED <Connection: amqp://guest:**@192.168.192.50:5672// at 0x7f05aebe2ed0>
11/22/2016 12:32:14 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 12:32:15 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 12:43:34 PM [DeviceManager]: Exception: global name '_cast' is not defined

11/22/2016 03:55:02 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 03:55:04 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 03:55:12 PM [DeviceManager]: Exception: global name '_cast' is not defined
11/22/2016 03:55:13 PM [DeviceManager]: Exception: global name '_cast' is not defined

----------
testbed :

host1 = 'root@10.204.217.194'
host2 = 'root@10.204.217.197'
host3 = 'root@10.204.217.198'
host4 = 'root@10.204.217.113'
host5 = 'root@10.204.217.114'
host6 = 'root@10.204.217.115'
host7 = 'root@10.204.217.76'

kvm_node1 = '10.204.217.145'

ext_routers = [('umesh','7.7.7.78')]
router_asn = 64512
public_vn_rtgt = 2223
public_vn_subnet = '10.204.221.176/28'

host_build = 'stack@10.204.216.49'

env.roledefs = {
    'all': [host1, host2, host3, host4, host5, host6, host7],
    'cfgm': [host1, host2, host3],
    'openstack': [host1, host2, host3],
    'webui': [host2],
    'control': [host1, host2, host3],
    'compute': [host4, host5, host6, host7],
    'collector': [host1, host2, host3],
    'database': [host1, host2, host3],
    'build': [host_build],
    'toragent': [host5, host6],
    'tsn': [host5, host6],
}

env.hostnames = {
    'all': ['testbed-1-vm1', 'testbed-1-vm2', 'testbed-1-vm3', 'nodei1', 'nodei2', 'nodei3', 'nodeg36']
}
control_data = {
    host1 : { 'ip': '192.168.192.60/24', 'gw' : '192.168.192.254', 'device':'eth1' },
    host2 : { 'ip': '192.168.192.50/24', 'gw' : '192.168.192.254', 'device':'eth1' },
    host3 : { 'ip': '192.168.192.40/24', 'gw' : '192.168.192.254', 'device':'eth1' },
    host4 : { 'ip': '192.168.192.1/24', 'gw' : '192.168.192.254', 'device':'p6p2' , 'vlan': '128'},
    host5 : { 'ip': '192.168.192.2/24', 'gw' : '192.168.192.254', 'device':'p6p2' ,'vlan': '128'},
    host6 : { 'ip': '192.168.192.3/24', 'gw' : '192.168.192.254', 'device':'p6p2' ,'vlan': '128'},
    host7 : { 'ip': '192.168.192.7/24', 'gw' : '192.168.192.254', 'device':'p1p2' },
}

env.ha = {
    'internal_vip' : '192.168.192.251',
    'contrail_internal_vip' : '192.168.192.251',
}

[Suresh Balineni (sbalineni)]

This issue was already fixed in mainline - https://review.opencontrail.org/#/c/25397/

Back porting to 3.2 with this review: https://review.opencontrail.org/#/c/26426/

[Suresh Balineni (sbalineni)]

Fixed with https://review.opencontrail.org/#/c/26426/

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26910
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26910
Committed: http://github.org/Juniper/contrail-controller/commit/524fa468477ce955217dec6a062e5384579d461c
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 524fa468477ce955217dec6a062e5384579d461c
Author: sbalineni <email address hidden>
Date: Tue Dec 6 15:47:05 2016 -0800

[DM]: _cast is renamed as cast_

generated code will have references to cast_, must be renamed as cast_

this change was missed to commit in R3.2

Change-Id: I751bf0f90f4047ba1d79c62283ed95a8d42e3fa7
Closes-Bug: #1643835