Configurable hashing for ECMP doesnt work (R3.2)

Bug #1616814 reported by Hari Prasad Killi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.2
Fix Committed
High
jayaramsatya
Trunk
Fix Committed
High
jayaramsatya

Bug Description

With the change to https://bugs.launchpad.net/juniperopenstack/+bug/1573265 committed in mainline, configurable hashing configured for destination ECMP does not work. The hash fields to be used are not currently programmed to the vrouter in this case and vrouter uses all the hash fields to identify destination.

Tags: vrouter
summary: - Configurable hashing for ECMP doesnt work when policy is disabled
+ Configurable hashing for ECMP doesnt work
description: updated
summary: - Configurable hashing for ECMP doesnt work
+ Configurable hashing for ECMP doesnt work (R3.2)
Changed in juniperopenstack:
importance: Medium → High
Changed in juniperopenstack:
assignee: Manish Singh (manishs) → jayaramsatya (jayaramsatya)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23922
Submitter: Divakar Dharanalakota (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/23922
Committed: http://github.org/Juniper/contrail-vrouter/commit/ec473ebecd13b8f4d5a7fcf5882e815069fde89c
Submitter: Zuul
Branch: master

commit ec473ebecd13b8f4d5a7fcf5882e815069fde89c
Author: Divakar <email address hidden>
Date: Tue Sep 6 12:23:14 2016 +0530

Support for Ecmp configured hash in Vrouter

The hash parameters that are required to calculate hash value to chose
the Ecmp candidate NH are placed in Ecmp composite nexthop. After the
flow key is formed, using the configured bit fields, flow key values are
reset to zero if they are not required. Hash is calculated after
resetting the required fields.

partial-bug: #1616814

Change-Id: If674a35c07782ca227394a901760840dde5b9359

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24385
Submitter: Divakar Dharanalakota (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24385
Committed: http://github.org/Juniper/contrail-vrouter/commit/8131d45ca2673c2b98d0b3b4158efd584d32a2b3
Submitter: Zuul
Branch: master

commit 8131d45ca2673c2b98d0b3b4158efd584d32a2b3
Author: Divakar D <email address hidden>
Date: Thu Sep 22 22:50:40 2016 +0530

Handling the case of not configuring "Ecmp configurable hash"

The previous changes for configurable hash support in Vrouter
(https://review.opencontrail.org/#/c/23922/) has an issue where
if the configurable hash is not configiured, flow key would be
chosen as NULL. As a fix, in no configirable hash is present in
Ecmp NH addition all keys are added.

Change-Id: Id904b25a17c69d931065f25f544e923757187774
partial-bug: #1616814

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24403
Submitter: jayaramsatya (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24403
Committed: http://github.org/Juniper/contrail-controller/commit/2748209bb052625775cf7b55b1cd09321a0cbe56
Submitter: Zuul
Branch: master

commit 2748209bb052625775cf7b55b1cd09321a0cbe56
Author: jayaramsatya <email address hidden>
Date: Wed Oct 5 13:24:07 2016 +0530

Support for Ecmp configured hash in Agent

Ecmp hash fields are consolidated after going through all the routes
pointing to ECMP Nexthop.
The fields are selected based on most common fields pointing to ECMP
Next hop by all the routes.
After selecting the fields same will be used for configuring the
Vrouter.

Change-Id: I47092af68e95dd8491c0f8ac511c85971de945f7
partial-bug: #1616814

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/25275
Submitter: jayaramsatya (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/25275
Committed: http://github.org/Juniper/contrail-controller/commit/3b3d6b4c487fb80a4fe0a9b94c7139702eb05cba
Submitter: Zuul
Branch: R3.2

commit 3b3d6b4c487fb80a4fe0a9b94c7139702eb05cba
Author: jayaramsatya <email address hidden>
Date: Wed Oct 5 13:24:07 2016 +0530

Support for Ecmp configured hash in Agent

Ecmp hash fields are consolidated after going through all the routes
pointing to ECMP Nexthop.
The fields are selected based on most common fields pointing to ECMP
Next hop by all the routes.
After selecting the fields same will be used for configuring the
Vrouter.

Change-Id: I47092af68e95dd8491c0f8ac511c85971de945f7
partial-bug: #1616814

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.