Contrail-vrouter failed to build on kernel >= 4.6

Bug #1633387 reported by Sergey Matov
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.1
In Progress
High
Sivakumar Ganapathy
R3.2
New
High
Sivakumar Ganapathy
R4.0
Invalid
High
Jeba Paulaiyan
R4.1
Fix Committed
High
Sivakumar Ganapathy
R5.0
Fix Committed
High
Jeba Paulaiyan
Trunk
Fix Committed
High
Jeba Paulaiyan

Bug Description

On Ubuntu system with kernel >= 4.6 vrouter failed to build

System: Ubuntu
Kernel: 4.6
Gcc: 5
Component: Contrail-vrouter

Command: scons --opt=production --optimization=production

Expected result:
      scons: done building targets

Actual result:

gcc -o build/production/vrouter/dp-core/vr_buildinfo.o -c -g -O3 -Ivrouter/include -Ibuild/production/vrouter/sandesh/gen-c -Ivrouter/sandesh/gen-c -Itools -Itools/sandesh/library/c vrouter/dp-core/vr_buildinfo.c
ar rc build/production/vrouter/dp-core/libdp_core.a build/production/vrouter/dp-core/vr_bitmap.o build/production/vrouter/dp-core/vr_bridge.o build/production/vrouter/dp-core/vr_btable.o build/production/vrouter/dp-core/vr_buildinfo.o build/production/vrouter/dp-core/vr_datapath.o build/production/vrouter/dp-core/vr_flow.o build/production/vrouter/dp-core/vr_fragment.o build/production/vrouter/dp-core/vr_htable.o build/production/vrouter/dp-core/vr_index_table.o build/production/vrouter/dp-core/vr_interface.o build/production/vrouter/dp-core/vr_ip_mtrie.o build/production/vrouter/dp-core/vr_message.o build/production/vrouter/dp-core/vr_mirror.o build/production/vrouter/dp-core/vr_mpls.o build/production/vrouter/dp-core/vr_nexthop.o build/production/vrouter/dp-core/vr_packet.o build/production/vrouter/dp-core/vr_proto_ip.o build/production/vrouter/dp-core/vr_proto_ip6.o build/production/vrouter/dp-core/vr_qos.o build/production/vrouter/dp-core/vr_queue.o build/production/vrouter/dp-core/vr_response.o build/production/vrouter/dp-core/vr_route.o build/production/vrouter/dp-core/vr_sandesh.o build/production/vrouter/dp-core/vr_stats.o build/production/vrouter/dp-core/vr_vif_bridge.o build/production/vrouter/dp-core/vr_vrf_assign.o build/production/vrouter/dp-core/vr_vxlan.o build/production/vrouter/dp-core/vrouter.o
ranlib build/production/vrouter/dp-core/libdp_core.a
gcc -o build/production/vrouter/uvrouter/uvrouter -g build/production/vrouter/uvrouter/uvrouter.o -Lbuild/lib -Lbuild/production/vrouter/host -Lvrouter/host -Lbuild/production/vrouter/sandesh -Lvrouter/sandesh -Lbuild/production/vrouter/dp-core -Lvrouter/dp-core -lvrouter -ldp_core -ldp_sandesh_c -ldp_core -lsandesh-c
cd /home/engineer/build-contrail/vrouter/ && make KERNELDIR=/lib/modules/4.6.0-040600-generic/build SANDESH_HEADER_PATH=/home/engineer/build-contrail/build/production/vrouter SANDESH_SRC_ROOT=../build/kbuild/ SANDESH_EXTRA_HEADER_PATH=/home/engineer/build-contrail/tools
make -C /lib/modules/4.6.0-040600-generic/build M=/home/engineer/build-contrail/vrouter modules
make[1]: Entering directory '/usr/src/linux-headers-4.6.0-040600-generic'
  CC [M] /home/engineer/build-contrail/vrouter/linux/vr_host_interface.o
/home/engineer/build-contrail/vrouter/linux/vr_host_interface.c: In function ‘linux_if_get_settings’:
/home/engineer/build-contrail/vrouter/linux/vr_host_interface.c:1587:21: error: implicit declaration of function ‘__ethtool_get_settings’ [-Werror=implicit-function-declaration]
         if (!(ret = __ethtool_get_settings(dev, &cmd))) {
                     ^

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24897
Submitter: Sergey Matov (<email address hidden>)

Sergey Matov (smatov)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24897
Committed: http://github.org/Juniper/contrail-vrouter/commit/5e1713310ddb45ce1622b7a91b43fb64caaed926
Submitter: Zuul
Branch: master

commit 5e1713310ddb45ce1622b7a91b43fb64caaed926
Author: Sergey Matov <email address hidden>
Date: Fri Oct 14 11:32:26 2016 +0200

Added support for kernel 4.6

For 4.6 kernel several ethtool API functions has been removed.
If vrouter is building for 4.6 new API should be used instead.

Close-bug: #1633387

Change-Id: Ibb83f611616cba952b1ba7da4e548fccd55d0037

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/24969
Submitter: Jakub Pavlik (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24969
Committed: http://github.org/Juniper/contrail-vrouter/commit/1117bb82cc88048ee3b61509a477ec72a626babf
Submitter: Zuul
Branch: R3.1

commit 1117bb82cc88048ee3b61509a477ec72a626babf
Author: Sergey Matov <email address hidden>
Date: Fri Oct 14 11:32:26 2016 +0200

Added support for kernel 4.6

For 4.6 kernel several ethtool API functions has been removed.
If vrouter is building for 4.6 new API should be used instead.

Close-bug: #1633387

Change-Id: Ibb83f611616cba952b1ba7da4e548fccd55d0037

Jeba Paulaiyan (jebap)
tags: added: vrouter
Revision history for this message
Antoine Eiche (lewo-c) wrote :

I have some other compile errors with kernel >=4.6 (kernel 4.9.49) and it is strange you didn't get them...

First, skb_sender_cpu_clear has been removed in kernel 4.6:
make[1]: Entering directory '/nix/store/8isavlq67qrhd9xqb672h4p4waymyj24-linux-4.9.49-dev/lib/modules/4.9.49/build'
  CC [M] /tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vrouter_mod.o
  CC [M] /tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_host_interface.o
/tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_host_interface.c: In function ‘linux_if_tx’:
/tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_host_interface.c:819:5: error: implicit declaration of function ‘skb_sender_cpu_clear’ [-Werror=implicit-function-declaration]
     skb_sender_cpu_clear(skb);
     ^

Later, I also have some errors in vr_mem.c:
/tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_mem.c:132:14: error: too many arguments to function ‘get_user_pages’
     spages = get_user_pages(current, current->mm, uspace_vmem,
              ^
In file included from /tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_mem.c:12:0:
/nix/store/8isavlq67qrhd9xqb672h4p4waymyj24-linux-4.9.49-dev/lib/modules/4.9.49/source/include/linux/mm.h:1280:6: note: declared here
 long get_user_pages(unsigned long start, unsigned long nr_pages,
      ^
/tmp/nix-build-contrail-vrouter-linux-4.9.49.drv-0/contrail-workspace/vrouter/linux/vr_mem.c:144:13: error: implicit declaration of function ‘page_cache_release’ [-Werror=implicit-function-declaration]
             page_cache_release(pmem[i]);
             ^
cc1: some warnings being treated as errors

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38139
Submitter: Antoine Eiche (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38139
Committed: http://github.com/Juniper/contrail-vrouter/commit/a0d6eb08e9acb55f000a666b21ad6324fe50acc9
Submitter: Zuul (<email address hidden>)
Branch: master

commit a0d6eb08e9acb55f000a666b21ad6324fe50acc9
Author: Antoine Eiche <email address hidden>
Date: Tue Dec 5 17:31:03 2017 +0100

Fix build for kernels >= 4.9

- skb_sender_cpu_clear has been removed in kernel 4.6 [1] and is no longer
required since 4.5 [2].

- get_user_page signature has changed in 4.6 [3] and in 4.9 [4]. Since I
don't have a 4.6 kernel for testing, I didn't add code to support it.

- The macro page_cache_release has been finally removed [5].

[1] https://github.com/torvalds/linux/commit/64d4e3431e686dc37ce388ba531c4c4e866fb141
[2] https://github.com/torvalds/linux/commit/52bd2d62ce6758d811edcbd2256eb9ea7f6a56cb
[3] https://github.com/torvalds/linux/commit/c12d2da56d0e07d230968ee2305aaa86b93a6832
[4] https://github.com/torvalds/linux/commit/768ae309a96103ed02eb1e111e838c87854d8b51
[5] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a

Change-Id: I569ca66145204f6e71a1083412bf2cb4caab818d
Partial-Bug: #1633387

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39029
Submitter: Sergey Matov (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/41400
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/41434
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39029
Submitter: Sergey Matov (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/41434
Committed: http://github.com/Juniper/contrail-vrouter/commit/1dacc5c15788bce3b8f889e7ecbf256d4b661e49
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 1dacc5c15788bce3b8f889e7ecbf256d4b661e49
Author: Antoine Eiche <email address hidden>
Date: Tue Dec 5 17:31:03 2017 +0100

Fix build for kernels >= 4.9

- skb_sender_cpu_clear has been removed in kernel 4.6 [1] and is no longer
required since 4.5 [2].

- get_user_page signature has changed in 4.6 [3] and in 4.9 [4]. Since I
don't have a 4.6 kernel for testing, I didn't add code to support it.

- The macro page_cache_release has been finally removed [5].

[1] https://github.com/torvalds/linux/commit/64d4e3431e686dc37ce388ba531c4c4e866fb141
[2] https://github.com/torvalds/linux/commit/52bd2d62ce6758d811edcbd2256eb9ea7f6a56cb
[3] https://github.com/torvalds/linux/commit/c12d2da56d0e07d230968ee2305aaa86b93a6832
[4] https://github.com/torvalds/linux/commit/768ae309a96103ed02eb1e111e838c87854d8b51
[5] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a

Change-Id: I569ca66145204f6e71a1083412bf2cb4caab818d
Partial-Bug: #1633387
(cherry picked from commit a0d6eb08e9acb55f000a666b21ad6324fe50acc9)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41400
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/41400
Committed: http://github.com/Juniper/contrail-common/commit/80002037bb5a7f7411a081ccbb4137589e21470c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 80002037bb5a7f7411a081ccbb4137589e21470c
Author: Michal Skalski <email address hidden>
Date: Wed Apr 4 17:50:08 2018 +0200

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Partial-Bug: #1633387
Change-Id: If82ad77cd6f41a343879e234143b2cc535900a33

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39029
Committed: http://github.com/Juniper/contrail-vrouter/commit/60c903128ddee5737e0fd8bb34fc6f03cc043426
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 60c903128ddee5737e0fd8bb34fc6f03cc043426
Author: Sergey Matov <email address hidden>
Date: Fri Jan 19 10:46:59 2018 +0400

Fix vrouter build for kernels from 4.11 to 4.13

- linux/vhost_dev.c:
Rename netdev destructor to priv_destructor due to API change.
New signature of rtnl_link_ops.validate due to API change.
- linux/vr_mem.c
Remove vma from mem_fault function since VMA pointer now accessable
via VMF structure.

Change-Id: I9ffc103e5e69649d2a691c7a378cfd12b2363320
Partial-Bug: #1633387

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42055
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/42056
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42057
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/42060
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42055
Committed: http://github.com/Juniper/contrail-vrouter/commit/a57b970323225c40535829b8209bc86b008023ae
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit a57b970323225c40535829b8209bc86b008023ae
Author: Sergey Matov <email address hidden>
Date: Fri Jan 19 10:46:59 2018 +0400

Fix vrouter build for kernels from 4.11 to 4.13

- linux/vhost_dev.c:
Rename netdev destructor to priv_destructor due to API change.
New signature of rtnl_link_ops.validate due to API change.
- linux/vr_mem.c
Remove vma from mem_fault function since VMA pointer now accessable
via VMF structure.

Change-Id: I9ffc103e5e69649d2a691c7a378cfd12b2363320
Partial-Bug: #1633387
(cherry picked from commit 60c903128ddee5737e0fd8bb34fc6f03cc043426)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42060
Committed: http://github.com/Juniper/contrail-sandesh/commit/9ac5d237cc456089facab2176a6a6605fc8dddf8
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 9ac5d237cc456089facab2176a6a6605fc8dddf8
Author: Hari Prasad Killi <email address hidden>
Date: Wed Apr 18 11:45:38 2018 +0530

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Partial-Bug: #1633387
Change-Id: If82ad77cd6f41a343879e234143b2cc535900a33
(cherry picked from commit 80002037bb5a7f7411a081ccbb4137589e21470c)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42056
Committed: http://github.com/Juniper/contrail-vrouter/commit/1f45fb3cca43c35948ec46178b841c21d48cbcb2
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 1f45fb3cca43c35948ec46178b841c21d48cbcb2
Author: Sergey Matov <email address hidden>
Date: Fri Jan 19 10:46:59 2018 +0400

Fix vrouter build for kernels from 4.11 to 4.13

- linux/vhost_dev.c:
Rename netdev destructor to priv_destructor due to API change.
New signature of rtnl_link_ops.validate due to API change.
- linux/vr_mem.c
Remove vma from mem_fault function since VMA pointer now accessable
via VMF structure.

Change-Id: I9ffc103e5e69649d2a691c7a378cfd12b2363320
Partial-Bug: #1633387
(cherry picked from commit 60c903128ddee5737e0fd8bb34fc6f03cc043426)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42057
Committed: http://github.com/Juniper/contrail-common/commit/70d93eb4858f896d03e581209992467246de59ea
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 70d93eb4858f896d03e581209992467246de59ea
Author: Michal Skalski <email address hidden>
Date: Wed Apr 4 17:50:08 2018 +0200

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Partial-Bug: #1633387
Change-Id: If82ad77cd6f41a343879e234143b2cc535900a33
(cherry picked from commit 80002037bb5a7f7411a081ccbb4137589e21470c)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42411
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42412
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42412
Committed: http://github.com/Juniper/contrail-common/commit/e7c95d744a5e59757ead5547b0eb8278c4915b8a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit e7c95d744a5e59757ead5547b0eb8278c4915b8a
Author: Michal Skalski <email address hidden>
Date: Mon Apr 23 07:21:40 2018 -0800

Revert "WIP: remove conflict with linux uuid_t type"
This commit has to be reverted and reworked. It did not take in to
account all references of uuid_t type.

Partial-Bug: #1633387

This reverts commit 70d93eb4858f896d03e581209992467246de59ea.

Change-Id: I4f0e2f8a79e9163ba887007affc93aaa03f8b14b

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42411
Committed: http://github.com/Juniper/contrail-common/commit/c5d44462391628ea6b3d81efba377a3ddf8feb3b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c5d44462391628ea6b3d81efba377a3ddf8feb3b
Author: Michal Skalski <email address hidden>
Date: Mon Apr 23 07:15:59 2018 -0800

Revert "WIP: remove conflict with linux uuid_t type"
This commit has to be reverted and reworked. It did not take in to
account all references of uuid_t type.

Partial-Bug: #1633387

This reverts commit 80002037bb5a7f7411a081ccbb4137589e21470c.

Change-Id: I96cc3aa89bf4e42a6b6f128cf89f955d8a647cc8

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42453
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42454
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/42456
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42454
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42453
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42454
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42453
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/42456
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42454
Committed: http://github.com/Juniper/contrail-controller/commit/9643e39f2fc6607ab58ce649cf50ae82cad6c781
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: master

commit 9643e39f2fc6607ab58ce649cf50ae82cad6c781
Author: Michal Skalski <email address hidden>
Date: Tue Apr 24 11:19:36 2018 +0200

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.
There is a corresponding change in contrail-common project.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3
Partial-Bug: #1633387

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42453
Committed: http://github.com/Juniper/contrail-common/commit/a090eb770df69348c49e826892ab556d5f72eede
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: master

commit a090eb770df69348c49e826892ab556d5f72eede
Author: Michal Skalski <email address hidden>
Date: Wed Apr 4 17:50:08 2018 +0200

Remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: I1e469eb8074229e51bdd4807d80fef81023eb6e2
Partial-Bug: #1633387
Depends-On: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/42799
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42802
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42799
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42456
Committed: http://github.com/Juniper/contrail-sandesh/commit/21aec6f33e07cc74f6b1e2535a9a5013d8a7f47c
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 21aec6f33e07cc74f6b1e2535a9a5013d8a7f47c
Author: Michal Skalski <email address hidden>
Date: Tue Apr 24 01:49:13 2018 -0800

Revert "WIP: remove conflict with linux uuid_t type"
This commit has to be reverted and reworked. It did not take in to
account all references of uuid_t type.

Partial-Bug: #1633387

This reverts commit 9ac5d237cc456089facab2176a6a6605fc8dddf8.

Change-Id: I464deb4b4b5c5d3862e3f3854f5792685fe2010a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42802
Committed: http://github.com/Juniper/contrail-controller/commit/95fc69635d068eea0ae13dd691fd365b833fef8e
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R4.1

commit 95fc69635d068eea0ae13dd691fd365b833fef8e
Author: Michal Skalski <email address hidden>
Date: Tue Apr 24 11:19:36 2018 +0200

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.
There is a corresponding change in contrail-common project.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3
Partial-Bug: #1633387
(cherry picked from commit 9643e39f2fc6607ab58ce649cf50ae82cad6c781)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42799
Committed: http://github.com/Juniper/contrail-sandesh/commit/fac7cdc347c9be0f8694befa10e0ac1f7169ddd5
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R4.1

commit fac7cdc347c9be0f8694befa10e0ac1f7169ddd5
Author: Michal Skalski <email address hidden>
Date: Mon May 7 12:22:44 2018 +0200

Remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: Id4fee994d2c239e11880616c9b30043bf024702b
Partial-Bug: #1633387
Depends-On: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3

Revision history for this message
Sivakumar Ganapathy (hotlava51) wrote :

Summary of discussions with Jeba

=======

1633387 – W.r.t. Ubuntu, we need to make sure vrouter.ko is DKMS compatible against any kernel. When 4.x kernel came to market long back, we observed that vrouter does not DKMS compile against that kernel and the bug was filed. However at that time our customers were in 3.x kernels. Recently there are use-cases forced us to fix this and as per my understanding, this is fixed by the commits made already. We will keep it in 5.0.2 scope and close it after assessing all use-case. Mainly AWS, Azure, GCP, vR-vR encryption needs latest kernels.

========

Revision history for this message
Siva Gurumurthy (sgurumurthy) wrote : Re: 5.0.1 blocker

+ The correct Siva

From: Rudra Rugge <email address hidden>
Date: Monday, August 6, 2018 at 4:25 PM
To: Ashok Singh R <email address hidden>
Cc: Sivakumar Gurumurthy <email address hidden>
Subject: 5.0.1 blocker

Please send update:

HIGH
IN PROGRESS
#1762452 fat flow enhancements - define exception for vrouter packets<https://bugs.launchpad.net/juniperopenstack/r5.0/+bug/1762452>
Juniper Openstack r5.0 Assignee: Ashok Singh Reporter: richard roberts6

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/45425
Submitter: <email address hidden> (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45426
Submitter: <email address hidden> (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45531
Submitter: Jeya ganesh babu (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45532
Submitter: Jeya ganesh babu (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45680
Submitter: Michal Skalski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/46519
Submitter: Sergey Kreys (<email address hidden>)

Revision history for this message
Vinay Mahuli (vmahuli) wrote :

Reviewed: https://review.opencontrail.org/24897
Committed: https://github.com/Juniper/contrail-vrouter/commit/5e1713310ddb45ce1622b7a91b43fb64caaed926
Submitter: Zuul
Branch: master

commit 5e1713310ddb45ce1622b7a91b43fb64caaed926
Author: Sergey Matov <email address hidden>
Date: Fri Oct 14 11:32:26 2016 +0200

Added support for kernel 4.6

For 4.6 kernel several ethtool API functions has been removed.
If vrouter is building for 4.6 new API should be used instead.

Close-bug: #1633387

Change-Id: Ibb83f611616cba952b1ba7da4e548fccd55d0037

Jeba Paulaiyan (jebap)
tags: added: blocker
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/45532
Submitter: Jeya ganesh babu (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45532
Committed: http://github.com/Juniper/contrail-sandesh/commit/cd779c577b814882ae688a5a9c0854cfaa851f27
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit cd779c577b814882ae688a5a9c0854cfaa851f27
Author: Jeya ganesh babu J <email address hidden>
Date: Mon Aug 13 12:25:45 2018 -0700

Remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Partial-Bug: #1633387

Change-Id: Ibe72effc72a7579b00f7d147d9fb814b4c7ee7a3

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/47046
Submitter: Jeya ganesh babu (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45426
Committed: http://github.com/Juniper/contrail-controller/commit/d466b4d9e6288e02a674975ea3b5affdf15b6d75
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R5.0

commit d466b4d9e6288e02a674975ea3b5affdf15b6d75
Author: Michal Skalski <email address hidden>
Date: Tue Apr 24 11:19:36 2018 +0200

WIP: remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.
There is a corresponding change in contrail-common project.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3
Partial-Bug: #1633387
(cherry picked from commit 9643e39f2fc6607ab58ce649cf50ae82cad6c781)
(cherry picked from commit 95fc69635d068eea0ae13dd691fd365b833fef8e)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/45680
Committed: http://github.com/Juniper/contrail-common/commit/452c7622d03e4dbb1de5c001615e983b4d370c0c
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R5.0

commit 452c7622d03e4dbb1de5c001615e983b4d370c0c
Author: Michal Skalski <email address hidden>
Date: Wed Apr 4 17:50:08 2018 +0200

Remove conflict with linux uuid_t type

Since this change [1] compilation of vrouter module will fail with
message that uuid_t is already defined.

[1]
https://github.com/torvalds/linux/commit/f9727a17db9bab71ddae91f74f11a8a2f9a0ece6

Change-Id: I1e469eb8074229e51bdd4807d80fef81023eb6e2
Partial-Bug: #1633387
Depends-On: I0d6449d9c81f04a1876d5d6b0a0bc3ff1da4e7e3
(cherry picked from commit a090eb770df69348c49e826892ab556d5f72eede)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/48817
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/48847
Submitter: Saurabh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/48851
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/48851
Committed: http://github.com/Juniper/contrail-sandesh/commit/7489c5eab9c76311abe356d4babdbcade6055067
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 7489c5eab9c76311abe356d4babdbcade6055067
Author: Sundaresan Rajangam <email address hidden>
Date: Wed Nov 9 12:26:40 2016 -0800

Fix sandesh compilation error in ubuntu 16.04

Closes-Bug: #1638636

Fixing ubuntu1604 build break due to tbb mutex not being copyable or clonable.
Closes-Bug: 1670880

Remove conflict with linux uuid_t type
Partial-Bug: 1633387

Optimize sandesh C generated code
Remove thrift_protocol and thrift_transport layers and directly
copy to/from buffer and structures in generated code for read
and write. This results in 10 times improvement in binary encode
and decode.
Closes-Bug: 1604700

Change-Id: Id2ee27b8d8b8ad2c0b6b31245eeb6b92ce7e4a16

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/48847
Committed: http://github.com/Juniper/contrail-vrouter/commit/436c78db6872aa9c4d682004ef445f73cbd15129
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 436c78db6872aa9c4d682004ef445f73cbd15129
Author: Kiran KN <email address hidden>
Date: Wed Nov 9 11:38:22 2016 -0800

Changes to support Ubuntu 16.04 v4.15 kernel.

DPDK: Ubuntu 16.04 compilation fix

Partial-Bug: 1638643

Changes to make vrouter code compile against linux kernel v4.15. Timer_list
structure has changed in 4.15 releases. Also some changes introduced to
vr_host_interface.c, removing NETIF_F_UFO reference for v4.15.

closes-bug: #1765229

Fix vrouter build for kernels from 4.11 to 4.13

- linux/vhost_dev.c:
Rename netdev destructor to priv_destructor due to API change.
New signature of rtnl_link_ops.validate due to API change.
- linux/vr_mem.c
Remove vma from mem_fault function since VMA pointer now accessable
via VMF structure.

Partial-Bug: #1633387
(cherry picked from commit 60c903128ddee5737e0fd8bb34fc6f03cc043426)

Modify generic netlink family registration for kernel 4.10 support
Closes-bug: #1696745

Fix netlink family registration for kernel 4.10

When we call genl_register_family with "ops" field provided,
we need to provide "n_ops" field as well.

Closes-bug: #1696745

Register information about multicast group

Pass to vrouter module information about multicast group. Withouth that
user space client (vif) was unable to join vrouter netlink broadcast group
when kernel 4.10 or higher was used.

Closes-Bug: #1771999

Change-Id: I7d01633fca50a3c76ce1ea9d9233623e4a2abd45
Closes Jira Bug:JCB-218796

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers