R3.1 build17: setup-vnc-collector fails if cfgm and collector are not on same nodes

[Sudheendra Rao]

On R3.1 build17, the setup-vnc-collector fails with the following error if cfgm and collector are on different nodes. It works fine if these two roles are on same nodes.

setup details:

Config Nodes : [u'nodea35', u'nodea34']
Control Nodes : [u'nodea35', u'nodea34', u'nodec53']
Compute Nodes : [u'nodec54', u'nodec55', u'nodec56']
Openstack Node : nodea34
WebUI Node : nodec53
Analytics Nodes : [u'nodea35', u'nodec53'] <<<< analytics not same as that of cfgm.

Provision logs:

2016-08-07 22:26:41:998035: [root@10.204.217.93] out: [localhost] local: contrail-config --set /etc/contrail/contrail-topology.conf DISCOVERY disc_server_port '5998'
2016-08-07 22:26:42:029671: [root@10.204.217.93] out: [localhost] local: contrail-config --set /etc/contrail/supervisord_analytics_files/contrail-topology.ini program:contrail-topology command '/usr/bin/contrail-topology --conf_file /etc/contrail/contrail-topology.conf --conf_file /etc/contrail/contrail-keystone-auth.conf'
2016-08-07 22:26:42:045337: [root@10.204.217.93] out: [localhost] local: sudo mv /tmp/tmpfK5uXm/contrail-analytics-nodemgr.conf /etc/contrail/contrail-analytics-nodemgr.conf
2016-08-07 22:26:42:077117: [root@10.204.217.93] out: Traceback (most recent call last):
2016-08-07 22:26:42:077315: [root@10.204.217.93] out: File "/usr/bin/setup-vnc-collector", line 9, in <module>
2016-08-07 22:26:42:077412: [root@10.204.217.93] out: load_entry_point('ContrailProvisioning==0.1dev', 'console_scripts', 'setup-vnc-collector')()
2016-08-07 22:26:42:077505: [root@10.204.217.93] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/collector/setup.py", line 374, in main
2016-08-07 22:26:42:077596: [root@10.204.217.93] out: collector.setup()
2016-08-07 22:26:42:109944: [root@10.204.217.93] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/common/base.py", line 338, in setup
2016-08-07 22:26:42:110273: [root@10.204.217.93] out: self.fixup_config_files()
2016-08-07 22:26:42:141935: [root@10.204.217.93] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/collector/setup.py", line 111, in fixup_config_files
2016-08-07 22:26:42:142127: [root@10.204.217.93] out: self.fixup_keystone_auth_config_file(False)
2016-08-07 22:26:42:142300: [root@10.204.217.93] out: File "/usr/local/lib/python2.7/dist-packages/contrail_provisioning/common/base.py", line 297, in fixup_keystone_auth_config_file
2016-08-07 22:26:42:142406: [root@10.204.217.93] out: '__keystone_cert_file_opt__': self._args.keystone_certfile or '',
2016-08-07 22:26:42:142524: [root@10.204.217.93] out: AttributeError: 'Namespace' object has no attribute 'keystone_certfile'
2016-08-07 22:26:42:142615: [root@10.204.217.93] out:
2016-08-07 22:26:42:150179:

2016-08-07 22:26:42:179274: Fatal error: sudo() received nonzero return code 1 while executing!
2016-08-07 22:26:42:179274:
2016-08-07 22:26:42:179274: Requested: setup-vnc-collector --cassandra_ip_list 22.22.22.53 22.22.22.35 22.22.22.34 --zookeeper_ip_list 22.22.22.53 22.22.22.35 22.22.22.34 --amqp_ip_list 22.22.22.35 22.22.22.34 --amqp_port 5672 --cfgm_ip 22.22.22.35 --self_collector_ip 22.22.22.53 --num_nodes 2 --analytics_syslog_port 19876 --kafka_enabled True --keystone_ip 22.22.22.34 --keystone_version v2.0 --keystone_admin_user admin --keystone_admin_passwd contrail123 --keystone_admin_tenant_name admin --keystone_auth_protocol http --keystone_auth_port 35357 --keystone_insecure True --aaa_mode cloud-admin
2016-08-07 22:26:42:179274: Executed: sudo -S -p 'sudo password:' /bin/bash -l -c "cd /opt/contrail/bin && setup-vnc-collector --cassandra_ip_list 22.22.22.53 22.22.22.35 22.22.22.34 --zookeeper_ip_list 22.22.22.53 22.22.22.35 22.22.22.34 --amqp_ip_list 22.22.22.35 22.22.22.34 --amqp_port 5672 --cfgm_ip 22.22.22.35 --self_collector_ip 22.22.22.53 --num_nodes 2 --analytics_syslog_port 19876 --kafka_enabled True --keystone_ip 22.22.22.34 --keystone_version v2.0 --keystone_admin_user admin --keystone_admin_passwd contrail123 --keystone_admin_tenant_name admin --keystone_auth_protocol http --keystone_auth_port 35357 --keystone_insecure True --aaa_mode cloud-admin"
2016-08-07 22:26:42:179274:
2016-08-07 22:26:42:179314: Aborting.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23066
Submitter: Ignatious Johnson Christopher (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23066
Committed: http://github.org/Juniper/contrail-provisioning/commit/751bb5c7cae54a0f7f50381d0740f7094bd9bc86
Submitter: Zuul
Branch: R3.1

commit 751bb5c7cae54a0f7f50381d0740f7094bd9bc86
Author: Ignatious Johnson Christopher <email address hidden>
Date: Mon Aug 8 15:59:43 2016 -0700

1.Passing certificate files to setup-vnc-collector to be used
when creating contrail-keystone-auth.conf and vnc_api_lib.ini
2. Setting api_server_use_ssl parameter in contrail-analytics-api
config file

Change-Id: I57cfea8b39a6479d6fc1b81479f66b1d2fb1f0d3
Closes-Bug: 1610879