DM: Configure local-as for bgp group

[Nischal Sheth]

The BgpRouterParams for a bgp-router contains a local-autonomous-system
field. Device manager should configure this local-autonomous-system value
(if non-zero) as the autonomous-system under the routing-options stanza.
It is expected that the local-autonomous-system value if set, will be
different than the autonomous-system.

Also, the peer-as for neighbors representing other bgp-routers (CNs or
other MXs etc.) should be set to the local-autonomous-system of bgp-router
in question. Similarly, this value should be used to determine if a
neighbor is internal or external.

[OpenContrail Admin (ci-admin-f)]

bug update...

[Shashikiran H (skiranh)]

We have a lot of testbeds which have AS as 64510. BGP will go down for mx peer for scripts which use DM. This is the error:
06/03/2016 04:24:53 PM [DeviceManager]: Router 10.204.217.190:
Error in neighbor 10.204.217.49 of group __contrail__:
internal peer's AS (64510) must be the same as the local AS (64512)

The bug needs a fix.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21356
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21362
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21356
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/21913
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/21356
Committed: http://github.org/Juniper/contrail-controller/commit/f0fabb591f5e0834f0fec31c9dcaaaf78ae4a41a
Submitter: Zuul
Branch: master

commit f0fabb591f5e0834f0fec31c9dcaaaf78ae4a41a
Author: sbalineni <email address hidden>
Date: Wed Jun 22 11:56:35 2016 -0700

[DM]: Configure local-as value if global asn is different

When mx bgp router is conifgured with 'local-autonomous-system',
DM should generate local-as conifguraion as follows.

protocols {
bgp {
group __contrail_external__ {
type internal;
neighbor 10.84.7.31 {
peer-as 1000;
}
}

More details in the bug.

Change-Id: If2cfb53095a6af64fa7f05e1d98c07beed7f6d0c
Closes-Bug: #1549614
Closes-Bug: #1451972

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/21913
Committed: http://github.org/Juniper/contrail-controller/commit/7571c0fe56a34b0eae7ed0ca3c7a7fb1917a52ac
Submitter: Zuul
Branch: R3.0

commit 7571c0fe56a34b0eae7ed0ca3c7a7fb1917a52ac
Author: sbalineni <email address hidden>
Date: Wed Jun 22 11:56:35 2016 -0700

[DM]: Configure local-as value if global asn is different

When mx bgp router is conifgured with 'local-autonomous-system',
DM should generate local-as conifguraion as follows.

protocols {
bgp {
group __contrail_external__ {
type internal;
neighbor 10.84.7.31 {
peer-as 1000;
}
}

More details in the bug.

Change-Id: If2cfb53095a6af64fa7f05e1d98c07beed7f6d0c
Closes-Bug: #1549614
Closes-Bug: #1451972

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/22296
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/22296
Committed: http://github.org/Juniper/contrail-controller/commit/72b715b777f50a96cffd5ab7970e9a5767725e07
Submitter: Zuul
Branch: R3.1

commit 72b715b777f50a96cffd5ab7970e9a5767725e07
Author: sbalineni <email address hidden>
Date: Wed Jun 22 11:56:35 2016 -0700

[DM]: Configure local-as value if global asn is different

When mx bgp router is conifgured with 'local-autonomous-system',
DM should generate local-as conifguraion as follows.

protocols {
bgp {
group __contrail_external__ {
type internal;
neighbor 10.84.7.31 {
peer-as 1000;
}
}

More details in the bug.

Change-Id: If2cfb53095a6af64fa7f05e1d98c07beed7f6d0c
Closes-Bug: #1549614
Closes-Bug: #1451972

[Shashikiran H (skiranh)]

Suresh,
Your fix seems to be different to the one Nischal mentioned with the techpubs link.
With your fix, routing-options AS stanza has to be deleted from the mx to make it work as there will be conflicting AS numbers in the configuration. This solution may not be feasible.

The right solution should be include "local-as" stanza in the DM command push for the group.

[Suresh Balineni (sbalineni)]

Hi Nischal,

Can you please let me know your input on Shashikiran's comment?

It was discussed that 'local-as' stanza is not needed for this configuration. You posted a review comment.

https://review.opencontrail.org/#/c/21356/

[Nischal Sheth (nsheth)]

I've updated the bug description to reflect the discussion that
happened during code review. The fix implements the changes in
the updated description, so we can set the status to Fix Committed.